app-usage-stats - npm Package Compare versions

Comparing version 0.3.1 to 0.3.2

es5/lib/stats.js

@@ -20,2 +20,4 @@ 'use strict';
     value: function add(stats) {
+      var _this = this;
+
       var _iteratorNormalCompletion = true;
@@ -26,6 +28,8 @@ var _didIteratorError = false;
       try {
-        for (var _iterator = arrayify(stats)[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
+        var _loop = function _loop() {
           var toAdd = _step.value;
 
-          var stat = this.stats.find(testValue.where({ dimension: toAdd.dimension }));
+          var stat = _this.stats.find(function (stat) {
+            return objectsEqual(stat.dimension, toAdd.dimension);
+          });
           if (!stat) {
@@ -61,3 +65,3 @@ stat = {
 
-            this.stats.push(stat);
+            _this.stats.push(stat);
           } else {
@@ -93,2 +97,6 @@ var _iteratorNormalCompletion3 = true;
           }
+        };
+
+        for (var _iterator = arrayify(stats)[Symbol.iterator](), _step; !(_iteratorNormalCompletion = (_step = _iterator.next()).done); _iteratorNormalCompletion = true) {
+          _loop();
         }
@@ -113,3 +121,3 @@ } catch (err) {
     value: function remove(stats) {
-      var _this = this;
+      var _this2 = this;
 
@@ -121,6 +129,8 @@ var _iteratorNormalCompletion4 = true;
       try {
-        var _loop = function _loop() {
+        var _loop2 = function _loop2() {
           var toRemove = _step4.value;
 
-          var stat = _this.stats.find(testValue.where({ dimension: toRemove.dimension }));
+          var stat = _this2.stats.find(function (stat) {
+            return objectsEqual(stat.dimension, toRemove.dimension);
+          });
           if (stat) {
@@ -158,3 +168,3 @@ var _iteratorNormalCompletion5 = true;
             if (metricTotal === 0) {
-              _this.stats.splice(_this.stats.indexOf(stat), 1);
+              _this2.stats.splice(_this2.stats.indexOf(stat), 1);
             }
@@ -165,3 +175,3 @@ }
         for (var _iterator4 = arrayify(stats)[Symbol.iterator](), _step4; !(_iteratorNormalCompletion4 = (_step4 = _iterator4.next()).done); _iteratorNormalCompletion4 = true) {
-          _loop();
+          _loop2();
         }
@@ -188,2 +198,6 @@ } catch (err) {
 
-module.exports = Stats;
+module.exports = Stats;
+
+function objectsEqual(a, b) {
+  return Object.keys(a).length === Object.keys(b).length && testValue(a, b);
+}

package.json

 {
   "name": "app-usage-stats",
   "author": "Lloyd Brookes <[e-mail]>",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "A convention for tracking javascript application usage",
@@ -6,0 +6,0 @@ "repository": "https://github.com/75lb/app-usage-stats.git",

src/lib/stats.js

@@ -11,3 +11,3 @@ 'use strict'
     for (const toAdd of arrayify(stats)) {
-      let stat = this.stats.find(testValue.where({ dimension: toAdd.dimension }))
+      let stat = this.stats.find(stat => objectsEqual(stat.dimension, toAdd.dimension))
       if (!stat) {
@@ -35,3 +35,3 @@ stat = {
     for (const toRemove of arrayify(stats)) {
-      let stat = this.stats.find(testValue.where({ dimension: toRemove.dimension }))
+      let stat = this.stats.find(stat => objectsEqual(stat.dimension, toRemove.dimension))
       if (stat) {
@@ -56,1 +56,5 @@ for (const metricName of Object.keys(toRemove.metric)) {
 module.exports = Stats
+
+function objectsEqual (a, b) {
+  return Object.keys(a).length === Object.keys(b).length && testValue(a, b)
+}

tmp/test/UA-70853320-4-lastSent.json

@@ -1,1 +0,1 @@
-1475265016481
[phone]

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53263

increased by0.82%

Lines of code

1303

increased by1.09%

No dependency changes