are-hook-inputs-equal - npm Package Compare versions

Comparing version 0.1.0 to 0.2.0

dist/are-hook-inputs-equal.cjs.js

@@ -5,17 +5,25 @@ 'use strict';
 
-// https://github.com/facebook/react/blob/e02086bfcc698d02a41a7785a1027a94dbc88eea/packages/react-reconciler/src/ReactFiberHooks.js#L763-L791
-function areHookInputsEqual(arr1, arr2) {
-  // Don't bother comparing lengths in prod because these arrays should be
-  // passed inline.
-  if (process.env.NODE_ENV !== 'production') {
-    console.warn(arr1.length === arr2.length, 'Detected a variable number of hook dependencies. The length of the ' + 'dependencies array should be constant between renders.\n\n' + ("Previous: " + arr1.join(', ') + "\n") + 'Incoming: ${arr2.join(', ')}');
+/**
+ * inlined Object.is polyfill to avoid requiring consumers ship their own
+ * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
+ */
+function objectIsPonyfill(x, y) {
+  return x === y && (x !== 0 || 1 / x === 1 / y) || x !== x && y !== y;
+}
+
+var is = typeof Object.is === 'function' ? Object.is : objectIsPonyfill; // https://github.com/facebook/react/blob/1022ee0ec140b8fce47c43ec57ee4a9f80f42eca/packages/react-reconciler/src/ReactFiberHooks.js#L326-L373
+
+function areHookInputsEqual(nextDeps, prevDeps) {
+  if (prevDeps === null) {
+    return false;
   }
 
-  for (var i = 0; i < arr1.length; i++) {
-    // Inlined Object.is polyfill.
-    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
-    var val1 = arr1[i];
-    var val2 = arr2[i];
+  if (process.env.NODE_ENV !== 'production' && nextDeps.length !== prevDeps.length) {
+    // Don't bother comparing lengths in prod because these arrays should be
+    // passed inline.
+    console.warn('Input have different size. The ' + 'order and size of this array must remain constant.\n\n' + ("Previous: [" + prevDeps.join(', ') + "]\n") + ("Incoming: [" + nextDeps.join(', ') + "]"));
+  }
 
-    if (val1 === val2 && (val1 !== 0 || 1 / val1 === 1 / val2) || val1 !== val1 && val2 !== val2) {
+  for (var i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
+    if (is(nextDeps[i], prevDeps[i])) {
       continue;
@@ -22,0 +30,0 @@ }

dist/are-hook-inputs-equal.esm.js

@@ -1,16 +0,24 @@
-// https://github.com/facebook/react/blob/e02086bfcc698d02a41a7785a1027a94dbc88eea/packages/react-reconciler/src/ReactFiberHooks.js#L763-L791
-function areHookInputsEqual(arr1, arr2) {
-  // Don't bother comparing lengths in prod because these arrays should be
-  // passed inline.
-  if (process.env.NODE_ENV !== 'production') {
-    console.warn(arr1.length === arr2.length, 'Detected a variable number of hook dependencies. The length of the ' + 'dependencies array should be constant between renders.\n\n' + ("Previous: " + arr1.join(', ') + "\n") + 'Incoming: ${arr2.join(', ')}');
+/**
+ * inlined Object.is polyfill to avoid requiring consumers ship their own
+ * https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
+ */
+function objectIsPonyfill(x, y) {
+  return x === y && (x !== 0 || 1 / x === 1 / y) || x !== x && y !== y;
+}
+
+var is = typeof Object.is === 'function' ? Object.is : objectIsPonyfill; // https://github.com/facebook/react/blob/1022ee0ec140b8fce47c43ec57ee4a9f80f42eca/packages/react-reconciler/src/ReactFiberHooks.js#L326-L373
+
+function areHookInputsEqual(nextDeps, prevDeps) {
+  if (prevDeps === null) {
+    return false;
   }
 
-  for (var i = 0; i < arr1.length; i++) {
-    // Inlined Object.is polyfill.
-    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/is
-    var val1 = arr1[i];
-    var val2 = arr2[i];
+  if (process.env.NODE_ENV !== 'production' && nextDeps.length !== prevDeps.length) {
+    // Don't bother comparing lengths in prod because these arrays should be
+    // passed inline.
+    console.warn('Input have different size. The ' + 'order and size of this array must remain constant.\n\n' + ("Previous: [" + prevDeps.join(', ') + "]\n") + ("Incoming: [" + nextDeps.join(', ') + "]"));
+  }
 
-    if (val1 === val2 && (val1 !== 0 || 1 / val1 === 1 / val2) || val1 !== val1 && val2 !== val2) {
+  for (var i = 0; i < prevDeps.length && i < nextDeps.length; i++) {
+    if (is(nextDeps[i], prevDeps[i])) {
       continue;
@@ -17,0 +25,0 @@ }

package.json

 {
   "name": "are-hook-inputs-equal",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "A comparator function for previous and current React hook inputs.",
@@ -5,0 +5,0 @@ "main": "./dist/are-hook-inputs-equal.cjs.js",

README.md

 # are-hook-inputs-equal
 
-A comparator function for previous and current React hook inputs. [Written by React team.](https://github.com/facebook/react/blob/e02086bfcc698d02a41a7785a1027a94dbc88eea/packages/react-reconciler/src/ReactFiberHooks.js#L763-L791)
+A comparator function for previous and current React hook inputs. [Written by React team.](https://github.com/facebook/react/blob/1022ee0ec140b8fce47c43ec57ee4a9f80f42eca/packages/react-reconciler/src/ReactFiberHooks.js#L326-L373)

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

3953

increased by10.95%

Lines of code

54

increased by28.57%

No dependency changes