array.prototype.flatmap - npm Package Compare versions

Comparing version 1.0.1 to 1.1.0

CHANGELOG.md

@@ -0,1 +1,7 @@
+1.1.0 / 2017-10-03
+=================
+  * [New] add explicit setting of “length” on target array
+  * [Fix] `FlattenIntoArray`: add assertion that `thisArg` and `mapperFunction` are both passed together
+  * [Tests] make coverage required
+
 1.0.1 / 2017-10-02
@@ -2,0 +8,0 @@ =================

implementation.js

@@ -7,3 +7,3 @@ 'use strict';
 
-// eslint-disable-next-line max-params, max-statements
+// eslint-disable-next-line max-params
 var FlattenIntoArray = function FlattenIntoArray(target, original, source, sourceLen, start, depth) {
@@ -17,6 +17,2 @@ var targetIndex = start;
 	}
-	var thisArg;
-	if (arguments.length > 7) {
-		thisArg = arguments[7];
-	}
 
@@ -29,3 +25,6 @@ while (sourceIndex < sourceLen) {
 			if (typeof mapperFunction !== 'undefined') {
-				element = ES.Call(mapperFunction, thisArg, [element, sourceIndex, original]);
+				if (arguments.length <= 7) {
+					throw new TypeError('Assertion failed: thisArg is required when mapperFunction is provided');
+				}
+				element = ES.Call(mapperFunction, arguments[7], [element, sourceIndex, original]);
 			}
@@ -64,4 +63,5 @@ var spreadable = ES.IsArray(element);
 	var A = ES.ArraySpeciesCreate(O, 0);
-	FlattenIntoArray(A, O, O, sourceLen, 0, 1, callbackfn, T);
+	var lastIndex = FlattenIntoArray(A, O, O, sourceLen, 0, 1, callbackfn, T);
+	ES.Set(A, 'length', lastIndex + 1, true);
 	return A;
 };

package.json

 {
 	"name": "array.prototype.flatmap",
-	"version": "1.0.1",
+	"version": "1.1.0",
 	"author": {
@@ -5,0 +5,0 @@ "name": "Jordan Harband",

test/tests.js

@@ -33,2 +33,10 @@ 'use strict';
 	});
+
+	t.test('sparse arrays', function (st) {
+		var identity = function (x) { return x; };
+		// eslint-disable-next-line no-sparse-arrays
+		st.deepEqual(flatMap([, [1]], identity), flatMap([[], [1]], identity), 'an array hole is treated the same as an empty array');
+
+		st.end();
+	});
 };

No alert changes

Improved metrics

Total package byte prevSize

19220

3.47%

Lines of code

157

3.97%

No dependency changes