augur-ui-react-components - npm Package Compare versions

Comparing version 3.0.1 to 3.0.2

package.json

 {
   "name": "augur-ui-react-components",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Augur UI React Components",
@@ -49,3 +49,3 @@ "author": "Baz (@thinkloop)",
   "devDependencies": {
-    "babel-eslint": "6.0.4",
+    "babel-eslint": "6.1.0",
     "babel-preset-es2015": "6.9.0",
@@ -61,6 +61,6 @@ "babel-preset-react": "6.5.0",
     "derequire": "2.0.3",
-    "envify": "3.4.0",
-    "eslint": "2.13.0",
+    "envify": "3.4.1",
+    "eslint": "2.13.1",
     "eslint-config-airbnb": "9.0.1",
-    "eslint-plugin-import": "1.8.1",
+    "eslint-plugin-import": "1.9.2",
     "eslint-plugin-jsx-a11y": "1.5.3",
@@ -74,11 +74,10 @@ "eslint-plugin-react": "5.2.2",
     "mocha": "2.5.3",
-		"moment": "^2.13.0",
     "npm-check-updates": "2.6.7",
     "onchange": "2.5.0",
     "react": "15.1.0",
-    "react-datetime": "^2.3.2",
+    "react-datetime": "2.3.2",
     "react-dom": "15.1.0",
     "react-highcharts": "8.3.3",
     "rimraf": "2.5.2",
-    "uglify-js": "2.6.2",
+    "uglify-js": "2.6.4",
     "watchify": "3.7.0"
@@ -85,0 +84,0 @@ },

README.md

@@ -1,1 +0,2 @@
-# augur-ui-react-components
+# augur-ui-react-components
+[![Build Status](https://travis-ci.org/AugurProject/augur-ui-react-components.svg?branch=master)](https://travis-ci.org/AugurProject/augur-ui-react-components)

src/modules/common/components/value-denomination.jsx

@@ -7,3 +7,2 @@ import React, { PropTypes } from 'react';
 		className={classnames('value-denomination', p.className, { positive: p.formattedValue > 0, negative: p.formattedValue < 0 })}
-		title={`${p.title}: ${p.value} ${p.denomination}`}
 	>
@@ -10,0 +9,0 @@ {(p.formatted) &&

src/modules/market/components/basics.jsx

@@ -19,17 +19,16 @@ import React, { PropTypes } from 'react';
 			{!!p.endDate &&
-				<li className="property end-date">
-					<span className="property-label">{(p.endDate && p.endDate.value < new Date()) ? 'ended' : 'ends'}</span>
+				<li className="property end-date" title={`${p.endDateLabel}: ${p.endDate.full}`}>
+					<span className="property-label">{p.endDateLabel}</span>
 					<ValueDenomination className="property-value" {...p.endDate} />
 				</li>
 			}
-			<li className="property fee">
-				<span className="property-label">fee</span>
-				<ValueDenomination className="property-value" {...p.tradingFeePercent} />
-				{p.makerFeePercent && p.takerFeePercent &&
-					<span>
-						(<ValueDenomination className="property-value" title="Maker Fee" {...p.makerFeePercent} /> /<ValueDenomination className="property-value" title="Taker Fee" {...p.takerFeePercent} />)
-					</span>
-				}
+			<li className="property fee" title="Discounted fee for placing bids or asks on the books">
+				<span className="property-label">maker fee</span>
+				<ValueDenomination className="property-value" {...p.makerFeePercent} />
 			</li>
-			<li className="property volume">
+			<li className="property fee" title="Fee for taking bids or asks from the books">
+				<span className="property-label">taker fee</span>
+				<ValueDenomination className="property-value" {...p.takerFeePercent} />
+			</li>
+			<li className="property volume" title={`${p.volume.rounded} total ${p.volume.denomination} traded`}>
 				<span className="property-label">volume</span>
@@ -45,3 +44,2 @@ <ValueDenomination className="property-value" {...p.volume} formatted={p.volume.rounded} />
 	endDate: PropTypes.object,
-	tradingFeePercent: PropTypes.object,
 	makerFeePercent: PropTypes.object,
@@ -48,0 +46,0 @@ takerFeePercent: PropTypes.object,

src/selectors/markets.js

@@ -28,2 +28,3 @@ import { makeNumber } from '../utils/make-number';
 		const id = index.toString();
+		const d = new Date('2017/12/12/');
 		const	m = {
@@ -33,6 +34,7 @@ id,
 			description: `Will the dwerps achieve a mwerp by the end of zwerp ${(index + 1)}?`,
-			endDate: { formatted: '12/12/2017' },
-			tradingFeePercent: makeNumber(randomInt(1, 10), '%', true),
-			makerFeePercent: makeNumber(randomInt(0, 100), '%', true),
-			volume: makeNumber(randomInt(0, 10000), 'Shares', true),
+			endDate: { formatted: `${d.getFullYear()}/${d.getMonth()}/${d.getDate() }`, full: d.toISOString() },
+			endDateLabel: (d < new Date()) ? 'ended' : 'ends',
+			takerFeePercent: makeNumber(randomInt(1, 10), '%', true),
+			makerFeePercent: makeNumber(randomInt(1, 5), '%', true),
+			volume: makeNumber(randomInt(0, 10000), 'shares', true),
 			isOpen: Math.random() > 0.1,
@@ -234,3 +236,3 @@ isPendingReport: Math.random() < 0.5,
 					position: {
-						qtyShares: makeNumber(16898, 'Shares'),
+						qtyShares: makeNumber(16898, 'shares'),
 						totalValue: makeNumber(14877, 'eth'),
@@ -237,0 +239,0 @@ gainPercent: makeNumber(14, '%'),

test/assertions/market.js

@@ -11,2 +11,3 @@ var assert = require('chai').assert;
 //      endDate: Object,
+//			endDateLabel: String,
 //      tradingFeePercent: Object,
@@ -42,6 +43,13 @@ //      volume: Object,
 
-	assert.isDefined(actual.tradingFeePercent, `market.tradingFeePercent isn't defined`);
-	assert.isObject(actual.tradingFeePercent, `market.tradingFeePercent isn't an object`);
-	percentNumberShape(actual.tradingFeePercent);
+	assert.isDefined(actual.endDateLabel, `market.endDateLabel isn't defined`);
+	assert.isString(actual.endDateLabel, `market.endDateLabel isn't an string`);
 
+	assert.isDefined(actual.takerFeePercent, `market.takerFeePercent isn't defined`);
+	assert.isObject(actual.takerFeePercent, `market.takerFeePercent isn't an object`);
+	percentNumberShape(actual.takerFeePercent);
+
+	assert.isDefined(actual.makerFeePercent, `market.makerFeePercent isn't defined`);
+	assert.isObject(actual.makerFeePercent, `market.makerFeePercent isn't an object`);
+	percentNumberShape(actual.makerFeePercent);
+
 	assert.isDefined(actual.volume, `market.volume isn't defined`);
@@ -48,0 +56,0 @@ assert.isObject(actual.volume, `market.volume isn't an object`);

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

1761068

increased by60.71%

Dev dependency count

32

decreased by-3.03%

Number of package files

239

increased by49.38%

Number of lines in readme file

3

increased by200%

Number of medium supply chain risk alerts

2

decreased by-33.33%

Worsened metrics

Lines of code

6755

decreased by-1.24%

No dependency changes