babel-plugin-htmlbars-inline-precompile - npm Package Compare versions

Comparing version 4.2.0 to 4.2.1

__tests__/tests.js

@@ -9,2 +9,3 @@ 'use strict';
 const TransformModules = require('@babel/plugin-transform-modules-amd');
+const TransformUnicodeEscapes = require('@babel/plugin-transform-unicode-escapes');
 const { stripIndent } = require('common-tags');
@@ -57,3 +58,5 @@
       */
-      function() { return \\"hello\\"; });"
+      function () {
+        return \\"hello\\";
+      });"
     `);
@@ -364,2 +367,17 @@ });
 
+  it('works properly when used along with @babel/plugin-transform-unicode-escapes', function () {
+    plugins.push([TransformUnicodeEscapes]);
+    let transformed = transform(
+      "import hbs from 'htmlbars-inline-precompile';\nvar compiled = hbs('some emoji goes 💥');"
+    );
+
+    expect(transformed).toMatchInlineSnapshot(`
+      "var compiled = Ember.HTMLBars.template(
+      /*
+        some emoji goes 💥
+      */
+      \\"precompiled(some emoji goes 💥)\\");"
+    `);
+  });
+
   it('replaces tagged template expressions when before babel-plugin-transform-es2015-template-literals', function () {
@@ -366,0 +384,0 @@ plugins.push([TransformTemplateLiterals]);

CHANGELOG.md

@@ -0,1 +1,10 @@
+## v4.2.1 (2020-11-09)
+
+#### :bug: Bug Fix
+* [#297](https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile/pull/297) Fix issues when using emoji in templates while transpiling for IE11 ([@rwjblue](https://github.com/rwjblue))
+
+#### Committers: 1
+- Robert Jackson ([@rwjblue](https://github.com/rwjblue))
+
+
 ## v4.2.0 (2020-08-10)
@@ -2,0 +11,0 @@

index.js

@@ -9,3 +9,2 @@ 'use strict';
   );
-  const parsePrecompiledTemplate = babel.template('PRECOMPILED');
 
@@ -58,7 +57,7 @@ function parseExpression(buildError, node) {
 
-    let precompileResult;
+    let precompileResultString;
 
     if (options.insertRuntimeErrors) {
       try {
-        precompileResult = precompile(template, options);
+        precompileResultString = precompile(template, options);
       } catch (error) {
@@ -68,9 +67,9 @@ return runtimeErrorIIFE({ ERROR_MESSAGE: error.message });
     } else {
-      precompileResult = precompile(template, options);
+      precompileResultString = precompile(template, options);
     }
 
-    let templateExpression = parsePrecompiledTemplate({
-      PRECOMPILED: precompileResult,
-    }).expression;
+    let precompileResultAST = babel.parse(`var precompileResult = ${precompileResultString};`);
 
+    let templateExpression = precompileResultAST.program.body[0].declarations[0].init;
+
     t.addComment(
@@ -77,0 +76,0 @@ templateExpression,

package.json

 {
   "name": "babel-plugin-htmlbars-inline-precompile",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "Babel plugin to replace tagged template strings with precompiled HTMLBars templates",
@@ -13,15 +13,16 @@ "repository": "https://github.com/ember-cli/babel-plugin-htmlbars-inline-precompile",
   "devDependencies": {
-    "@babel/core": "^7.11.1",
-    "@babel/plugin-transform-modules-amd": "^7.10.5",
-    "@babel/plugin-transform-template-literals": "^7.10.5",
+    "@babel/core": "^7.12.3",
+    "@babel/plugin-transform-modules-amd": "^7.12.1",
+    "@babel/plugin-transform-template-literals": "^7.12.1",
+    "@babel/plugin-transform-unicode-escapes": "^7.12.1",
     "common-tags": "^1.8.0",
-    "ember-source": "^3.20.3",
+    "ember-source": "^3.22.0",
     "eslint": "^6.8.0",
-    "eslint-config-prettier": "^6.11.0",
+    "eslint-config-prettier": "^6.15.0",
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.1.4",
-    "jest": "^26.2.2",
-    "prettier": "^2.0.5",
-    "release-it": "^13.6.6",
-    "release-it-lerna-changelog": "^2.3.0"
+    "jest": "^26.6.2",
+    "prettier": "^2.1.2",
+    "release-it": "^14.2.1",
+    "release-it-lerna-changelog": "^3.1.0"
   },
@@ -28,0 +29,0 @@ "engines": {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

44059

increased by2.3%

Lines of code

607

increased by2.36%

Worsened metrics

Dev dependency count

14

increased by7.69%

No dependency changes