backlog-api - npm Package Compare versions

Comparing version 0.9.0 to 0.10.0

lib/backlog.js

@@ -0,1 +1,2 @@
+var q = require('q');
 var xmlrpc = require('xmlrpc');
@@ -28,10 +29,22 @@ var methods = require('./backlog/');
   var args = {};
-  if (arguments.length == 1) {
+  if (arguments.length === 0) {
+    // fn() // promise
     args.params = {};
-    args.callback = arguments[0];
-  } else if (arguments.length == 2) {
+    // args.callback = undefined;
+  } else if (arguments.length === 1) {
+    if (typeof arguments[0] === 'function') {
+      // fn(callback)
+      args.params = {};
+      args.callback = arguments[0];
+    } else {
+      // fn(params)
+      args.params = arguments[0];
+      // args.callback = undefined;
+    }
+  } else if (arguments.length === 2) {
+    // fn(params, callback)
     args.params = arguments[0];
     args.callback = arguments[1];
   } else {
-    throw new Error('arguments length is not 1 or 2');
+    throw new Error('arguments length is invalid');
   }
@@ -43,3 +56,4 @@
   }
-  if (!args.callback || typeof args.callback !== 'function') {
+  if (typeof args.callback !== 'undefined' &&
+      typeof args.callback !== 'function') {
     throw new Error('"callback" is not a function');
@@ -82,6 +96,18 @@ }
       this, Array.prototype.slice.call(arguments));
+    var deferred = q.defer();
+    args.callback = args.callback || function(err, result) {
+      if (err) {
+        deferred.reject(err);
+      } else {
+        deferred.resolve(result);
+      }
+    };
     var err = this._validateParameters(method, args.params);
-    if (err) return args.callback(err, null);
-    var params = method.parseParams(args.params);
-    this._client().methodCall(method.name, params, args.callback);
+    if (err) {
+      args.callback(err, null);
+    } else {
+      var params = method.parseParams(args.params);
+      this._client().methodCall(method.name, params, args.callback);
+    }
+    return deferred.promise;
   };
@@ -88,0 +114,0 @@ });

package.json

 {
   "name": "backlog-api",
-  "version": "0.9.0",
+  "version": "0.10.0",
   "description": "Backlog API wrapper for Node.js",
   "main": "index.js",
   "scripts": {
-    "test": "mocha --reporter spec ",
+    "test": "mocha --reporter spec --ui bdd",
     "coveralls": "jscoverage lib && BACKLOG_API_COV=1 mocha -R mocha-lcov-reporter | coveralls"
@@ -21,10 +21,13 @@ },
   "dependencies": {
+    "q": "~1.0.0",
     "xmlrpc": "~1.1.1"
   },
   "devDependencies": {
+    "chai": "~1.9.0",
     "coveralls": "~2.6.0",
-    "expect.js": "~0.2.0",
     "jscoverage": "~0.3.8",
-    "mocha": "~1.15.1",
-    "mocha-lcov-reporter": "0.0.1"
+    "mocha-lcov-reporter": "0.0.1",
+    "sinon": "~1.8.1",
+    "sinon-chai": "~2.5.0",
+    "mocha": "~1.17.1"
   },
@@ -31,0 +34,0 @@ "keywords": [

README.md

@@ -86,15 +86,2 @@ backlog-api
 - backlog.createIssue
-- backlog.getTimeline
-- backlog.getProjectSummary
-- backlog.getProjectSummaries
-- backlog.getUser
-- backlog.getActivityTypes
-- backlog.getStatuses
-- backlog.getResolutions
-- backlog.getPriorities
-
-
-Todo
-------------------------------------------------------------------------------
-
 - backlog.updateIssue
@@ -112,4 +99,17 @@ - backlog.switchStatus
 - backlog.deleteComponent
+- backlog.getTimeline
+- backlog.getProjectSummary
+- backlog.getProjectSummaries
+- backlog.getUser
 - backlog.getUserIcon
+- backlog.getActivityTypes
+- backlog.getStatuses
+- backlog.getResolutions
+- backlog.getPriorities
 - backlog.getCustomFields
+
+
+Todo
+------------------------------------------------------------------------------
+
 - backlog.getChildIssues
@@ -116,0 +116,0 @@ - backlog.admin.getUsers

New alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Fixed alerts

URL strings

Supply chain risk

Package contains fragments of external URLs or IP addresses, which the package may be accessing at runtime.

Found 1 instance in 1 package

Improved metrics

Number of low supply chain risk alerts

7

-72%

Worsened metrics

Total package byte prevSize

16310

-70.79%

Dependency count

2

100%

Dev dependency count

7

40%

Number of package files

39

-13.33%

Lines of code

477

-70.39%

Number of medium supply chain risk alerts

1

Infinity%

Dependency changes

• + Added

  q@~1.0.0

• + Added

  q@1.0.1
  (transitive)