base-x - npm Package Compare versions

Comparing version 1.0.2 to 1.0.3

index.js

@@ -9,2 +9,6 @@ // base-x encoding
 
+/**
+ * @param {string} ALPHABET
+ * @return {encode: function, decode: function}
+ */
 module.exports = function base (ALPHABET) {
@@ -20,24 +24,23 @@ var ALPHABET_MAP = {}
 
-  function encode (buffer) {
-    if (buffer.length === 0) return ''
+  /**
+   * @param {(Buffer|number[])} source
+   * @return {string}
+   */
+  function encode (source) {
+    if (source.length === 0) return ''
 
-    var i, j
     var digits = [0]
+    for (var i = 0; i < source.length; ++i) {
+      var carry = (digits[0] << 8) + source[i]
+      digits[0] = carry % BASE
+      carry = (carry / BASE) | 0
 
-    for (i = 0; i < buffer.length; i++) {
-      for (j = 0; j < digits.length; j++) digits[j] <<= 8
-
-      digits[0] += buffer[i]
-
-      var carry = 0
-      for (j = 0; j < digits.length; ++j) {
-        digits[j] += carry
-
-        carry = (digits[j] / BASE) | 0
-        digits[j] %= BASE
+      for (var j = 1; j < digits.length; ++j) {
+        carry += digits[j] << 8
+        digits[j] = carry % BASE
+        carry = (carry / BASE) | 0
       }
 
-      while (carry) {
+      while (carry > 0) {
         digits.push(carry % BASE)
-
         carry = (carry / BASE) | 0
@@ -48,3 +51,3 @@ }
     // deal with leading zeros
-    for (i = 0; buffer[i] === 0 && i < buffer.length - 1; i++) {
+    for (var k = 0; source[k] === 0 && k < source.length - 1; ++k) {
       digits.push(0)
@@ -54,34 +57,35 @@ }
     // convert digits to a string
-    var str = ''
-    for (i = digits.length - 1; i >= 0; i--) {
-      str += ALPHABET[digits[i]]
+    for (var ii = 0, jj = digits.length - 1; ii <= jj; ++ii, --jj) {
+      var tmp = ALPHABET[digits[ii]]
+      digits[ii] = ALPHABET[digits[jj]]
+      digits[jj] = tmp
     }
 
-    return str
+    return digits.join('')
   }
 
+  /**
+   * @param {string} string
+   * @return {number[]}
+   */
   function decode (string) {
     if (string.length === 0) return []
 
-    var i, j
     var bytes = [0]
+    for (var i = 0; i < string.length; i++) {
+      var value = ALPHABET_MAP[string[i]]
+      if (value === undefined) throw new Error('Non-base' + BASE + ' character')
 
-    for (i = 0; i < string.length; i++) {
-      var c = string[i]
-      if (!(c in ALPHABET_MAP)) throw new Error('Non-base' + BASE + ' character')
+      var carry = bytes[0] * BASE + value
+      bytes[0] = carry & 0xff
+      carry >>= 8
 
-      for (j = 0; j < bytes.length; j++) bytes[j] *= BASE
-      bytes[0] += ALPHABET_MAP[c]
-
-      var carry = 0
-      for (j = 0; j < bytes.length; ++j) {
-        bytes[j] += carry
-
-        carry = bytes[j] >> 8
-        bytes[j] &= 0xff
+      for (var j = 1; j < bytes.length; ++j) {
+        carry += bytes[j] * BASE
+        bytes[j] = carry & 0xff
+        carry >>= 8
       }
 
-      while (carry) {
+      while (carry > 0) {
         bytes.push(carry & 0xff)
-
         carry >>= 8
@@ -92,3 +96,3 @@ }
     // deal with leading zeros
-    for (i = 0; string[i] === LEADER && i < string.length - 1; i++) {
+    for (var k = 0; string[k] === LEADER && k < string.length - 1; ++k) {
       bytes.push(0)
@@ -95,0 +99,0 @@ }

package.json

 {
   "name": "base-x",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "Fast base encoding / decoding of any given alphabet",
-  "main": "index.js",
-  "scripts": {
-    "standard": "standard",
-    "test": "npm run unit && npm run standard",
-    "unit": "mocha"
-  },
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/dcousens/base-x.git"
-  },
-  "bugs": {
-    "url": "https://github.com/dcousens/base-x/issues"
-  },
-  "homepage": "https://github.com/dcousens/base-x",
   "keywords": [
@@ -31,8 +17,28 @@ "base-x",
   ],
+  "homepage": "https://github.com/cryptocoinjs/base-x",
+  "bugs": {
+    "url": "https://github.com/cryptocoinjs/base-x/issues"
+  },
+  "license": "MIT",
   "author": "Daniel Cousens",
-  "license": "MIT",
+  "files": [
+    "index.js",
+    "README.md"
+  ],
+  "main": "index.js",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/cryptocoinjs/base-x.git"
+  },
+  "scripts": {
+    "benchmark:node": "node benchmark/benchmark.js",
+    "standard": "standard",
+    "test": "npm run unit && npm run standard",
+    "unit": "mocha"
+  },
   "devDependencies": {
-    "mocha": "*",
-    "standard": "*"
+    "benchmark": "^2.0.0",
+    "mocha": "^2.3.4",
+    "standard": "^5.4.1"
   }
 }

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

6094

increased by4.71%

Lines of code

86

increased by14.67%

Worsened metrics

Dev dependency count

3

increased by50%

Number of package files

3

decreased by-40%

No dependency changes