broadcast-channel - npm Package Compare versions

Comparing version 2.1.7 to 2.1.8

dist/es/methods/node.js

@@ -467,11 +467,12 @@ import _regeneratorRuntime from "@babel/runtime/regenerator";
             client = new net.Socket();
-            _context12.next = 4;
-            return new Promise(function (res) {
-              client.connect(pathToSocket, res);
-            });
+            return _context12.abrupt("return", new Promise(function (res, rej) {
+              client.connect(pathToSocket, function () {
+                return res(client);
+              });
+              client.on('error', function (err) {
+                return rej(err);
+              });
+            }));
 
-          case 4:
-            return _context12.abrupt("return", client);
-
-          case 5:
+          case 3:
           case "end":
@@ -941,16 +942,25 @@ return _context12.stop();
               case 3:
-                _context2.next = 5;
+                _context2.prev = 3;
+                _context2.next = 6;
                 return openClientConnection(channelState.channelName, readerUuid);
 
-              case 5:
+              case 6:
                 client = _context2.sent;
                 channelState.otherReaderClients[readerUuid] = client;
-                _context2.next = 11;
+                _context2.next = 12;
                 break;
 
-              case 9:
-                _context2.prev = 9;
-                _context2.t0 = _context2["catch"](0);
+              case 10:
+                _context2.prev = 10;
+                _context2.t0 = _context2["catch"](3);
 
-              case 11:
+              case 12:
+                _context2.next = 16;
+                break;
+
+              case 14:
+                _context2.prev = 14;
+                _context2.t1 = _context2["catch"](0);
+
+              case 16:
               case "end":
@@ -960,3 +970,3 @@ return _context2.stop();
           }
-        }, _callee2, this, [[0, 9]]);
+        }, _callee2, this, [[0, 14], [3, 10]]);
       }));
@@ -1092,5 +1102,8 @@
   });
-  if (channelState.infoFilePath) unlink(channelState.infoFilePath)["catch"](function () {
-    return null;
-  });
+
+  if (channelState.infoFilePath) {
+    try {
+      fs.unlinkSync(channelState.infoFilePath);
+    } catch (err) {}
+  }
 }
@@ -1097,0 +1110,0 @@

dist/lib/methods/node.js

@@ -472,11 +472,12 @@ "use strict";
             client = new net.Socket();
-            _context12.next = 4;
-            return new Promise(function (res) {
-              client.connect(pathToSocket, res);
-            });
+            return _context12.abrupt("return", new Promise(function (res, rej) {
+              client.connect(pathToSocket, function () {
+                return res(client);
+              });
+              client.on('error', function (err) {
+                return rej(err);
+              });
+            }));
 
-          case 4:
-            return _context12.abrupt("return", client);
-
-          case 5:
+          case 3:
           case "end":
@@ -946,16 +947,25 @@ return _context12.stop();
               case 3:
-                _context2.next = 5;
+                _context2.prev = 3;
+                _context2.next = 6;
                 return openClientConnection(channelState.channelName, readerUuid);
 
-              case 5:
+              case 6:
                 client = _context2.sent;
                 channelState.otherReaderClients[readerUuid] = client;
-                _context2.next = 11;
+                _context2.next = 12;
                 break;
 
-              case 9:
-                _context2.prev = 9;
-                _context2.t0 = _context2["catch"](0);
+              case 10:
+                _context2.prev = 10;
+                _context2.t0 = _context2["catch"](3);
 
-              case 11:
+              case 12:
+                _context2.next = 16;
+                break;
+
+              case 14:
+                _context2.prev = 14;
+                _context2.t1 = _context2["catch"](0);
+
+              case 16:
               case "end":
@@ -965,3 +975,3 @@ return _context2.stop();
           }
-        }, _callee2, this, [[0, 9]]);
+        }, _callee2, this, [[0, 14], [3, 10]]);
       }));
@@ -1097,5 +1107,8 @@
   });
-  if (channelState.infoFilePath) unlink(channelState.infoFilePath)["catch"](function () {
-    return null;
-  });
+
+  if (channelState.infoFilePath) {
+    try {
+      fs.unlinkSync(channelState.infoFilePath);
+    } catch (err) {}
+  }
 }
@@ -1102,0 +1115,0 @@

package.json

 {
   "name": "broadcast-channel",
-  "version": "2.1.7",
+  "version": "2.1.8",
   "description": "A BroadcastChannel implementation that works with new browsers, older browsers and Node.js",
@@ -92,3 +92,3 @@ "homepage": "https://github.com/pubkey/broadcast-channel#readme",
     "cross-env": "5.2.0",
-    "eslint": "5.8.0",
+    "eslint": "5.9.0",
     "gzip-size-cli": "3.0.0",
@@ -109,7 +109,7 @@ "http-server": "0.11.1",
     "mocha": "5.2.0",
-    "node": "11.0.0",
+    "node": "11.1.0",
     "pre-commit": "1.2.2",
     "random-int": "1.0.0",
     "random-token": "0.0.8",
-    "testcafe": "0.23.1",
+    "testcafe": "0.23.2",
     "testcafe-hammerhead": "14.4.1",
@@ -116,0 +116,0 @@ "ts-node": "7.0.1",

src/methods/node.js

@@ -238,9 +238,9 @@ /**
     const client = new net.Socket();
-    await new Promise(res => {
+    return new Promise((res, rej) => {
         client.connect(
             pathToSocket,
-            res
+            () => res(client)
         );
+        client.on('error', err => rej(err));
     });
-    return client;
 }
@@ -511,4 +511,9 @@
                         if (channelState.closed) return;
-                        const client = await openClientConnection(channelState.channelName, readerUuid);
-                        channelState.otherReaderClients[readerUuid] = client;
+                        try {
+                            const client = await openClientConnection(channelState.channelName, readerUuid);
+                            channelState.otherReaderClients[readerUuid] = client;
+                        } catch (err) {
+                            // this can throw when the cleanup of another channel was interrupted
+                            // or the socket-file does not exits yet
+                        }
                     } catch (err) {
@@ -625,4 +630,7 @@ // this might throw if the other channel is closed at the same time when this one is running refresh
 
-    if (channelState.infoFilePath)
-        unlink(channelState.infoFilePath).catch(() => null);
+    if (channelState.infoFilePath) {
+        try {
+            fs.unlinkSync(channelState.infoFilePath);
+        } catch (err) {}
+    }
 }
@@ -629,0 +637,0 @@

No alert changes

Improved metrics

Total package byte prevSize

204792

increased by0.51%

Lines of code

5659

increased by0.53%

No dependency changes