cache-manager-redis-store - npm Package Compare versions

Comparing version 1.2.0 to 1.3.0

dist/index.js

@@ -56,10 +56,26 @@ 'use strict';
     del: function del(key, options, cb) {
-      if (typeof options === 'function') {
-        cb = options;
-      }
+      return new Promise(function (resolve, reject) {
+        if (typeof options === 'function') {
+          cb = options;
+        }
 
-      redisCache.del(key, handleResponse(cb));
+        if (!cb) {
+          cb = function cb(err, result) {
+            return err ? reject(err) : resolve(result);
+          };
+        }
+
+        redisCache.del(key, handleResponse(cb));
+      });
     },
     reset: function reset(cb) {
-      return redisCache.flushdb(handleResponse(cb));
+      return new Promise(function (resolve, reject) {
+        if (!cb) {
+          cb = function cb(err, result) {
+            return err ? reject(err) : resolve(result);
+          };
+        }
+
+        redisCache.flushdb(handleResponse(cb));
+      });
     },
@@ -83,3 +99,11 @@ keys: function keys(pattern, cb) {
     ttl: function ttl(key, cb) {
-      return redisCache.ttl(key, handleResponse(cb));
+      return new Promise(function (resolve, reject) {
+        if (!cb) {
+          cb = function cb(err, result) {
+            return err ? reject(err) : resolve(result);
+          };
+        }
+
+        redisCache.ttl(key, handleResponse(cb));
+      });
     },
@@ -86,0 +110,0 @@ isCacheableValue: storeArgs.is_cacheable_value || function (value) {

index.js

@@ -45,10 +45,24 @@ import Redis from 'redis';
     ),
-    del: (key, options, cb) => {
-      if (typeof options === 'function') {
-        cb = options;
-      }
+    del: (key, options, cb) => (
+      new Promise((resolve, reject) => {
+        if (typeof options === 'function') {
+          cb = options;
+        }
 
-      redisCache.del(key, handleResponse(cb));
-    },
-    reset: cb => redisCache.flushdb(handleResponse(cb)),
+        if (!cb) {
+          cb = (err, result) => (err ? reject(err) : resolve(result));
+        }
+  
+        redisCache.del(key, handleResponse(cb));
+      })
+    ),
+    reset: cb => (
+      new Promise((resolve, reject) => {
+        if (!cb) {
+          cb = (err, result) => (err ? reject(err) : resolve(result));
+        }
+  
+        redisCache.flushdb(handleResponse(cb));
+      })
+    ),
     keys: (pattern, cb) => (
@@ -68,3 +82,11 @@ new Promise((resolve, reject) => {
     ),
-    ttl: (key, cb) => redisCache.ttl(key, handleResponse(cb)),
+    ttl: (key, cb) => (
+      new Promise((resolve, reject) => {
+        if (!cb) {
+          cb = (err, result) => (err ? reject(err) : resolve(result));
+        }
+
+        redisCache.ttl(key, handleResponse(cb));
+      })
+    ),
     isCacheableValue: storeArgs.is_cacheable_value || (value => value !== undefined && value !== null),
@@ -71,0 +93,0 @@ };

package.json

 {
   "name": "cache-manager-redis-store",
   "author": "Matthijs Dabroek <[e-mail]>",
-  "description": "Redis store for node-cache-manager module",
-  "version": "1.2.0",
+  "description": "Redis store for node-cache-manager",
+  "version": "1.3.0",
   "license": "MIT",
@@ -14,3 +14,4 @@ "main": "dist/index.js",
     "prepublish": "npm prune",
-    "test": "jest",
+    "test": "jest --forceExit",
+    "test-cov": "jest --forceExit --coverage && cat ./coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js",
     "build": "rollup -c"
@@ -23,8 +24,10 @@ },
     "babel-cli": "^6.24.1",
-    "babel-jest": "^19.0.0",
+    "babel-jest": "^20.0.3",
     "babel-plugin-external-helpers": "^6.22.0",
     "babel-plugin-transform-runtime": "^6.23.0",
     "babel-preset-es2015": "^6.24.1",
+    "babel-runtime": "^6.26.0",
     "cache-manager": "^2.4.0",
-    "jest": "^19.0.2",
+    "coveralls": "^2.13.1",
+    "jest": "^20.0.4",
     "rollup": "^0.41.6",
@@ -31,0 +34,0 @@ "rollup-plugin-babel": "^2.7.1"

README.md

@@ -0,1 +1,7 @@
+[![build status](https://travis-ci.org/dabroek/node-cache-manager-redis-store.svg?branch=master)](https://travis-ci.org/dabroek/node-cache-manager-redis-store)
+[![coverage status](https://coveralls.io/repos/github/dabroek/node-cache-manager-redis-store/badge.svg?branch=master)](https://coveralls.io/github/dabroek/node-cache-manager-redis-store?branch=master)
+[![dependencies status](https://david-dm.org/dabroek/node-cache-manager-redis-store/status.svg)](https://david-dm.org/dabroek/node-cache-manager-redis-store)
+[![npm version](https://badge.fury.io/js/cache-manager-redis-store.svg)](https://badge.fury.io/js/cache-manager-redis-store)
+[![GitHub issues](https://img.shields.io/github/issues/dabroek/node-cache-manager-redis-store.svg)](https://github.com/dabroek/node-cache-manager-redis-store/issues)
+
 Redis store for node cache manager
@@ -44,3 +50,3 @@ ==================================
 // listen for redis connection error event
-var redisClient = redisCache.getClient();
+var redisClient = redisCache.store.getClient();
 
@@ -47,0 +53,0 @@ redisClient.on('error', (error) => {

test/index.test.js

@@ -12,6 +12,6 @@ import cacheManager from 'cache-manager';
   db: 0,
-  ttl: 60,
+  ttl: 5,
 };
 
-beforeEach(() => {
+beforeEach((done) => {
   redisCache = cacheManager.caching({
@@ -42,2 +42,4 @@ store: redisStore,
   });
+
+  redisCache.store.getClient().once('ready', () => redisCache.reset(done));
 });
@@ -65,3 +67,2 @@
   });
-
 });
@@ -209,3 +210,3 @@
   it('should retrieve a value for a given key', (done) => {
-    var value = 'bar';
+    const value = 'bar';
     redisCache.set('foo', value, () => {
@@ -221,3 +222,3 @@ redisCache.get('foo', (err, result) => {
   it('should retrieve a value for a given key if options provided', (done) => {
-    var value = 'bar';
+    const value = 'bar';
     redisCache.set('foo', value, () => {
@@ -250,2 +251,7 @@ redisCache.get('foo', {}, (err, result) => {
 describe('del', () => {
+  it('should return a promise', (done) => {
+    expect(redisCache.del('foo')).toBeInstanceOf(Promise);
+    done();
+  });
+  
   it('should delete a value for a given key', (done) => {
@@ -277,2 +283,7 @@ redisCache.set('foo', 'bar', () => {
 describe('reset', () => {
+  it('should return a promise', (done) => {
+    expect(redisCache.reset()).toBeInstanceOf(Promise);
+    done();
+  });
+
   it('should flush underlying db', (done) => {
@@ -300,2 +311,7 @@ redisCache.reset((err) => {
 describe('ttl', () => {
+  it('should return a promise', (done) => {
+    expect(redisCache.ttl('foo')).toBeInstanceOf(Promise);
+    done();
+  });
+
   it('should retrieve ttl for a given key', (done) => {
@@ -416,3 +432,5 @@ redisCache.set('foo', 'bar', () => {
       store: redisStore,
-      isCacheableValue: () => { return 'I was overridden'; }
+      isCacheableValue: () => {
+        return 'I was overridden';
+      }
     });
@@ -432,3 +450,3 @@ });
     redisCache2 = cacheManager.caching({
-      store: redisStore
+      store: redisStore,
     });
@@ -435,0 +453,0 @@ });

Fixed alerts

Major refactor

Supply chain risk

Package has recently undergone a major refactor. It may be unstable or indicate significant internal changes. Use caution when updating to versions that include significant changes.

Found 1 instance in 1 package

Improved metrics

Lines of code

675

increased by8.87%

Number of lines in readme file

153

increased by4.08%

Number of medium supply chain risk alerts

0

decreased by-100%

Worsened metrics

Total package byte prevSize

26956

decreased by-77.32%

Dev dependency count

11

increased by22.22%

No dependency changes