can-route - npm Package Compare versions

Comparing version 4.3.2 to 4.3.3

can-route.js

@@ -74,2 +74,7 @@ "use strict";
 		bindingProxy.call("can.setValue", path);
+
+		if (canRoute._onStartComplete) {
+			canRoute._onStartComplete();
+			canRoute._onStartComplete = undefined;
+		}
 	}, 10);
@@ -76,0 +81,0 @@ }

package.json

 {
   "name": "can-route",
-  "version": "4.3.2",
+  "version": "4.3.3",
   "description": "Observable front-end application routing for CanJS.",
@@ -5,0 +5,0 @@ "homepage": "https://canjs.com/doc/can-route.html",

test/route-define-test.js

@@ -61,9 +61,8 @@ /* jshint asi:true */
 
+			iCanRoute._onStartComplete = function () {
+				iframe.src = iframe.src + '#!bla=blu';
+			};
+
 			iCanRoute.start();
-
-			setTimeout(function () {
-				iframe.src = iframe.src + '#!bla=blu';
-			}, 10);
 		});
-
 	});
@@ -75,3 +74,2 @@
 			iCanRoute.serializedCompute.bind('change', function outerChange() {
-
 				equal(iCanRoute.attr('foo'), 'bar', 'expected value for foo');
@@ -87,2 +85,3 @@ iCanRoute.serializedCompute.unbind('change');
 				});
+
 				setTimeout(function () {
@@ -93,7 +92,8 @@ iframe.contentWindow.location.hash = '#!personId=3';
 			});
-			iCanRoute.start();
-			setTimeout(function () {
 
+			iCanRoute._onStartComplete = function () {
 				iframe.contentWindow.location.hash = '#!foo=bar';
-			}, 100);
+			};
+
+			iCanRoute.start();
 		});
@@ -104,3 +104,2 @@ });
 		setupRouteTest(function (iframe, iCanRoute, loc) {
-
 			iCanRoute.register("{type}/{id}");
@@ -112,7 +111,3 @@ var AppState = DefineMap.extend({seal: false},{});
 
-			loc.hash = "#!cat/5";
-			iCanRoute.start();
-
-			setTimeout(function () {
-
+			iCanRoute._onStartComplete = function () {
 				var after = loc.href.substr(loc.href.indexOf("#"));
@@ -123,5 +118,6 @@ equal(after, "#!cat/5", "same URL");
 				teardownRouteTest();
+			};
 
-			}, 30);
-
+			loc.hash = "#!cat/5";
+			iCanRoute.start();
 		});
@@ -134,3 +130,2 @@ });
 
-
 		canRoute.register("{type}/{id}");
@@ -141,7 +136,4 @@ var AppState = DefineMap.extend({seal: false},{});
 		canRoute.data = appState;
-		mockRoute.hash.value = "#!cat/5"; // type and id get added ... this will call update url to add everything
-		canRoute.start();
 
-		setTimeout(function () {
-
+		canRoute._onStartComplete = function () {
 			equal(mockRoute.hash.value, "cat/5&section=home", "same URL");
@@ -153,8 +145,8 @@ equal(appState.get("type"), "cat", "hash populates the appState");
 
-
 			mockRoute.stop();
 			QUnit.start();
-		}, 30);
+		};
 
-
+		mockRoute.hash.value = "#!cat/5"; // type and id get added ... this will call update url to add everything
+		canRoute.start();
 	});
@@ -164,3 +156,2 @@
 		setupRouteTest(function (iframe, iCanRoute, loc) {
-
 			iCanRoute.start();
@@ -174,3 +165,2 @@ iCanRoute.register("{type}/{id}");
 			setTimeout(function () {
-
 				var after = loc.href.substr(loc.href.indexOf("#"));
@@ -180,3 +170,2 @@ equal(after, "#!bar/" + encodeURIComponent("\/"));
 				teardownRouteTest();
-
 			}, 30);
@@ -183,0 +172,0 @@ });

test/route-map-test.js

@@ -50,3 +50,2 @@ /* jshint asi:true */
 			iCanRoute.bind('change', function () {
-
 				equal(iCanRoute.attr('bla'), 'blu', 'Got route change event and value is as expected');
@@ -56,8 +55,7 @@ teardownRouteTest();
 
+			iCanRoute._onStartComplete = function () {
+				iframe.src = iframe.src + '#!bla=blu';
+			};
+
 			iCanRoute.start();
-
-			setTimeout(function () {
-
-				iframe.src = iframe.src + '#!bla=blu';
-			}, 50);
 		});
@@ -90,7 +88,8 @@
 			});
-			iCanRoute.start();
-			setTimeout(function () {
 
+			iCanRoute._onStartComplete = function () {
 				iframe.contentWindow.location.hash = '#!foo=bar';
-			}, 100);
+			};
+
+			iCanRoute.start();
 		});
@@ -108,7 +107,3 @@ });
 
-			loc.hash = "#!cat/5";
-			iCanRoute.start();
-
-			setTimeout(function () {
-
+			iCanRoute._onStartComplete = function () {
 				var after = loc.href.substr(loc.href.indexOf("#"));
@@ -119,5 +114,6 @@ equal(after, "#!cat/5", "same URL");
 				teardownRouteTest();
+			};
 
-			}, 30);
-
+			loc.hash = "#!cat/5";
+			iCanRoute.start();
 		});
@@ -134,7 +130,4 @@ });
 			iCanRoute.data = appState;
-			loc.hash = "#!cat/5";
-			iCanRoute.start();
 
-			setTimeout(function () {
-
+			iCanRoute._onStartComplete = function () {
 				var after = loc.href.substr(loc.href.indexOf("#"));
@@ -149,5 +142,6 @@ equal(after, "#!cat/5&section=home", "same URL");
 				teardownRouteTest();
+			};
 
-			}, 30);
-
+			loc.hash = "#!cat/5";
+			iCanRoute.start();
 		});
@@ -154,0 +148,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

106066

increased by0.19%

Lines of code

2390

increased by0.17%

No dependency changes