can-route - npm Package Compare versions

Comparing version 4.3.3 to 4.3.4

package.json

 {
   "name": "can-route",
-  "version": "4.3.3",
+  "version": "4.3.4",
   "description": "Observable front-end application routing for CanJS.",
@@ -5,0 +5,0 @@ "homepage": "https://canjs.com/doc/can-route.html",

test/route-define-test.js

@@ -146,2 +146,9 @@ /* jshint asi:true */
 		setupRouteTest(function (iframe, iCanRoute, loc) {
+			iCanRoute._onStartComplete = function () {
+				var after = loc.href.substr(loc.href.indexOf("#"));
+				equal(after, "#!bar/" + encodeURIComponent("\/"));
+
+				teardownRouteTest();
+			};
+
 			iCanRoute.start();
@@ -154,8 +161,2 @@ iCanRoute.register("{type}/{id}");
 
-			setTimeout(function () {
-				var after = loc.href.substr(loc.href.indexOf("#"));
-				equal(after, "#!bar/" + encodeURIComponent("\/"));
-
-				teardownRouteTest();
-			}, 30);
 		});
@@ -255,3 +256,2 @@ });
 		setupRouteTest(function (iframe, iCanRoute, loc) {
-			iCanRoute.start();
 			var hash1 = canRoute.url({
@@ -277,3 +277,3 @@ panelA: {
 
-			setTimeout(function() {
+			iCanRoute._onStartComplete = function() {
 				equal(iCanRoute.data.get('panelA').id, 20, "id should change");
@@ -283,4 +283,5 @@ equal(iCanRoute.data.get('panelA').show, undefined, "show should be removed");
 				teardownRouteTest();
-			}, 30);
+			};
 
+			iCanRoute.start();
 		});
@@ -287,0 +288,0 @@ });

test/route-map-test.js

@@ -145,3 +145,9 @@ /* jshint asi:true */
 		setupRouteTest(function (iframe, iCanRoute, loc) {
+			iCanRoute._onStartComplete = function () {
+				var after = loc.href.substr(loc.href.indexOf("#"));
+				equal(after, "#!bar/" + encodeURIComponent("\/"));
 
+				teardownRouteTest();
+			};
+
 			iCanRoute.start();
@@ -153,11 +159,2 @@ iCanRoute.register("{type}/{id}");
 			});
-
-			setTimeout(function () {
-
-				var after = loc.href.substr(loc.href.indexOf("#"));
-				equal(after, "#!bar/" + encodeURIComponent("\/"));
-
-				teardownRouteTest();
-
-			}, 30);
 		});
@@ -230,2 +227,9 @@ });
 		setupRouteTest(function (iframe, iCanRoute, loc) {
+			iCanRoute._onStartComplete = function() {
+				equal(iCanRoute.attr("panelA.id"), 20, "id should change");
+				equal(iCanRoute.attr("panelA.show"), undefined, "show should be removed");
+
+				teardownRouteTest();
+			};
+
 			iCanRoute.start();
@@ -247,14 +251,5 @@ var hash1 = canRoute.url({
 
-
 			loc.hash = hash1;
 
 			loc.hash = hash2;
-
-			setTimeout(function() {
-				equal(iCanRoute.attr("panelA.id"), 20, "id should change");
-				equal(iCanRoute.attr("panelA.show"), undefined, "show should be removed");
-
-				teardownRouteTest();
-			}, 30);
-
 		});
@@ -261,0 +256,0 @@ });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

106718

increased by0.61%

No dependency changes