canvas - npm Package Compare versions

Comparing version 2.0.0-alpha.4 to 2.0.0-alpha.5

lib/canvas.js

@@ -68,19 +68,2 @@ 'use strict';
 /**
- * Create a synchronous `PNGStream` for `this` canvas.
- *
- * @param {Object} options
- * @param {Uint8ClampedArray} options.palette Provide for indexed PNG encoding.
- *   entries should be R-G-B-A values.
- * @param {Number} options.backgroundIndex Optional index of background color
- *   for indexed PNGs. Defaults to 0.
- * @return {PNGStream}
- * @api public
- */
-
-Canvas.prototype.syncPNGStream =
-Canvas.prototype.createSyncPNGStream = function(options){
-  return new PNGStream(this, true, options);
-};
-
-/**
  * Create a `PDFStream` for `this` canvas.
@@ -98,14 +81,2 @@ *
 /**
- * Create a synchronous `PDFStream` for `this` canvas.
- *
- * @return {PDFStream}
- * @api public
- */
-
-Canvas.prototype.syncPDFStream =
-Canvas.prototype.createSyncPDFStream = function(){
-  return new PDFStream(this, true);
-};
-
-/**
  * Create a `JPEGStream` for `this` canvas.
@@ -120,15 +91,2 @@ *
 Canvas.prototype.createJPEGStream = function(options){
-  return this.createSyncJPEGStream(options);
-};
-
-/**
- * Create a synchronous `JPEGStream` for `this` canvas.
- *
- * @param {Object} options
- * @return {JPEGStream}
- * @api public
- */
-
-Canvas.prototype.syncJPEGStream =
-Canvas.prototype.createSyncJPEGStream = function(options){
   options = options || {};
@@ -135,0 +93,0 @@ // Don't allow the buffer size to exceed the size of the canvas (#674)

lib/jpegstream.js

@@ -29,7 +29,6 @@ 'use strict';
  * @param {Canvas} canvas
- * @param {Boolean} sync
  * @api public
  */
 
-var JPEGStream = module.exports = function JPEGStream(canvas, options, sync) {
+var JPEGStream = module.exports = function JPEGStream(canvas, options) {
   if (!(this instanceof JPEGStream)) {
@@ -42,12 +41,4 @@ throw new TypeError("Class constructors cannot be invoked without 'new'");
   var self = this;
-  var method = sync
-      ? 'streamJPEGSync'
-      : 'streamJPEG';
   this.options = options;
-  this.sync = sync;
   this.canvas = canvas;
-
-  // TODO: implement async
-  if ('streamJPEG' == method) method = 'streamJPEGSync';
-  this.method = method;
 };
@@ -68,3 +59,3 @@
   var progressive = this.options.progressive;
-  self.canvas[method](bufsize, quality, progressive, function(err, chunk){
+  self.canvas.streamJPEGSync(bufsize, quality, progressive, function(err, chunk){
     if (err) {
@@ -71,0 +62,0 @@ self.emit('error', err);

lib/pdfstream.js

@@ -27,7 +27,6 @@ 'use strict';
  * @param {Canvas} canvas
- * @param {Boolean} sync
  * @api public
  */
 
-var PDFStream = module.exports = function PDFStream(canvas, sync) {
+var PDFStream = module.exports = function PDFStream(canvas) {
   if (!(this instanceof PDFStream)) {
@@ -39,12 +38,3 @@ throw new TypeError("Class constructors cannot be invoked without 'new'");
 
-  var self = this
-    , method = sync
-      ? 'streamPDFSync'
-      : 'streamPDF';
-  this.sync = sync;
   this.canvas = canvas;
-
-  // TODO: implement async
-  if ('streamPDF' == method) method = 'streamPDFSync';
-  this.method = method;
 };
@@ -61,3 +51,3 @@
   var self = this;
-  self.canvas[self.method](function(err, chunk, len){
+  self.canvas.streamPDFSync(function(err, chunk, len){
     if (err) {
@@ -64,0 +54,0 @@ self.emit('error', err);

lib/pngstream.js

@@ -29,3 +29,2 @@ 'use strict';
  * @param {Canvas} canvas
- * @param {Boolean} sync
  * @param {Object} options
@@ -39,3 +38,3 @@ * @param {Uint8ClampedArray} options.palette Provide for indexed PNG encoding.
 
-var PNGStream = module.exports = function PNGStream(canvas, sync, options) {
+var PNGStream = module.exports = function PNGStream(canvas, options) {
   if (!(this instanceof PNGStream)) {
@@ -48,12 +47,4 @@ throw new TypeError("Class constructors cannot be invoked without 'new'");
   var self = this;
-  var method = sync
-      ? 'streamPNGSync'
-      : 'streamPNG';
-  this.sync = sync;
   this.canvas = canvas;
   this.options = options || {};
-
-  // TODO: implement async
-  if ('streamPNG' === method) method = 'streamPNGSync';
-  this.method = method;
 };
@@ -70,3 +61,3 @@
   var self = this;
-  self.canvas[self.method](function(err, chunk, len){
+  self.canvas.streamPNGSync(function(err, chunk, len){
     if (err) {
@@ -73,0 +64,0 @@ self.emit('error', err);

package.json

 {
   "name": "canvas",
   "description": "Canvas graphics API backed by Cairo",
-  "version": "2.0.0-alpha.4",
+  "version": "2.0.0-alpha.5",
   "author": "TJ Holowaychuk <[e-mail]>",
@@ -6,0 +6,0 @@ "browser": "browser.js",

Readme.md

@@ -141,4 +141,2 @@ # node-canvas
 
-Currently _only_ sync streaming is supported, however we plan on supporting async streaming as well (of course :) ). Until then the `Canvas#toBuffer(callback)` alternative is async utilizing `eio_custom()`.
-
 To encode indexed PNGs from canvases with `pixelFormat: 'A8'` or `'A1'`, provide an options object:
@@ -145,0 +143,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

267060

decreased by-0.69%

Lines of code

932

decreased by-6.14%

Number of lines in readme file

473

decreased by-0.42%

No dependency changes