catbox-redis - npm Package Compare versions

Comparing version 1.0.9 to 1.1.0

lib/index.js

@@ -199,3 +199,12 @@
 
-    return encodeURIComponent(this.settings.partition) + ':' + encodeURIComponent(key.segment) + ':' + encodeURIComponent(key.id);
+    const parts = [];
+
+    if (this.settings.partition) {
+        parts.push(encodeURIComponent(this.settings.partition));
+    }
+
+    parts.push(encodeURIComponent(key.segment));
+    parts.push(encodeURIComponent(key.id));
+
+    return parts.join(':');
 };

package.json

 {
   "name": "catbox-redis",
   "description": "Redis adapter for catbox",
-  "version": "1.0.9",
+  "version": "1.1.0",
   "author": "Eran Hammer <[e-mail]> (http://hueniverse.com)",
@@ -6,0 +6,0 @@ "contributors": [

test/index.js

@@ -916,2 +916,37 @@
 
+    describe('generateKey()', () => {
+
+        it('generates the storage key from a given catbox key', (done) => {
+
+            const options = {
+                partition: 'foo'
+            };
+
+            const redis = new Redis(options);
+
+            const key = {
+                id: 'bar',
+                segment: 'baz'
+            };
+
+            expect(redis.generateKey(key)).to.equal('foo:baz:bar');
+            done();
+        });
+
+        it('generates the storage key from a given catbox key without partition', (done) => {
+
+            const options = {};
+
+            const redis = new Redis(options);
+
+            const key = {
+                id: 'bar',
+                segment: 'baz'
+            };
+
+            expect(redis.generateKey(key)).to.equal('baz:bar');
+            done();
+        });
+    });
+
     describe('stop()', () => {
@@ -918,0 +953,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

34880

increased by2.78%

Lines of code

895

increased by3.47%

No dependency changes