coffeelint-alphabetize-keys - npm Package Compare versions

Comparing version 1.4.0 to 1.4.1

CHANGELOG.md

@@ -0,1 +1,7 @@
+### 1.4.1 (2015-09-28)
+
+* fix error message
+* report all errors instead of one per object/class
+
+---
 ### 1.4.0 (2015-09-28)
@@ -2,0 +8,0 @@

lib/index.js

@@ -133,16 +133,16 @@ // Generated by CoffeeScript 1.10.0
     AlphabetizeKeys.prototype._lintNodeKeys = function(node, astApi, keys, prefix) {
-      var i, index, key, len;
+      var i, index, key, len, results;
       keys = keys.map(this._stripQuotes);
+      results = [];
       for (index = i = 0, len = keys.length; i < len; index = ++i) {
         key = keys[index];
-        if (!(index !== 0 && keys[index - 1] > key)) {
-          continue;
+        if (index !== 0 && keys[index - 1] > key) {
+          results.push(this.errors.push(astApi.createError({
+            lineNumber: node.locationData.first_line + 1,
+            message: prefix + " keys should be alphabetized: " + keys[index - 1] + " appears before " + key,
+            rule: 'alphabetize_keys'
+          })));
         }
-        this.errors.push(astApi.createError({
-          lineNumber: node.locationData.first_line + 1,
-          message: prefix + " keys should be alphabetized: " + keys[index - 1] + " appears after " + key,
-          rule: 'alphabetize_keys'
-        }));
-        return;
       }
+      return results;
     };
@@ -175,3 +175,3 @@
       } else if (doubleQuoteMatch = key.match(/^"(.*)"$/)) {
-        return doubleQuoteMatch[2];
+        return doubleQuoteMatch[1];
       } else {
@@ -178,0 +178,0 @@ return key;

package.json

 {
   "name": "coffeelint-alphabetize-keys",
-  "version": "1.4.0",
+  "version": "1.4.1",
   "description": "Coffeelint rule that verifies object keys are in alphabetical order",
@@ -5,0 +5,0 @@ "main": "./lib/index.js",

No alert changes

Improved metrics

Total package byte prevSize

8931

1.57%

No dependency changes