combokeys-context - npm Package Compare versions

Comparing version 1.0.0 to 1.0.1

package.json

 {
   "name": "combokeys-context",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "author": "Tim Oram <[e-mail]>",
@@ -5,0 +5,0 @@ "contributors": [],

README.md

 # ComboKeys Context
 
 [![Dependency Status](https://david-dm.org/MitMaro/combokeys-context.svg)](https://david-dm.org/MitMaro/combokeys-context)
-[![Build Status](https://travis-ci.org/MitMaro/combokeys-context.svg)](https://travis-ci.org/MitMaro/combokeys-context)
+[![Build Status](https://travis-ci.org/MitMaro/combokeys-context.svg?branch=master)](https://travis-ci.org/MitMaro/combokeys-context)
 [![Coverage Status](https://coveralls.io/repos/MitMaro/combokeys-context/badge.svg?branch=master)](https://coveralls.io/r/MitMaro/combokeys-context?branch=master)
@@ -15,2 +15,6 @@
 
+## Install
+
+    npm install combokeys-context
+
 ## Documentation
@@ -20,3 +24,3 @@
 
-```
+```javascript
 var ComboKeys = require('combokeys');
@@ -68,4 +72,4 @@ var ComboKeysContext = require('combokeys-context');
 
-##License
+## License
 
 Combokeys Context is released under the MIT license. See LICENSE.

src/Combokeys-Context.js

 var isArray = require('./util/isArray');
 
 function wrapHandler(key, evt, combo) {
-	if (this._context) {
+	if (this._context && this._bindings[key].contexts[this._context]) {
 		this._bindings[key].contexts[this._context].call(this._comboKeys, evt, combo);
-	} else {
+	} else if (this._bindings[key].global) {
 		this._bindings[key].global.call(this._comboKeys, evt, combo);
@@ -8,0 +8,0 @@ }

test/Combokeys-Context-test.js

@@ -436,3 +436,24 @@
 		});
+
+		it('calls function in global scope without global scope registered', function() {
+			var contextCallback = sinon.stub();
+			var evt = 'my event';
+			var key = 'a';
+
+			context._register(key, 'A', contextCallback);
+			context._bindings[key].handler(evt, key);
+			expect(contextCallback).to.not.be.called;
+		});
+
+		it('calls function in scope without scope registered', function() {
+			var globalCallback = sinon.stub();
+			var evt = 'my event';
+			var key = 'a';
+
+			context._register(key, null, globalCallback);
+			context._context = 'A';
+			context._bindings[key].handler(evt, key);
+			expect(globalCallback).to.be.calledWith(evt, key);
+		});
 	});
 });

No alert changes

Improved metrics

Total package byte prevSize

69565

increased by41.61%

Number of package files

34

increased by21.43%

Lines of code

651

increased by2.68%

Number of lines in readme file

73

increased by5.8%

No dependency changes