common-errors - npm Package Compare versions

Comparing version 0.4.11 to 0.4.12

lib/helpers/class-generator.js

 var util = require('util');
+var _ = require('lodash');
 var globalize = require('../internal/globalize');
@@ -17,2 +18,4 @@
     Class.super_.call(this);
+    if(this.global_initialize) this.global_initialize(Class);
+
     this.args = arguments;
@@ -32,4 +35,3 @@ for(var i = 0; i<options.args.length; i++){
 
-  if(options.globalize) globalize(Class, options.extends);
-  else util.inherits(Class, options.extends);
+  util.inherits(Class, options.extends);
 
@@ -43,2 +45,3 @@ Class.prototype.generateMessage = options.generateMessage;
 
+  if(options.globalize) globalize(Class);
   return Class;
@@ -45,0 +48,0 @@ }

lib/internal/globalize.js

 var util = require('util');
+var _ = require('lodash');
 var key = "__COMMON-ERRORS-TYPES__";
 var global_errors = global[key] = global[key] || {};
 
-module.exports = function global_extend(Class, subclass) {
-  var global_class = global_errors[Class.name];
-  var global_exists = global_class && global_class.super_.name == subclass.name;
-  if(global_exists) Class.prototype = global_class.prototype;
-  else util.inherits(Class, subclass);
-  Class.super_ = subclass;
-  Class.prototype.__global_type__ = global_errors[Class.name] = global_class || Class;
+module.exports = function global_extend(Class) {
+  Class.__original_prototype__ = Class.prototype;
+  var global_class = global_errors[Class.name] = global_errors[Class.name] || Class;
+  Class.prototype = Class.__global_prototype__ = global_class.prototype;
+  Class.prototype.global_initialize = Class.prototype.global_initialize || function global_initialize(Class){
+  	_.extend(this, Class.__original_prototype__);
+  };
 }

package.json

@@ -5,3 +5,3 @@ {
   "description": "Common error classes and utility functions",
-  "version": "0.4.11",
+  "version": "0.4.12",
   "repository": {
@@ -23,3 +23,3 @@ "type": "git",
     "lodash": "= 2.4.1",
-    "common-errors": "git://github.com/shutterstock/node-common-errors.git#global_extend.v0"
+    "common-errors": "git://github.com/shutterstock/node-common-errors.git#global_extend.v1"
   },
@@ -32,3 +32,3 @@ "keywords": [
     "validation",
-    "generic",
+    "standard",
     "argument",
@@ -35,0 +35,0 @@ "null",

No alert changes

Improved metrics

Total package byte prevSize

59540

9.85%

Number of package files

55

12.24%

Lines of code

766

7.13%

No dependency changes