concat-stream - npm Package Compare versions

Comparing version 1.4.1 to 1.4.2

index.js

@@ -74,2 +74,3 @@ var Writable = require('readable-stream').Writable
   var strings = []
+  var needsToString = false
   for (var i = 0; i < parts.length; i++) {
@@ -80,8 +81,14 @@ var p = parts[i]
     } else if (Buffer.isBuffer(p)) {
-      strings.push(p.toString('utf8'))
+      strings.push(p)
     } else {
-      strings.push(Buffer(p).toString('utf8'))
+      strings.push(Buffer(p))
     }
   }
-  return strings.join('')
+  if (Buffer.isBuffer(parts[0])) {
+    strings = Buffer.concat(strings)
+    strings = strings.toString('utf8')
+  } else {
+    strings = strings.join('')
+  }
+  return strings
 }
@@ -88,0 +95,0 @@

package.json

@@ -10,3 +10,3 @@ {
   ],
-  "version": "1.4.1",
+  "version": "1.4.2",
   "author": "Max Ogden <[e-mail]>",
@@ -13,0 +13,0 @@ "repository": {

test/string.js

@@ -51,1 +51,15 @@ var concat = require('../')
 })
+
+test('string from buffers with multibyte characters', function (t) {
+  t.plan(2)
+  var strings = concat({ encoding: 'string' }, function(out) {
+    t.equal(typeof out, 'string')
+    t.equal(out, '☃☃☃☃☃☃☃☃')
+  })
+  var snowman = new Buffer('☃')
+  for (var i = 0; i < 8; i++) {
+    strings.write(snowman.slice(0, 1))
+    strings.write(snowman.slice(1))    
+  }
+  strings.end()
+})

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

13548

increased by4.14%

Lines of code

305

increased by7.02%

No dependency changes