cordova-plugin-firebasex - npm Package Compare versions

Comparing version 18.0.1 to 18.0.2

CHANGELOG.md

@@ -0,1 +1,7 @@
+# Version 18.0.2
+* bugfix: only apply new logic for cordova-ios@8 if platform is ios
+  - Resolves [#907](https://github.com/dpa99c/cordova-plugin-firebasex/issues/907)
+  - Introduced by [#896](https://github.com/dpa99c/cordova-plugin-firebasex/pull/896)
+
+
 # Version 18.0.1
@@ -2,0 +8,0 @@ * feat(ios): prepare for cordova-ios 8 support - corrected app name

package.json

 {
   "name": "cordova-plugin-firebasex",
-  "version": "18.0.1",
+  "version": "18.0.2",
   "description": "Cordova plugin for Google Firebase",
@@ -5,0 +5,0 @@ "types": "./types/index.d.ts",

scripts/lib/utilities.js

@@ -7,2 +7,3 @@ /**
 var parser = require('xml-js');
+const cordova_ios = require("cordova-ios");
 
@@ -69,8 +70,12 @@ var _configXml, _pluginXml, _context, _pluginVariables;
 Utilities.getAppName = function(){
-    const projectRoot = _context.opts.projectRoot;
-    const platformPath = path.join(projectRoot, 'platforms', 'ios');
-    const cordova_ios = require('cordova-ios');
-    const iosProject = new cordova_ios('ios', platformPath);
+    if(_context.opts.platforms.indexOf('ios') !== -1){
+        const projectRoot = _context.opts.projectRoot;
+        const platformPath = path.join(projectRoot, 'platforms', 'ios');
+        const cordova_ios = require('cordova-ios');
+        const iosProject = new cordova_ios('ios', platformPath);
 
-    return path.basename(iosProject.locations.xcodeCordovaProj);
+        return path.basename(iosProject.locations.xcodeCordovaProj);
+    }
+    // other platforms
+    return Utilities.parseConfigXml().widget.name._text.toString().trim();
 };
@@ -77,0 +82,0 @@

No alert changes

Improved metrics

Total package byte prevSize

834281

0.06%

Lines of code

6488

0.08%

No dependency changes