cordova-plugin-inappbrowser - npm Package Compare versions

Comparing version 1.3.0 to 1.4.0

package.json

 {
   "name": "cordova-plugin-inappbrowser",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "Cordova InAppBrowser Plugin",
@@ -40,2 +40,6 @@ "cordova": {
   ],
+  "scripts": {
+    "test": "npm run jshint",
+    "jshint": "node node_modules/jshint/bin/jshint www && node node_modules/jshint/bin/jshint src && node node_modules/jshint/bin/jshint tests"
+  },
   "engines": [
@@ -48,3 +52,6 @@ {
   "author": "Apache Software Foundation",
-  "license": "Apache-2.0"
+  "license": "Apache-2.0",
+  "devDependencies": {
+    "jshint": "^2.6.0"
+  }
 }

README.md

@@ -20,2 +20,4 @@ <!--
 
+[![Build Status](https://travis-ci.org/apache/cordova-plugin-inappbrowser.svg?branch=master)](https://travis-ci.org/apache/cordova-plugin-inappbrowser)
+
 # cordova-plugin-inappbrowser
@@ -58,3 +60,3 @@
 
-:warning: Report issues on the [Apache Cordova issue tracker](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20InAppBrowser%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC)
+Report issues with this plugin on the [Apache Cordova issue tracker](https://issues.apache.org/jira/issues/?jql=project%20%3D%20CB%20AND%20status%20in%20%28Open%2C%20%22In%20Progress%22%2C%20Reopened%29%20AND%20resolution%20%3D%20Unresolved%20AND%20component%20%3D%20%22Plugin%20InAppBrowser%22%20ORDER%20BY%20priority%20DESC%2C%20summary%20ASC%2C%20updatedDate%20DESC)
 
@@ -203,3 +205,3 @@
 
-## addEventListener
+## InAppBrowser.addEventListener
 
@@ -250,3 +252,3 @@ > Adds a listener for an event from the `InAppBrowser`.
 
-## removeEventListener
+## InAppBrowser.removeEventListener
 
@@ -285,3 +287,3 @@ > Removes a listener for an event from the `InAppBrowser`.
 
-## close
+## InAppBrowser.close
 
@@ -309,3 +311,3 @@ > Closes the `InAppBrowser` window.
 
-## show
+## InAppBrowser.show
 
@@ -332,3 +334,3 @@ > Displays an InAppBrowser window that was opened hidden. Calling this has no effect if the InAppBrowser was already visible.
 
-## executeScript
+## InAppBrowser.executeScript
 
@@ -375,3 +377,3 @@ > Injects JavaScript code into the `InAppBrowser` window
 
-## insertCSS
+## InAppBrowser.insertCSS
 
@@ -378,0 +380,0 @@ > Injects CSS into the `InAppBrowser` window.

RELEASENOTES.md

@@ -23,2 +23,9 @@ <!--
 
+### 1.4.0 (Apr 15, 2016)
+* CB-7679 add fix for **iOS** upload.
+* CB-10944 `NoSuchMethodError` in `InAppBrowser` plugin
+* CB-10937 fix stretched icons
+* CB-10760 Fixing README for display on Cordova website
+* CB-10636 Add `JSHint` for plugins
+
 ### 1.3.0 (Feb 09, 2016)
@@ -25,0 +32,0 @@ * [CB-3360](https://issues.apache.org/jira/browse/CB-3360) Set custom inappbrowser user agent for android

src/browser/InAppBrowserProxy.js

@@ -22,6 +22,3 @@ /*
 
-var cordova = require('cordova'),
-    channel = require('cordova/channel'),
-    modulemapper = require('cordova/modulemapper'),
-    urlutil = require('cordova/urlutil');
+var modulemapper = require('cordova/modulemapper');
 
@@ -73,4 +70,3 @@ var browserWrap,
             target = args[1],
-            features = args[2],
-            url;
+            features = args[2];
 
@@ -198,3 +194,5 @@ if (target === "_self" || !target) {
                 popup.contentWindow.eval(code);
-                hasCallback && win([]);
+                if (hasCallback) {
+                    win([]);
+                }
             } catch(e) {
@@ -209,3 +207,5 @@ console.error('Error occured while trying to injectScriptCode: ' + JSON.stringify(e));
         console.warn(msg);
-        fail && fail(msg);
+        if (fail) {
+            fail(msg);
+        }
     }, 
@@ -216,3 +216,5 @@
         console.warn(msg);
-        fail && fail(msg);
+        if (fail) {
+            fail(msg);
+        }
     },
@@ -223,3 +225,5 @@
         console.warn(msg);
-        fail && fail(msg);
+        if (fail) {
+            fail(msg);
+        }
     }
@@ -226,0 +230,0 @@ };

src/firefoxos/InAppBrowserProxy.js

@@ -24,5 +24,3 @@ /*
 
-var cordova = require('cordova'),
-    channel = require('cordova/channel'),
-    modulemapper = require('cordova/modulemapper');
+var modulemapper = require('cordova/modulemapper');
 
@@ -53,5 +51,3 @@ var origOpenFunc = modulemapper.getOriginalSymbol(window, 'window.open');
             features_string = args[2] || "location=yes", //location=yes is default
-            features = {},
-            url,
-            elem;
+            features = {};
 
@@ -66,3 +62,3 @@ var features_list = features_string.split(',');
             } else {
-                var number = parseInt(tup[1]);    
+                var number = parseInt(tup[1]);
                 if (!isNaN(number)) {
@@ -121,3 +117,3 @@ tup[1] = number;
 
-            function checkForwardBackward() {
+            var checkForwardBackward = function () {
                 var backReq = browserElem.getCanGoBack();
@@ -130,3 +126,3 @@ backReq.onsuccess = function() {
                     }
-                }
+                };
                 var forwardReq = browserElem.getCanGoForward();
@@ -139,3 +135,3 @@ forwardReq.onsuccess = function() {
                     }
-                }
+                };
             };
@@ -172,12 +168,12 @@
                     url : e.detail
-                })
+                });
             }, false);
             browserElem.addEventListener('mozbrowserloadend', function(e){
-                win({type:'loadstop'})
+                win({type:'loadstop'});
             }, false);
             browserElem.addEventListener('mozbrowsererror', function(e){
-                win({type:'loaderror'})
+                win({type:'loaderror'});
             }, false);
             browserElem.addEventListener('mozbrowserclose', function(e){
-                win({type:'exit'})
+                win({type:'exit'});
             }, false);
@@ -184,0 +180,0 @@ } else {

src/ubuntu/InAppBrowser_escapeScript.js

@@ -22,2 +22,5 @@ /*
 
+/* jshint -W061 */
+/* global oxide */
+
 oxide.addMessageHandler("EXECUTE", function(msg) {
@@ -24,0 +27,0 @@ var code = msg.args.code;

src/windows/InAppBrowserProxy.js

@@ -22,7 +22,5 @@ /*
 
-/*jslint sloppy:true */
-/*global Windows:true, require, document, setTimeout, window, module */
+/* jslint sloppy:true */
+/* global Windows:true, setImmediate */
 
-
-
 var cordova = require('cordova'),
@@ -192,3 +190,3 @@ urlutil = require('cordova/urlutil');
                     navigationButtonsDivInner = document.createElement("div");
-                    navigationButtonsDivInner.className = "inappbrowser-app-bar-inner"
+                    navigationButtonsDivInner.className = "inappbrowser-app-bar-inner";
                     navigationButtonsDivInner.onclick = function (e) {
@@ -258,5 +256,7 @@ e.cancelBubble = true;
                 op.oncomplete = function (e) {
-                    // return null if event target is unavailable by some reason
-                    var result = (e && e.target) ? [e.target.result] : [null];
-                    hasCallback && win(result);
+                    if (hasCallback) {
+                        // return null if event target is unavailable by some reason
+                        var result = (e && e.target) ? [e.target.result] : [null];
+                        win(result);
+                    }
                 };
@@ -284,4 +284,6 @@ op.onerror = function () { };
                         op.oncomplete = function(e) {
-                            var result = [e.target.result];
-                            hasCallback && win(result);
+                            if (hasCallback) {
+                                var result = [e.target.result];
+                                win(result);
+                            }
                         };
@@ -336,3 +338,5 @@ op.onerror = function () { };
     op.oncomplete = function() {
-        callback && callback([]);
+        if (callback) {
+            callback([]);
+        }
     };
@@ -339,0 +343,0 @@ op.onerror = function () { };

tests/resources/inject.js

@@ -19,3 +19,3 @@ /*
 */
-var d = document.getElementById("header")
+var d = document.getElementById("header");
 d.innerHTML = "Script file successfully injected";

tests/tests.js

@@ -22,2 +22,5 @@ /*
 
+/* jshint jasmine: true */
+/* global MSApp */
+
 var cordova = require('cordova');
@@ -187,9 +190,9 @@ var isWindows = cordova.platformId == 'windows';
                 }
-                if (numExpectedRedirects === 0 && counts['loadstart'] !== 1) {
+                if (numExpectedRedirects === 0 && counts.loadstart !== 1) {
                     // Do allow a loaderror without a loadstart (e.g. in the case of an invalid URL).
-                    if (!(e.type == 'loaderror' && counts['loadstart'] === 0)) {
-                        alert('Unexpected: got multiple loadstart events. (' + counts['loadstart'] + ')');
+                    if (!(e.type == 'loaderror' && counts.loadstart === 0)) {
+                        alert('Unexpected: got multiple loadstart events. (' + counts.loadstart + ')');
                     }
-                } else if (numExpectedRedirects > 0 && counts['loadstart'] < (numExpectedRedirects + 1)) {
-                    alert('Unexpected: should have got at least ' + (numExpectedRedirects + 1) + ' loadstart events, but got ' + counts['loadstart']);
+                } else if (numExpectedRedirects > 0 && counts.loadstart < (numExpectedRedirects + 1)) {
+                    alert('Unexpected: should have got at least ' + (numExpectedRedirects + 1) + ' loadstart events, but got ' + counts.loadstart);
                 }
@@ -202,3 +205,3 @@ wasReset = true;
             if (e.type == 'exit') {
-                var numStopEvents = counts['loadstop'] + counts['loaderror'];
+                var numStopEvents = counts.loadstop + counts.loaderror;
                 if (numStopEvents === 0 && !wasReset) {
@@ -205,0 +208,0 @@ alert('Unexpected: browser closed without a loadstop or loaderror.');

www/windows8/InAppBrowserProxy.js

@@ -25,6 +25,2 @@ /*
 
-
-var cordova = require('cordova'),
-    channel = require('cordova/channel');
-
 var browserWrap;
@@ -49,3 +45,2 @@
             target = args[1],
-            features = args[2],
             url,
@@ -52,0 +47,0 @@ elem;

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

611802

increased by0.2%

Number of package files

75

increased by2.74%

Lines of code

1596

increased by0.44%

Number of lines in readme file

397

increased by0.51%

Worsened metrics

Dev dependency count

1

increased byInfinity%

No dependency changes