cowsay - npm Package Compare versions

Comparing version 1.1.1 to 1.1.2

lib/replacer.js

 module.exports = function (cow, variables) {
+	var eyes = escapeRe(variables.eyes);
+	var tongue = escapeRe(variables.tongue);
+
 	if (cow.indexOf("$the_cow") !== -1) {
@@ -8,7 +11,23 @@ cow = extractTheCow(cow);
 		.replace(/\$thoughts/g, variables.thoughts)
-		.replace(/\$eyes/g, variables.eyes)
-		.replace(/\$tongue/g, variables.tongue)
-		.replace(/\$\{eyes\}/g, variables.eyes)
-		.replace(/\$\{tongue\}/g, variables.tongue)
+		.replace(/\$eyes/g, eyes)
+		.replace(/\$tongue/g, tongue)
+		.replace(/\$\{eyes\}/g, eyes)
+		.replace(/\$\{tongue\}/g, tongue)
 	;
+};
+
+/*
+ * "$" dollar signs must be doubled before being used in a regex replace
+ * This can occur in eyes or tongue.
+ * For example:
+ *
+ * cowsay -g Moo!
+ *
+ * cowsay -e "\$\$" Moo!
+ */
+function escapeRe (s) {
+	if (s && s.replace) {
+		return s.replace(/\$/g, "$$$$");
+	}
+	return s;
 }
@@ -15,0 +34,0 @@

package.json

 {
   "name": "cowsay",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "description": "cowsay is a configurable talking cow",
@@ -32,9 +32,8 @@ "keywords": [
   "dependencies": {
-    "get-stdin": "^4.0.1",
-    "optimist": "~0.3.5"
+    "optimist": "~0.6.1"
   },
   "devDependencies": {
-    "nodeunit": "~0.7.4"
+    "nodeunit": "~0.9.1"
   },
   "preferGlobal": true
 }

No alert changes

Improved metrics

Total package byte prevSize

34996

2.68%

Dependency count

1

-50%

Number of package files

62

1.64%

Lines of code

408

4.35%

Dependency changes

• + Added

  minimist@0.0.10
  (transitive)

• + Added

  optimist@0.6.1
  (transitive)

• - Removed

  get-stdin@^4.0.1

• - Removed

  get-stdin@4.0.1
  (transitive)

• - Removed

  optimist@0.3.7
  (transitive)

• Updated

  optimist@~0.6.1