create-nx-workspace - npm Package Compare versions

Comparing version 0.0.0-pr-32061-3e47d92 to 0.0.0-pr-32117-a841f88

bin/create-nx-workspace.js

@@ -19,3 +19,2 @@ "use strict";
 const is_ci_1 = require("../src/utils/ci/is-ci");
-const social_information_1 = require("../src/utils/social-information");
 exports.commandsObject = yargs
@@ -157,10 +156,9 @@ .wrap(yargs.terminalWidth())
     }
-    if ((0, preset_1.isKnownPreset)(parsedArgs.preset)) {
-        (0, social_information_1.printSocialInformation)();
-    }
-    else {
-        output_1.output.log({
-            title: `Successfully applied preset: ${parsedArgs.preset}`,
-        });
-    }
+    // if (isKnownPreset(parsedArgs.preset)) {
+    //   printSocialInformation();
+    // } else {
+    //   output.log({
+    //     title: `Successfully applied preset: ${parsedArgs.preset}`,
+    //   });
+    // }
 }
@@ -167,0 +165,0 @@ /**

package.json

 {
   "name": "create-nx-workspace",
-  "version": "0.0.0-pr-32061-3e47d92",
+  "version": "0.0.0-pr-32117-a841f88",
   "private": false,
@@ -5,0 +5,0 @@ "description": "Smart Repos · Fast Builds",

src/create-empty-workspace.js

@@ -26,2 +26,6 @@ "use strict";
     const directory = options.name;
+    // Cannot skip install for create-nx-workspace or else it'll fail.
+    // Even though --skipInstall is not an option to create-nx-workspace, we pass through extra options to presets.
+    // See: https://github.com/nrwl/nx/issues/31834
+    delete options.skipInstall;
     const args = (0, unparse_1.unparse)({
@@ -28,0 +32,0 @@ ...options,

src/utils/git/git.js

@@ -197,4 +197,4 @@ "use strict";
         const title = e instanceof GitHubPushSkippedError || e?.code === 127
-            ? 'Push your workspace to GitHub'
-            : 'Failed to push workspace to GitHub';
+            ? 'Push your workspace to GitHub.'
+            : 'Failed to push workspace to GitHub.';
         const createRepoUrl = `https://github.com/new?name=${encodeURIComponent(options.name)}`;
@@ -205,7 +205,7 @@ output_1.output.log({
                 ? [
-                    `Please create a repo at ${createRepoUrl} and push this workspace`,
+                    `Please create a repo at ${createRepoUrl} and push this workspace.`,
                     'Error details:',
                     errorMessage,
                 ]
-                : [`Please create a repo at ${createRepoUrl} and push this workspace`],
+                : [`Please create a repo at ${createRepoUrl} and push this workspace.`],
         });
@@ -212,0 +212,0 @@ return VcsPushStatus.FailedToPushToVcs;

src/utils/nx/messages.js

@@ -9,7 +9,7 @@ "use strict";
             ? `Go to Nx Cloud and finish the setup: ${url}`
-            : 'Return to Nx Cloud and finish the setup';
+            : 'Return to Nx Cloud and finish the setup.';
     }
     // Default case: FailedToPushToVcs
     const action = url ? 'go' : 'return';
-    const urlSuffix = url ? `: ${url}` : '';
+    const urlSuffix = url ? `: ${url}` : '.';
     return `Push your repo, then ${action} to Nx Cloud and finish the setup${urlSuffix}`;
@@ -37,6 +37,3 @@ }
                     type: 'success',
-                    bodyLines: [
-                        getSetupMessage(url, pushedToVcs),
-                        `You can also set up a remote cache later by running \`nx g @nx/nx-cloud:init\``,
-                    ],
+                    bodyLines: [getSetupMessage(url, pushedToVcs)],
                 };
@@ -43,0 +40,0 @@ },

src/utils/nx/nx-cloud.d.ts

 import { VcsPushStatus } from '../git/git';
 export type NxCloud = 'yes' | 'github' | 'gitlab' | 'azure' | 'bitbucket-pipelines' | 'circleci' | 'skip';
 export declare function readNxCloudToken(directory: string): string;
-export declare function createNxCloudOnboardingUrl(nxCloud: NxCloud, token: string, directory: string, useGitHub?: boolean): Promise<string>;
+export declare function createNxCloudOnboardingUrl(nxCloud: NxCloud, token: string, directory: string, useGitHub?: boolean): Promise<any>;
 export declare function getNxCloudInfo(nxCloud: NxCloud, connectCloudUrl: string, pushedToVcs: VcsPushStatus, rawNxCloud?: NxCloud): Promise<string>;
 //# sourceMappingURL=nx-cloud.d.ts.map

src/utils/nx/nx-cloud.js

@@ -32,4 +32,4 @@ "use strict";
     const { code } = (0, messages_1.getMessageFactory)(source);
-    return await createNxCloudOnboardingURL(source, token, useGitHub ??
-        (nxCloud === 'yes' || nxCloud === 'github' || nxCloud === 'circleci'), code);
+    return await createNxCloudOnboardingURL(source, token, code, false, useGitHub ??
+        (nxCloud === 'yes' || nxCloud === 'github' || nxCloud === 'circleci'));
 }
@@ -36,0 +36,0 @@ async function getNxCloudInfo(nxCloud, connectCloudUrl, pushedToVcs, rawNxCloud) {

No alert changes

Improved metrics

Total package byte prevSize

144051

0.01%

Worsened metrics

Lines of code

3429

-0.03%

No dependency changes