cross-env - npm Package Compare versions

Comparing version 1.0.5 to 1.0.6

dist/index.js

@@ -19,3 +19,3 @@ 'use strict';
 
-var envSetterRegex = /(\w+)=(\w+)/;
+var envSetterRegex = /(\w+)=('(.+)'|"(.+)"|(.+))/;
 
@@ -44,3 +44,3 @@ function crossEnv(args) {
     if (match) {
-      envVars[match[1]] = match[2];
+      envVars[match[1]] = match[3] || match[4] || match[5];
     } else {
@@ -47,0 +47,0 @@ command = shifted;

package.json

 {
   "name": "cross-env",
-  "version": "1.0.5",
+  "version": "1.0.6",
   "description": "Run commands that set environment variables across platforms",
@@ -5,0 +5,0 @@ "main": "src/index.js",

src/index.js

@@ -5,3 +5,3 @@ import {spawn} from 'cross-spawn-async';
 
-const envSetterRegex = /(\w+)=(\w+)/;
+const envSetterRegex = /(\w+)=('(.+)'|"(.+)"|(.+))/;
 
@@ -23,3 +23,3 @@ function crossEnv(args) {
     if (match) {
-      envVars[match[1]] = match[2];
+      envVars[match[1]] = match[3] || match[4] || match[5];
     } else {
@@ -26,0 +26,0 @@ command = shifted;

src/index.test.js

@@ -25,9 +25,38 @@ import chai from 'chai';
   it(`should set environment variables and run the remaining command`, () => {
-    testEnvSetting('FOO_ENV=production');
+    testEnvSetting({
+      FOO_ENV: 'production'
+    }, 'FOO_ENV=production');
   });
 
   it(`should handle multiple env variables`, () => {
-    testEnvSetting('FOO_ENV=production', 'bar_env=dev');
+    testEnvSetting({
+      FOO_ENV: 'production',
+      BAR_ENV: 'dev'
+    }, 'FOO_ENV=production', 'BAR_ENV=dev');
   });
 
+  it(`should handle special characters`, () => {
+    testEnvSetting({
+      FOO_ENV: './!?'
+    }, 'FOO_ENV=./!?');
+  });
+
+  it(`should handle single-quoted strings`, () => {
+    testEnvSetting({
+      FOO_ENV: 'bar env'
+    }, 'FOO_ENV=\'bar env\'');
+  });
+
+  it(`should handle double-quoted strings`, () => {
+    testEnvSetting({
+      FOO_ENV: 'bar env'
+    }, 'FOO_ENV="bar env"');
+  });
+
+  it(`should handle equality signs in quoted strings`, () => {
+    testEnvSetting({
+      FOO_ENV: 'foo=bar'
+    }, 'FOO_ENV="foo=bar"');
+  });
+
   it(`should do nothing given no command`, () => {
@@ -38,10 +67,7 @@ crossEnv([]);
 
-  function testEnvSetting(...envSettings) {
+  function testEnvSetting(expected, ...envSettings) {
     const ret = crossEnv([...envSettings, 'echo', 'hello world']);
     const env = {[getPathVar()]: process.env[getPathVar()]};
     env.APPDATA = process.env.APPDATA;
-    envSettings.forEach(setting => {
-      const [prop, val] = setting.split('=');
-      env[prop] = val;
-    });
+    assign(env, expected);
 
@@ -51,5 +77,8 @@ expect(ret, 'returns what spawn returns').to.equal('spawn-returned');
     expect(proxied['cross-spawn-async'].spawn).to.have.been.calledWith(
-      'echo', ['hello world'], {stdio: 'inherit', env: assign({}, process.env, env)}
+      'echo', ['hello world'], {
+        stdio: 'inherit',
+        env: assign({}, process.env, env)
+      }
     );
   }
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

12409

increased by5.61%

Lines of code

137

increased by22.32%

No dependency changes