csvgeocode - npm Package Compare versions

Comparing version 2.0.3 to 2.1.0

package.json

 {
   "name": "csvgeocode",
-  "version": "2.0.3",
+  "version": "2.1.0",
   "description": "Bulk geocode addresses in a CSV.",
@@ -5,0 +5,0 @@ "main": "index.js",

src/csvgeocode.js

@@ -232,3 +232,3 @@ var misc = require("./misc"),
     for (var key in escaped) {
-      escaped[key] = escaped[key].replace(/ /g,"+").replace(/[&]/g,"%26")
+      escaped[key] = encodeURIComponent(escaped[key]).replace(/(%20| )/g,"+").replace(/[&]/g,"%26");
     }
@@ -235,0 +235,0 @@

src/handlers.js

@@ -65,3 +65,31 @@ var csv = require("dsv")(",");
 
+  },
+  osm: function(body) {
+
+    var parsed;
+
+    if (!body.length) {
+      return "NO RESPONSE BODY RETURNED, CHECK YOUR API KEY";
+    }
+
+    try {
+      parsed = JSON.parse(body);
+    } catch(e) {
+      return "ERROR PARSING RESPONSE: "+body;
+    }
+
+    if (!Array.isArray(parsed)) {
+      return "UNEXPECTED RESPONSE: "+body;
+    }
+
+    if (!parsed.length) {
+      return "NO MATCH";
+    }
+
+    return {
+      lat: parsed[0].lat,
+      lng: parsed[0].lon
+    };
+
   }
 };

test/test.js

@@ -7,2 +7,3 @@ var assert = require("assert"),
   .defer(basicTest)
+  .defer(norwegianTest)
   .defer(requiredTest)
@@ -19,2 +20,3 @@ .defer(cacheTest)
 function basicTest(cb) {
+
   geocode("test/basic.csv",{
@@ -47,7 +49,24 @@ test: true,
     });
+
 }
 
+function norwegianTest(cb) {
+
+  geocode("test/norwegian.csv",{
+      test: true,
+      url: process.env.TEST_NORWEGIAN_URL
+    })
+    .on("row",function(err,row){
+      assert(row.lat && row.lng,"failed row with norwegian characters");
+    })
+    .on("complete",function(summary){
+      assert.deepEqual(summary.failures,0,"Expected 0 failures");
+      assert.deepEqual(summary.successes,3,"Expected 3 successes");
+      cb(null);
+    });
+
+}
+
 function requiredTest(cb) {
 
-
   assert.throws(
@@ -54,0 +73,0 @@ function(){

New alerts

Environment variable access

Supply chain risk

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

26456

4.98%

Number of package files

17

6.25%

Lines of code

479

8.13%

Worsened metrics

Number of low supply chain risk alerts

11

10%

No dependency changes