dubbo-node-consumer-client - npm Package Compare versions

Comparing version 1.1.3 to 1.1.4

index.js

 var Config   = require('./lib/config/index'),
-    Registry = require('./lib/registery/index');
+    Registry = require('./lib/registery/index'),
+    Log      = require('./lib/log/index');
 
 module.exports = {
-    init: function (options) {
+    init: function (options, logger) {
         Config.load(options);
+        //初始化呢日志记录器,由外部传入log4js对象
+        Log.init(logger);
         Registry.init();
@@ -8,0 +11,0 @@ },

lib/config/index.js

@@ -1,5 +0,4 @@
-var QS  = require('querystring'),
-    _   = require('underscore'),
-    IP  = require('../utils/IP'),
-    log = require('../log/index');
+var QS = require('querystring'),
+    _  = require('underscore'),
+    IP = require('../utils/IP');
 
@@ -22,4 +21,2 @@ function Config() {
             };
-        //初始化日志
-        log.init(options.log || {});
     },
@@ -26,0 +23,0 @@ //获取默认权重

lib/log/index.js

@@ -1,5 +0,1 @@
-var log4js = require('log4js'),
-    mkdirp = require('mkdirp'),
-    _      = require('underscore');
-
 function logInfo() {
@@ -11,28 +7,6 @@ this.log = console;
 logInfo.prototype = {
-    init: function (options) {
-        if (!options.logDirectory) {
-            this.log.error('Dubbo-node-client init logDirectory is empty.');
-            return;
+    init: function (logger) {
+        if (logger) {
+            this.log = logger;
         }
-
-        try {
-            mkdirp.sync(options.logDirectory);
-        } catch (e) {
-            if (e.code != 'EEXIST') {
-                this.log.log("Dubbo-node-client could not set up log directory, error was: " + e.message);
-                return;
-            }
-        }
-
-        this.config = options.config || {
-                appenders: [
-                    {
-                        type: 'console',
-                        level: 'ALL'
-                    }
-                ]
-            };
-
-        log4js.configure(this.config);
-        this.log = log4js.getLogger('dubbo');
     },
@@ -39,0 +13,0 @@ _getLoger: function () {

package.json

 {
     "name": "dubbo-node-consumer-client",
-    "version": "1.1.3",
+    "version": "1.1.4",
     "description": "",
@@ -20,3 +20,2 @@ "main": "index.js",
     "dependencies": {
-        "log4js": "^0.6.38",
         "mkdirp": "^0.5.1",
@@ -23,0 +22,0 @@ "node-zookeeper-client": "^0.2.2",

No alert changes

Improved metrics

Dependency count

4

-20%

Worsened metrics

Total package byte prevSize

72372

-4.16%

Lines of code

615

-3.45%

Dependency changes

• - Removed

  log4js@^0.6.38

• - Removed

  core-util-is@1.0.3
  (transitive)

• - Removed

  inherits@2.0.4
  (transitive)

• - Removed

  isarray@0.0.1
  (transitive)

• - Removed

  log4js@0.6.38
  (transitive)

• - Removed

  readable-stream@1.0.34
  (transitive)

• - Removed

  semver@4.3.6
  (transitive)

• - Removed

  string_decoder@0.10.31
  (transitive)