embeds - npm Package Compare versions

Comparing version 2.11.0 to 2.11.3

dist/parse-input.js

@@ -15,7 +15,6 @@ 'use strict';
   for (var i = 0; i < allowed.length; ++i) {
-    var _allowed$i = _slicedToArray(allowed[i], 2);
+    var _allowed$i = _slicedToArray(allowed[i], 2),
+        regex = _allowed$i[0],
+        fn = _allowed$i[1];
 
-    var regex = _allowed$i[0];
-    var fn = _allowed$i[1];
-
     var match = url.match(regex);
@@ -22,0 +21,0 @@ if (!match) {

dist/render-iframe.js

@@ -14,6 +14,6 @@ 'use strict';
 exports.default = function (_ref) {
-  var src = _ref.src;
-  var width = _ref.width;
-  var height = _ref.height;
-  var allowFullscreen = _ref.allowFullscreen;
+  var src = _ref.src,
+      width = _ref.width,
+      height = _ref.height,
+      allowFullscreen = _ref.allowFullscreen;
   return (0, _virtualElement2.default)('iframe', {
@@ -20,0 +20,0 @@ src: src,

dist/render-text.js

@@ -15,4 +15,4 @@ 'use strict';
   return (text || []).map(function (_ref) {
-    var content = _ref.content;
-    var href = _ref.href;
+    var content = _ref.content,
+        href = _ref.href;
     return href ? (0, _virtualElement2.default)(
@@ -19,0 +19,0 @@ 'a',

dist/types/custom.js

@@ -25,6 +25,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (elm.tagName.toLowerCase() !== 'iframe') {
@@ -36,7 +35,6 @@ return null;
 
-  var _getDimensions = (0, _dimensions2.default)(elm);
+  var _getDimensions = (0, _dimensions2.default)(elm),
+      width = _getDimensions.width,
+      height = _getDimensions.height;
 
-  var width = _getDimensions.width;
-  var height = _getDimensions.height;
-
   if (!src || !width || !height) {
@@ -43,0 +41,0 @@ return null;

dist/types/facebook.js

@@ -86,7 +86,7 @@ 'use strict';
 var renderVideo = function renderVideo(_ref) {
-  var url = _ref.url;
-  var user = _ref.user;
-  var text = _ref.text;
-  var headline = _ref.headline;
-  var date = _ref.date;
+  var url = _ref.url,
+      user = _ref.user,
+      text = _ref.text,
+      headline = _ref.headline,
+      date = _ref.date;
   return (0, _virtualElement2.default)(
@@ -125,6 +125,6 @@ 'div',
 var renderPost = function renderPost(_ref2) {
-  var url = _ref2.url;
-  var user = _ref2.user;
-  var date = _ref2.date;
-  var text = _ref2.text;
+  var url = _ref2.url,
+      user = _ref2.user,
+      date = _ref2.date,
+      text = _ref2.text;
   return (0, _virtualElement2.default)(
@@ -131,0 +131,0 @@ 'div',

dist/types/image.js

@@ -21,15 +21,12 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   var tagName = elm.tagName.toLowerCase();
 
   if (tagName === 'img') {
-    var _getDimensions = (0, _dimensions2.default)(elm);
+    var _getDimensions = (0, _dimensions2.default)(elm),
+        width = _getDimensions.width,
+        height = _getDimensions.height;
 
-    var width = _getDimensions.width;
-    var height = _getDimensions.height;
-
-
     return {
@@ -47,8 +44,8 @@ type: 'image',
 var render = exports.render = function render(_ref3) {
-  var type = _ref3.type;
-  var src = _ref3.src;
-  var alt = _ref3.alt;
-  var width = _ref3.width;
-  var height = _ref3.height;
+  var type = _ref3.type,
+      src = _ref3.src,
+      alt = _ref3.alt,
+      width = _ref3.width,
+      height = _ref3.height;
   return (0, _virtualElement2.default)('img', { src: src, alt: alt, width: width, height: height });
 };

dist/types/instagram/parse.js

@@ -92,7 +92,6 @@ 'use strict';
 exports.default = function (_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   return testInstagramMediaEmbed(elm) || testInstagramIframe(elm);
 };

dist/types/instagram/render.js

@@ -14,6 +14,6 @@ 'use strict';
 var renderWithCaption = function renderWithCaption(_ref) {
-  var url = _ref.url;
-  var text = _ref.text;
-  var user = _ref.user;
-  var date = _ref.date;
+  var url = _ref.url,
+      text = _ref.text,
+      user = _ref.user,
+      date = _ref.date;
   return (0, _virtualElement2.default)(
@@ -64,6 +64,6 @@ 'blockquote',
 var renderWithoutCaption = function renderWithoutCaption(_ref2) {
-  var url = _ref2.url;
-  var text = _ref2.text;
-  var user = _ref2.user;
-  var date = _ref2.date;
+  var url = _ref2.url,
+      text = _ref2.text,
+      user = _ref2.user,
+      date = _ref2.date;
   return (0, _virtualElement2.default)(
@@ -106,7 +106,7 @@ 'blockquote',
 exports.default = function (_ref3) {
-  var url = _ref3.url;
-  var text = _ref3.text;
-  var user = _ref3.user;
-  var date = _ref3.date;
+  var url = _ref3.url,
+      text = _ref3.text,
+      user = _ref3.user,
+      date = _ref3.date;
   return text ? renderWithCaption({ url: url, text: text, user: user, date: date }) : renderWithoutCaption({ url: url, user: user, date: date });
 };

dist/types/spotify.js

@@ -31,6 +31,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (elm.tagName.toLowerCase() !== 'iframe') {
@@ -63,5 +62,5 @@ return null;
 var render = exports.render = function render(_ref3) {
-  var url = _ref3.url;
-  var _ref3$height = _ref3.height;
-  var height = _ref3$height === undefined ? 80 : _ref3$height;
+  var url = _ref3.url,
+      _ref3$height = _ref3.height,
+      height = _ref3$height === undefined ? 80 : _ref3$height;
   return (0, _renderIframe2.default)({
@@ -68,0 +67,0 @@ src: url, width: '100%', height: height

dist/types/tidal.js

@@ -17,6 +17,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (!elm.classList.contains('tidal-embed')) {
@@ -32,5 +31,5 @@ return null;
 var render = exports.render = function render(_ref3) {
-  var dataType = _ref3.dataType;
-  var dataId = _ref3.dataId;
+  var dataType = _ref3.dataType,
+      dataId = _ref3.dataId;
   return (0, _virtualElement2.default)('div', { 'class': 'tidal-embed', 'data-type': dataType, 'data-id': dataId });
 };

dist/types/tumblr.js

@@ -27,6 +27,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (!elm.classList.contains('tumblr-post')) {
@@ -44,5 +43,5 @@ return null;
 var render = exports.render = function render(_ref3) {
-  var did = _ref3.did;
-  var url = _ref3.url;
-  var text = _ref3.text;
+  var did = _ref3.did,
+      url = _ref3.url,
+      text = _ref3.text;
   return (0, _virtualElement2.default)(
@@ -49,0 +48,0 @@ 'div',

dist/types/twitter.js

@@ -61,6 +61,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (!elm.classList.contains('twitter-tweet') && !elm.classList.contains('twitter-video')) {
@@ -78,3 +77,3 @@ return null;
   var url = aElm.getAttribute('href');
-  var id = (0, _lodash4.default)(url.split('/').filter(Boolean));
+  var id = (0, _lodash4.default)(url.split('/').filter(Boolean)).split('?')[0];
   var date = aElm.childNodes.length > 0 ? aElm.childNodes[0].data : '';
@@ -92,7 +91,7 @@ var user = getUser(elm);
 var renderVideo = function renderVideo(_ref3) {
-  var text = _ref3.text;
-  var url = _ref3.url;
-  var date = _ref3.date;
-  var user = _ref3.user;
-  var id = _ref3.id;
+  var text = _ref3.text,
+      url = _ref3.url,
+      date = _ref3.date,
+      user = _ref3.user,
+      id = _ref3.id;
   return (0, _virtualElement2.default)(
@@ -116,7 +115,7 @@ 'blockquote',
 var renderTweet = function renderTweet(_ref4) {
-  var text = _ref4.text;
-  var url = _ref4.url;
-  var date = _ref4.date;
-  var user = _ref4.user;
-  var id = _ref4.id;
+  var text = _ref4.text,
+      url = _ref4.url,
+      date = _ref4.date,
+      user = _ref4.user,
+      id = _ref4.id;
   return (0, _virtualElement2.default)(
@@ -123,0 +122,0 @@ 'blockquote',

dist/types/video.js

@@ -45,14 +45,12 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   var tagName = elm.tagName.toLowerCase();
 
   if (tagName === 'video') {
-    var _getDimensions = (0, _dimensions2.default)(elm);
+    var _getDimensions = (0, _dimensions2.default)(elm),
+        width = _getDimensions.width,
+        height = _getDimensions.height;
 
-    var width = _getDimensions.width;
-    var height = _getDimensions.height;
-
     var sources = getSources(elm);
@@ -69,4 +67,4 @@
 var renderSource = function renderSource(_ref3) {
-  var src = _ref3.src;
-  var type = _ref3.type;
+  var src = _ref3.src,
+      type = _ref3.type;
   return (0, _virtualElement2.default)('source', { src: src, type: type });
@@ -76,5 +74,5 @@ };
 var render = exports.render = function render(_ref4) {
-  var sources = _ref4.sources;
-  var width = _ref4.width;
-  var height = _ref4.height;
+  var sources = _ref4.sources,
+      width = _ref4.width,
+      height = _ref4.height;
   return (0, _virtualElement2.default)(
@@ -81,0 +79,0 @@ 'video',

dist/types/vine.js

@@ -30,6 +30,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   if (elm.tagName.toLowerCase() !== 'iframe') {
@@ -58,5 +57,5 @@ return null;
 var render = exports.render = function render(_ref3) {
-  var url = _ref3.url;
-  var _ref3$size = _ref3.size;
-  var size = _ref3$size === undefined ? 600 : _ref3$size;
+  var url = _ref3.url,
+      _ref3$size = _ref3.size,
+      size = _ref3$size === undefined ? 600 : _ref3$size;
   return (0, _renderIframe2.default)({
@@ -63,0 +62,0 @@ src: url, width: size, height: size

dist/types/youtube.js

@@ -23,6 +23,5 @@ 'use strict';
 var parse = exports.parse = function parse(_ref) {
-  var _ref2 = _slicedToArray(_ref, 1);
+  var _ref2 = _slicedToArray(_ref, 1),
+      elm = _ref2[0];
 
-  var elm = _ref2[0];
-
   var tagName = elm.tagName.toLowerCase();
@@ -48,7 +47,7 @@
 var render = exports.render = function render(_ref3) {
-  var youtubeId = _ref3.youtubeId;
-  var _ref3$width = _ref3.width;
-  var width = _ref3$width === undefined ? 640 : _ref3$width;
-  var _ref3$height = _ref3.height;
-  var height = _ref3$height === undefined ? 360 : _ref3$height;
+  var youtubeId = _ref3.youtubeId,
+      _ref3$width = _ref3.width,
+      width = _ref3$width === undefined ? 640 : _ref3$width,
+      _ref3$height = _ref3.height,
+      height = _ref3$height === undefined ? 360 : _ref3$height;
   return (0, _renderIframe2.default)({
@@ -55,0 +54,0 @@ src: 'https://www.youtube.com/embed/' + youtubeId,

lib/types/twitter.js

@@ -46,3 +46,3 @@ import find from 'lodash.find';
   const url = aElm.getAttribute('href');
-  const id = last(url.split('/').filter(Boolean));
+  const id = last(url.split('/').filter(Boolean)).split('?')[0];
   const date = aElm.childNodes.length > 0 ? aElm.childNodes[0].data : '';
@@ -49,0 +49,0 @@ const user = getUser(elm);

package.json

 {
   "name": "embeds",
-  "version": "2.11.0",
+  "version": "2.11.3",
   "description": "Parse & render embeds",
@@ -5,0 +5,0 @@ "main": "dist/index.js",

test/html-parse-test.js

@@ -284,2 +284,23 @@ import test from './tape-wrapper';
 
+test('parse() tweet - href has query string', t => {
+  const input = `<blockquote class="twitter-tweet" data-lang="en"><p lang="en" dir="ltr">GIF vs. JIF… This <a href="https://t.co/qFAHWgdbL6">pic.twitter.com/qFAHWgdbL6</a></p>&mdash; Matt (foo) Navarra (@MattNavarra) <a href="https://twitter.com/MattNavarra/status/684690494841028608?ref_src=twsrc%5Etfw">January 6, 2016</a></blockquote><script async src="//platform.twitter.com/widgets.js" charset="utf-8"></script>`;
+  const actual = parse(input);
+  const expected = {
+    type: 'twitter',
+    embedAs: 'tweet',
+    text: [
+      {content: 'GIF vs. JIF… This ', href: null},
+      {content: 'pic.twitter.com/qFAHWgdbL6', href: 'https://t.co/qFAHWgdbL6'}
+    ],
+    url: 'https://twitter.com/MattNavarra/status/684690494841028608?ref_src=twsrc%5Etfw',
+    date: 'January 6, 2016',
+    user: {
+      slug: 'MattNavarra',
+      name: 'Matt (foo) Navarra'
+    },
+    id: '684690494841028608'
+  };
+  t.deepEqual(actual, expected);
+});
+
 test('parse() instagram http iframe', t => {
@@ -286,0 +307,0 @@ const input = `<iframe src="http://instagram.com/p/fdx1CSuEPV/embed"></iframe>`;

New alerts

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

135798

increased by0.74%

Lines of code

3325

increased by0.64%

Worsened metrics

Number of medium supply chain risk alerts

1

increased byInfinity%

No dependency changes