ember-cli-chartist - npm Package Compare versions

Comparing version 0.2.6 to 0.2.7

app/components/chartist-chart.js

@@ -68,3 +68,7 @@ import Ember from 'ember';
     if (this.get('updateOnData')) {
-      this.get('chart').update(this.get('data'));
+      var opts = this.get('options') || {};
+      this.get('chart').update(
+        this.get('data'),
+        opts
+      );
     }
@@ -71,0 +75,0 @@ }.observes('data'),

dist/assets/dummy.js

@@ -1,3 +0,7 @@
-define('dummy/app', ['exports', 'ember', 'ember/resolver', 'ember/load-initializers', './config/environment'], function (exports, Ember, Resolver, loadInitializers, config) {
+/* jshint ignore:start */
 
+/* jshint ignore:end */
+
+define('dummy/app', ['exports', 'ember', 'ember/resolver', 'ember/load-initializers', 'dummy/config/environment'], function (exports, Ember, Resolver, loadInitializers, config) {
+
   'use strict';
@@ -18,3 +22,3 @@
 });
-define('dummy/components/chart-fish-over-time', ['exports', 'ember', './chartist-chart'], function (exports, Ember, ChartistChart) {
+define('dummy/components/chart-fish-over-time', ['exports', 'ember', 'dummy/components/chartist-chart'], function (exports, Ember, ChartistChart) {
 
@@ -90,5 +94,3 @@ 'use strict';
 
-  var UNDEF,
-    // This is the structure that chartist is expecting
-    defaultDataStructure = {labels: [], series: []};
+  var UNDEF;
 
@@ -98,2 +100,6 @@ exports['default'] = Ember['default'].Component.extend({
 
+    // This is the structure that chartist is expecting, it can be overidden in
+    // your components which extend this one.
+    defaultDataStructure: { labels: [], series: [] },
+
     classNameBindings: ['ratio'],
@@ -131,13 +137,14 @@ classNames: ['ct-chart'],
 
-    data: defaultDataStructure,
+    data: null,
     options: UNDEF,
     responsiveOptions: UNDEF,
     updateOnData: true,
-    
+
     // This is where the business happens. This will only run if checkForReqs
     // doesn't find any problems.
     renderChart: function () {
+      var data = this.get('data') || this.get('defaultDataStructure');
       var chart = new (Chartist[this.get('chartType')])(
         this.get('element'),
-        this.get('data'),
+        data,
         this.get('options'),
@@ -152,3 +159,7 @@ this.get('responsiveOptions')
       if (this.get('updateOnData')) {
-        this.get('chart').update(this.get('data'));
+        var opts = this.get('options') || {};
+        this.get('chart').update(
+          this.get('data'),
+          opts
+        );
       }
@@ -181,3 +192,3 @@ }.observes('data'),
 });
-define('dummy/components/pie-i-like', ['exports', './chartist-chart'], function (exports, ChartistChart) {
+define('dummy/components/pie-i-like', ['exports', 'dummy/components/chartist-chart'], function (exports, ChartistChart) {
 
@@ -213,3 +224,3 @@ 'use strict';
 });
-define('dummy/initializers/export-application-global', ['exports', 'ember', '../config/environment'], function (exports, Ember, config) {
+define('dummy/initializers/export-application-global', ['exports', 'ember', 'dummy/config/environment'], function (exports, Ember, config) {
 
@@ -223,3 +234,3 @@ 'use strict';
 
-    if (config['default'].exportApplicationGlobal) {
+    if (config['default'].exportApplicationGlobal && !window[classifiedName]) {
       window[classifiedName] = application;
@@ -236,3 +247,3 @@ }
 });
-define('dummy/router', ['exports', 'ember', './config/environment'], function (exports, Ember, config) {
+define('dummy/router', ['exports', 'ember', 'dummy/config/environment'], function (exports, Ember, config) {
 
@@ -333,86 +344,6 @@ 'use strict';
 });
-define('dummy/tests/app.jshint', function () {
+define('dummy/tests/helpers/resolver', ['exports', 'ember/resolver', 'dummy/config/environment'], function (exports, Resolver, config) {
 
   'use strict';
 
-  module('JSHint - .');
-  test('app.js should pass jshint', function() { 
-    ok(true, 'app.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/components/chart-fish-over-time.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - components');
-  test('components/chart-fish-over-time.js should pass jshint', function() { 
-    ok(true, 'components/chart-fish-over-time.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/components/pie-i-like.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - components');
-  test('components/pie-i-like.js should pass jshint', function() { 
-    ok(true, 'components/pie-i-like.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/controllers/application.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - controllers');
-  test('controllers/application.js should pass jshint', function() { 
-    ok(true, 'controllers/application.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/dummy/tests/helpers/resolver.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - dummy/tests/helpers');
-  test('dummy/tests/helpers/resolver.js should pass jshint', function() { 
-    ok(true, 'dummy/tests/helpers/resolver.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/dummy/tests/helpers/start-app.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - dummy/tests/helpers');
-  test('dummy/tests/helpers/start-app.js should pass jshint', function() { 
-    ok(true, 'dummy/tests/helpers/start-app.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/dummy/tests/test-helper.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - dummy/tests');
-  test('dummy/tests/test-helper.js should pass jshint', function() { 
-    ok(true, 'dummy/tests/test-helper.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/dummy/tests/unit/components/chartist-chart-test.jshint', function () {
-
-  'use strict';
-
-  module('JSHint - dummy/tests/unit/components');
-  test('dummy/tests/unit/components/chartist-chart-test.js should pass jshint', function() { 
-    ok(true, 'dummy/tests/unit/components/chartist-chart-test.js should pass jshint.'); 
-  });
-
-});
-define('dummy/tests/helpers/resolver', ['exports', 'ember/resolver', '../../config/environment'], function (exports, Resolver, config) {
-
-  'use strict';
-
   var resolver = Resolver['default'].create();
@@ -428,3 +359,3 @@
 });
-define('dummy/tests/helpers/start-app', ['exports', 'ember', '../../app', '../../router', '../../config/environment'], function (exports, Ember, Application, Router, config) {
+define('dummy/tests/helpers/start-app', ['exports', 'ember', 'dummy/app', 'dummy/router', 'dummy/config/environment'], function (exports, Ember, Application, Router, config) {
 
@@ -450,27 +381,32 @@ 'use strict';
 });
-define('dummy/tests/router.jshint', function () {
+define('dummy/tests/test-helper', ['dummy/tests/helpers/resolver', 'ember-qunit'], function (resolver, ember_qunit) {
 
   'use strict';
 
-  module('JSHint - .');
-  test('router.js should pass jshint', function() { 
-    ok(true, 'router.js should pass jshint.'); 
-  });
+  ember_qunit.setResolver(resolver['default']);
 
-});
-define('dummy/tests/routes/application.jshint', function () {
 
-  'use strict';
+  // This is to save PhantomJS from itself, because PhantomJS < 2.0 doesn't have
+  // Function.prototype.bind for _reasons_
+  if (!Function.prototype.bind) {
+    Function.prototype.bind = function(oThis) {
+      if (typeof this !== "function") {
+        // closest thing possible to the ECMAScript 5 internal IsCallable function
+        throw new TypeError("Function.prototype.bind - what is trying to be bound is not callable");
+      }
 
-  module('JSHint - routes');
-  test('routes/application.js should pass jshint', function() { 
-    ok(true, 'routes/application.js should pass jshint.'); 
-  });
+      var aArgs = Array.prototype.slice.call(arguments, 1),
+          fToBind = this,
+          FNOP = function() {},
+          fBound = function() {
+            return fToBind.apply(this instanceof FNOP && oThis? this : oThis, aArgs.concat(Array.prototype.slice.call(arguments)));
+          };
 
-});
-define('dummy/tests/test-helper', ['./helpers/resolver', 'ember-qunit'], function (resolver, ember_qunit) {
+      FNOP.prototype = this.prototype;
+      fBound.prototype = new FNOP();
 
-  'use strict';
+      return fBound;
+    };
+  }
 
-  ember_qunit.setResolver(resolver['default']);
 
@@ -714,2 +650,6 @@ document.write('<div id="ember-testing-container"><div id="ember-testing"></div></div>');
 
+/* jshint ignore:end */
+
+/* jshint ignore:start */
+
 define('dummy/config/environment', ['ember'], function(Ember) {
@@ -716,0 +656,0 @@ var prefix = 'dummy';

package.json

 {
   "name": "ember-cli-chartist",
-  "version": "0.2.6",
+  "version": "0.2.7",
   "description": "Ember Addon for Chartist.js",
@@ -5,0 +5,0 @@ "directories": {

No alert changes

Improved metrics

Total package byte prevSize

12208606

101.12%

Number of package files

138

360%

Lines of code

145930

100.8%

No dependency changes