ember-modal-dialog - npm Package Compare versions

Comparing version 0.8.3 to 0.8.4

addon/components/positioned-container.js

@@ -17,3 +17,6 @@ import Ember from 'ember';
 
-  isPositioned: computed('targetAttachment', 'target', function() {
+  isPositioned: computed('targetAttachment', 'target', 'renderInPlace', function() {
+    if (this.get('renderInPlace')) {
+      return false;
+    }
     if (this.get('target') && this.get('targetAttachment')) {
@@ -20,0 +23,0 @@ return true;

addon/components/tether-dialog.js

@@ -19,4 +19,4 @@ import Ember from 'ember';
   attachment: 'middle center',
-  targetModifier: 'visible',
   hasOverlay: true,
+  target: 'viewport', // element, css selector, view instance, 'viewport', or 'scroll-handle'
 
@@ -26,2 +26,3 @@ tetherClassPrefix: 'ember-tether',
   // targetOffset - passed in
+  // targetModifier - passed in
 
@@ -28,0 +29,0 @@ makeOverlayClickableOnIOS: Ember.on('didInsertElement', function() {

addon/initializers/add-modals-container.js

 /*globals document */
-const hasDOM = typeof document !== 'undefined';
+let hasDOM = typeof document !== 'undefined';
 
@@ -9,4 +9,8 @@ function appendContainerElement(rootElementId, id) {
 
-  const rootEl = document.querySelector(rootElementId);
-  const modalContainerEl = document.createElement('div');
+  if (document.getElementById(id)) {
+    return;
+  }
+
+  let rootEl = document.querySelector(rootElementId);
+  let modalContainerEl = document.createElement('div');
   modalContainerEl.id = id;
@@ -17,5 +21,5 @@ rootEl.appendChild(modalContainerEl);
 export default function() {
-  const application = arguments[1] || arguments[0];
-  const emberModalDialog = application.emberModalDialog || {};
-  const modalContainerElId = emberModalDialog.modalRootElementId || 'modal-overlays';
+  let application = arguments[1] || arguments[0];
+  let emberModalDialog = application.emberModalDialog || {};
+  let modalContainerElId = emberModalDialog.modalRootElementId || 'modal-overlays';
 
@@ -22,0 +26,0 @@ application.register('config:modals-container-id',

CHANGELOG.md

 # Change Log
 
-## [0.8.3](https://github.com/yapplabs/ember-modal-dialog/tree/0.8.3) (2015-12-22)
-[Full Changelog](https://github.com/yapplabs/ember-modal-dialog/compare/v0.8.2...0.8.3)
+## [0.8.4](https://github.com/yapplabs/ember-modal-dialog/tree/0.8.4) (2016-05-11)
+[Full Changelog](https://github.com/yapplabs/ember-modal-dialog/compare/v0.8.3...0.8.4)
 
 **Closed issues:**
 
+- How about keeping targetModifier: null as default for tether-dialogs? [\#127](https://github.com/yapplabs/ember-modal-dialog/issues/127)
+- Rendering Link-to helpers inside the dialog changes the route, but doesn't close the modal. [\#119](https://github.com/yapplabs/ember-modal-dialog/issues/119)
+- clickOutsideToClose false is ignored on close action [\#115](https://github.com/yapplabs/ember-modal-dialog/issues/115)
+- Ember 1.12 compatible release? [\#112](https://github.com/yapplabs/ember-modal-dialog/issues/112)
+- Extending breaks wormhole to modal-overlays on 2.1.x and 2.2.x [\#97](https://github.com/yapplabs/ember-modal-dialog/issues/97)
+
+**Merged pull requests:**
+
+- Improve tether-dialog positioning [\#128](https://github.com/yapplabs/ember-modal-dialog/pull/128) ([chrislopresto](https://github.com/chrislopresto))
+- Update ember-tether version [\#126](https://github.com/yapplabs/ember-modal-dialog/pull/126) ([chrislopresto](https://github.com/chrislopresto))
+- Added link to introduction video [\#118](https://github.com/yapplabs/ember-modal-dialog/pull/118) ([taras](https://github.com/taras))
+- Fixes ember-try dependency for ember 1.13.10 [\#117](https://github.com/yapplabs/ember-modal-dialog/pull/117) ([jeremywrowe](https://github.com/jeremywrowe))
+
+## [v0.8.3](https://github.com/yapplabs/ember-modal-dialog/tree/v0.8.3) (2015-12-22)
+[Full Changelog](https://github.com/yapplabs/ember-modal-dialog/compare/v0.8.2...v0.8.3)
+
+**Closed issues:**
+
 - Introduction to ember-modal-dialog at Global Ember Meetup [\#105](https://github.com/yapplabs/ember-modal-dialog/issues/105)
@@ -35,2 +53,4 @@ - allow click outside to close with overlay [\#101](https://github.com/yapplabs/ember-modal-dialog/issues/101)
 - How to pass along close action from inner component? [\#84](https://github.com/yapplabs/ember-modal-dialog/issues/84)
+- Acceptance testing the tether-dialog when input is in the block? [\#81](https://github.com/yapplabs/ember-modal-dialog/issues/81)
+- Alignment 'none' issue in positioned container [\#75](https://github.com/yapplabs/ember-modal-dialog/issues/75)
 
@@ -45,2 +65,6 @@ **Merged pull requests:**
 
+**Fixed bugs:**
+
+- Opening modal fails in Ember 1.13.7+ [\#71](https://github.com/yapplabs/ember-modal-dialog/issues/71)
+
 **Closed issues:**
@@ -47,0 +71,0 @@

config/ember-try.js

@@ -30,3 +30,3 @@ module.exports = {
       dependencies: {
-        'ember': '1.12.1'
+        'ember': '1.13.10'
       }
@@ -33,0 +33,0 @@ },

package.json

 {
   "name": "ember-modal-dialog",
-  "version": "0.8.3",
+  "version": "0.8.4",
   "description": "An ember-cli addon for implementing modal dialogs",
@@ -36,3 +36,3 @@ "directories": {
     "ember-cli-uglify": "^1.2.0",
-    "ember-code-snippet": "1.1.0",
+    "ember-code-snippet": "1.3.0",
     "ember-disable-prototype-extensions": "^1.0.0",
@@ -43,3 +43,3 @@ "ember-disable-proxy-controllers": "^1.0.0",
     "ember-suave": "1.2.3",
-    "ember-tether": "^0.1.3",
+    "ember-tether": "^0.3.1",
     "ember-truth-helpers": "1.2.0",
@@ -46,0 +46,0 @@ "ember-try": "0.0.6",

README.md

@@ -13,2 +13,4 @@ # Ember Modal Dialog [![Build Status](https://travis-ci.org/yapplabs/ember-modal-dialog.svg?branch=master)](https://travis-ci.org/yapplabs/ember-modal-dialog) [![Ember Observer Score](http://emberobserver.com/badges/ember-modal-dialog.svg)](http://emberobserver.com/addons/ember-modal-dialog)
 
+[![Video image](https://i.vimeocdn.com/video/558401687_640x360.jpg)](https://vimeo.com/157192323)
+
 ## Including In An Ember Application
@@ -15,0 +17,0 @@

No alert changes

Improved metrics

Lines of code

347

increased by2.06%

Number of lines in readme file

334

increased by0.6%

Worsened metrics

Total package byte prevSize

89698

decreased by-15.9%

No dependency changes