engine.io-parser - npm Package Compare versions

Comparing version 2.1.3 to 2.2.0

lib/index.js

@@ -37,2 +37,4 @@ /**
 
+const EMPTY_BUFFER = Buffer.concat([]);
+
 /**
@@ -92,3 +94,3 @@ * Encodes a packet.
   var data = packet.data;
-  var typeBuffer = new Buffer(1);
+  var typeBuffer = Buffer.allocUnsafe(1);
   typeBuffer[0] = packets[packet.type];
@@ -186,3 +188,3 @@ return callback(Buffer.concat([typeBuffer, data]));
   var type = packetslist[msg.charAt(0)];
-  var data = new Buffer(msg.substr(1), 'base64');
+  var data = Buffer.from(msg.substr(1), 'base64');
   if (binaryType === 'arraybuffer') {
@@ -351,3 +353,3 @@ var abv = new Uint8Array(data.length);
 function stringToBuffer(string) {
-  var buf = new Buffer(string.length);
+  var buf = Buffer.allocUnsafe(string.length);
   for (var i = 0, l = string.length; i < l; i++) {
@@ -368,11 +370,6 @@ buf.writeUInt8(string.charCodeAt(i), i);
   // data is either an ArrayBuffer or ArrayBufferView.
-  var array = new Uint8Array(data.buffer || data);
   var length = data.byteLength || data.length;
   var offset = data.byteOffset || 0;
-  var buffer = new Buffer(length);
 
-  for (var i = 0; i < length; i++) {
-    buffer[i] = array[offset + i];
-  }
-  return buffer;
+  return Buffer.from(data.buffer || data, offset, length);
 }
@@ -396,3 +393,3 @@
   if (!packets.length) {
-    return callback(new Buffer(0));
+    return callback(EMPTY_BUFFER);
   }
@@ -413,3 +410,3 @@
     if (typeof packet === 'string') {
-      sizeBuffer = new Buffer(encodingLength.length + 2);
+      sizeBuffer = Buffer.allocUnsafe(encodingLength.length + 2);
       sizeBuffer[0] = 0; // is a string (not true binary = 0)
@@ -423,3 +420,3 @@ for (var i = 0; i < encodingLength.length; i++) {
 
-    sizeBuffer = new Buffer(encodingLength.length + 2);
+    sizeBuffer = Buffer.allocUnsafe(encodingLength.length + 2);
     sizeBuffer[0] = 1; // is binary (true binary = 1)
@@ -426,0 +423,0 @@ for (var i = 0; i < encodingLength.length; i++) {

package.json

@@ -5,6 +5,7 @@ {
   "license": "MIT",
-  "version": "2.1.3",
+  "version": "2.2.0",
   "main": "lib/index.js",
   "homepage": "https://github.com/socketio/engine.io-parser",
   "devDependencies": {
+    "benchmark": "^2.1.4",
     "expect.js": "0.3.1",
@@ -11,0 +12,0 @@ "mocha": "^5.2.0",

Readme.md

 
 # engine.io-parser
 
-[![Build Status](https://secure.travis-ci.org/socketio/engine.io-parser.svg)](http://travis-ci.org/socketio/engine.io-parser)
-[![NPM version](https://badge.fury.io/js/engine.io-parser.svg)](http://badge.fury.io/js/engine.io-parser)
+[![Build Status](https://secure.travis-ci.org/socketio/engine.io-parser.svg?branch=master)](https://travis-ci.org/socketio/engine.io-parser)
+[![NPM version](https://badge.fury.io/js/engine.io-parser.svg)](https://npmjs.com/package/engine.io-parser)
 
@@ -7,0 +7,0 @@ This is the JavaScript parser for the engine.io protocol encoding,

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Worsened metrics

Total package byte prevSize

39150

decreased by-0.01%

Dev dependency count

6

increased by20%

Lines of code

1084

decreased by-0.37%

No dependency changes