ep_comments_page - npm Package Compare versions

Comparing version 0.0.25 to 0.0.26

package.json

 {
   "description": "Adds comments on sidebar and link it to the text.  Support for Page View, requires ep_page_view",
   "name": "ep_comments_page",
-  "version": "0.0.25",
+  "version": "0.0.26",
   "author": {
@@ -6,0 +6,0 @@ "name": "Nicolas Lescop",

static/js/index.js

@@ -286,4 +286,7 @@ /* TODO:
     });
+
+    // On submit we should hide this suggestion no?
     if($(this).parent().parent().find(".reply-suggestion-checkbox").is(':checked')){
-      $(this).parent().parent().find(".reply-suggestion-checkbox:clicked").click(); //Only uncheck checked boxes. TODO: is a cleanup operation. Should we do it here?
+      $(this).parent().parent().find(".reply-suggestion-checkbox:clicked").click(); 
+      //Only uncheck checked boxes. TODO: is a cleanup operation. Should we do it here?
     }
@@ -467,6 +470,5 @@ });
   var padComment  = this.padInner.contents().find('.comment');
-  $.each(this.commentReplies, function(replyId, replies){
-    var commentId = replies.commentId;
+  $.each(this.commentReplies, function(replyId, reply){
+    var commentId = reply.commentId;
 
-
     // tell comment icon that this comment has 1+ replies
@@ -480,10 +482,10 @@ commentIcons.commentHasReply(commentId);
 
+    reply.replyId = replyId;
+    reply.formattedDate = new Date(reply.timestamp).toISOString();
 
-    replies.replyId = replyId;
-
-    var content = $("#replyTemplate").tmpl(replies);
+    var content = $("#replyTemplate").tmpl(reply);
     $('iframe[name="ace_outer"]').contents().find('#'+commentId + ' .comment-reply-input-label').before(content);
     // Should we show "Revert" instead of "Accept"
     // Comment Replies ARE handled here..
-    if(replies.changeAccepted){
+    if(reply.changeAccepted){
       self.showChangeAsAccepted(replyId);
@@ -692,2 +694,3 @@ }
       comment.data.date = prettyDate(comment.data.timestamp);
+      comment.data.formattedDate = new Date(comment.data.timestamp).toISOString();
       commentElm.attr('title', comment.data.date);
@@ -709,2 +712,3 @@ }
   comment.date = prettyDate(comment.timestamp);
+  comment.formattedDate = new Date(comment.timestamp).toISOString();
   if (comments[commentId] == null) comments[commentId] = {};
@@ -711,0 +715,0 @@ comments[commentId].data = comment;

No alert changes

Improved metrics

Total package byte prevSize

144224

increased by0.23%

Lines of code

3299

increased by0.24%

No dependency changes