ep_comments_page - npm Package Compare versions

Comparing version 0.1.0 to 0.1.1

package.json

 {
   "description": "Adds comments on sidebar and link it to the text.  Support for Page View, requires ep_page_view",
   "name": "ep_comments_page",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "author": {
@@ -6,0 +6,0 @@ "name": "Nicolas Lescop",

static/js/index.js

@@ -623,7 +623,2 @@ /* TODO:
 
-  // hide each outer comment...
-  commentBoxes.hideAllComments();
-  // ... and hide comment icons too
-  commentIcons.hideIcons();
-
   $.each(inlineComments, function(){
@@ -1220,14 +1215,15 @@ var commentId = /(?:^| )(c-[A-Za-z0-9]*)/.exec(this.className); // classname is the ID of the comment
 
-    // var padOuter = $('iframe[name="ace_outer"]').contents();
-    // padOuter.find('#sidediv').removeClass("sidedivhidden"); // TEMPORARY to do removing authorship colors can add sidedivhidden class to sidesiv!
     if(eventType == "setup" || eventType == "setBaseText" || eventType == "importText") return;
     if(context.callstack.docTextChanged) pad.plugins.ep_comments_page.setYofComments();
-    var commentWasPasted = pad.plugins.ep_comments_page.shouldCollectComment;
-    var domClean = context.callstack.domClean;
-    // we have to wait the DOM update from a fakeComment 'fakecomment-123' to a comment class 'c-123'
-    if(commentWasPasted && domClean){
-      pad.plugins.ep_comments_page.collectComments(function(){
-        pad.plugins.ep_comments_page.collectCommentReplies();
-        pad.plugins.ep_comments_page.shouldCollectComment = false;
-      });
+    // some times on init ep_comments_page is not yet on the plugin list
+    if (pad.plugins.ep_comments_page) {
+      var commentWasPasted = pad.plugins.ep_comments_page.shouldCollectComment;
+      var domClean = context.callstack.domClean;
+      // we have to wait the DOM update from a fakeComment 'fakecomment-123' to a comment class 'c-123'
+      if(commentWasPasted && domClean){
+        pad.plugins.ep_comments_page.collectComments(function(){
+          pad.plugins.ep_comments_page.collectCommentReplies();
+          pad.plugins.ep_comments_page.shouldCollectComment = false;
+        });
+      }
     }
@@ -1234,0 +1230,0 @@ },

No alert changes

Worsened metrics

Total package byte prevSize

266843

-0.08%

Lines of code

6031

-0.05%

No dependency changes