ep_comments_page - npm Package Compare versions

Comparing version 1.0.36 to 1.0.37

package.json

 {
   "description": "Adds comments on sidebar and link it to the text.  For no-skin use ep_page_view.",
   "name": "ep_comments_page",
-  "version": "1.0.36",
+  "version": "1.0.37",
   "author": {
@@ -32,3 +32,3 @@ "name": "Nicolas Lescop",
     "eslint-config-etherpad": "^4.0.4",
-    "socket.io-client": "^4.7.5",
+    "socket.io-client": "*",
     "superagent": "^8.1.2",
@@ -35,0 +35,0 @@ "typescript": "^5.4.2"

static/js/index.js

@@ -22,2 +22,4 @@ 'use strict';
 const Security = require('ep_etherpad-lite/static/js/security');
+// eslint-disable-next-line no-redeclare
+const io = require('socket.io-client');
 
@@ -793,3 +795,8 @@ const cssFiles = [
 EpComments.prototype.deleteComment = function (commentId) {
-  $('iframe[name="ace_outer"]').contents().find(`#${commentId}`).remove();
+  while($('iframe[name="ace_outer"]').contents().find(`#${commentId}`).length > 0){
+    $('iframe[name="ace_outer"]').contents().find(`#${commentId}`).remove();
+  }
+  while($('iframe[name="ace_outer"]').contents().find(`#icon-${commentId}`).length > 0){
+    $('iframe[name="ace_outer"]').contents().find(`#icon-${commentId}`).remove();
+  }
 };
@@ -796,0 +803,0 @@

No alert changes

Improved metrics

Total package byte prevSize

704391

increased by0.05%

Lines of code

8863

increased by0.08%

No dependency changes