err-code - npm Package Compare versions

Comparing version 2.0.0 to 2.0.1

index.js

 'use strict';
 
+function maybeDefineProperty(obj, name, value) {
+    var descriptor;
+
+    if (Object.isFrozen(obj)) {
+        return;
+    }
+
+    descriptor = Object.getOwnPropertyDescriptor(obj, name);
+
+    if (descriptor && !descriptor.writable) {
+        return;
+    }
+
+    obj[name] = value;
+}
+
 function createError(err, code, props) {
@@ -13,3 +29,3 @@ var key;
     } else if (code != null) {
-        err.code = code;
+        maybeDefineProperty(err, 'code', code);
     }
@@ -19,3 +35,3 @@
         for (key in props) {
-            err[key] = props[key];
+            maybeDefineProperty(err, key, props[key]);
         }
@@ -22,0 +38,0 @@ }

index.umd.js

 (function(f){if(typeof exports==="object"&&typeof module!=="undefined"){module.exports=f()}else if(typeof define==="function"&&define.amd){define([],f)}else{var g;if(typeof window!=="undefined"){g=window}else if(typeof global!=="undefined"){g=global}else if(typeof self!=="undefined"){g=self}else{g=this}g.errCode = f()}})(function(){var define,module,exports;return (function(){function r(e,n,t){function o(i,f){if(!n[i]){if(!e[i]){var c="function"==typeof require&&require;if(!f&&c)return c(i,!0);if(u)return u(i,!0);var a=new Error("Cannot find module '"+i+"'");throw a.code="MODULE_NOT_FOUND",a}var p=n[i]={exports:{}};e[i][0].call(p.exports,function(r){var n=e[i][1][r];return o(n||r)},p,p.exports,r,e,n,t)}return n[i].exports}for(var u="function"==typeof require&&require,i=0;i<t.length;i++)o(t[i]);return o}return r})()({1:[function(require,module,exports){
 'use strict';
 
+function maybeDefineProperty(obj, name, value) {
+    var descriptor;
+
+    if (Object.isFrozen(obj)) {
+        return;
+    }
+
+    descriptor = Object.getOwnPropertyDescriptor(obj, name);
+
+    if (descriptor && !descriptor.writable) {
+        return;
+    }
+
+    obj[name] = value;
+}
+
 function createError(err, code, props) {
@@ -14,3 +30,3 @@ var key;
     } else if (code != null) {
-        err.code = code;
+        maybeDefineProperty(err, 'code', code);
     }
@@ -20,3 +36,3 @@
         for (key in props) {
-            err[key] = props[key];
+            maybeDefineProperty(err, key, props[key]);
         }
@@ -23,0 +39,0 @@ }

package.json

 {
   "name": "err-code",
-  "version": "2.0.0",
+  "version": "2.0.1",
   "description": "Create an error with a code",
@@ -5,0 +5,0 @@ "main": "index.js",

README.md

@@ -58,3 +58,7 @@ # err-code
 
+## Pre-existing fields
 
+If the passed `Error` already has a `.code` field, or fields specified in the third argument to `errcode` they will be overwritten, unless the fields have been [defined as read-only](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty) or the `Error` object has been [frozen](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze).
+
+
 ## Tests
@@ -61,0 +65,0 @@

test/test.js

@@ -51,2 +51,24 @@ 'use strict';
         });
+
+        it('should not attempt to set non-writable field', function () {
+            var myErr = new Error('my message');
+            var err;
+
+            Object.defineProperty(myErr, 'code', {
+                value: 'derp',
+                writable: false,
+            });
+            err = errcode(myErr, 'ERR_WAT');
+
+            expect(err).to.be.an(Error);
+            expect(err.code).to.be('derp');
+        });
+
+        it('should not add code to frozen object', function () {
+            var myErr = new Error('my message');
+            var err = errcode(Object.freeze(myErr), 'ERR_WAT');
+
+            expect(err).to.be.an(Error);
+            expect(err.code).to.be(undefined);
+        });
     });
@@ -53,0 +75,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

New author

Supply chain risk

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

9742

increased by22.63%

Lines of code

177

increased by28.26%

Number of lines in readme file

71

increased by5.97%

Number of medium supply chain risk alerts

0

decreased by-100%

No dependency changes