eslint-plugin-backbone - npm Package Compare versions

Comparing version 1.0.4 to 1.0.5

docs/rules/collection-model.md

@@ -0,0 +0,0 @@ # Require all collections to declare model (collection-model)

docs/rules/defaults-on-top.md

@@ -0,0 +0,0 @@ # Require defaults to be on top of the model (defaults-on-top)

docs/rules/event-scope.md

@@ -0,0 +0,0 @@ # Verify that scope is passed into event handlers (event-scope)

docs/rules/events-on-top.md

@@ -0,0 +0,0 @@ # Events should be the first thing registered in the View (events-on-top)

docs/rules/initialize-on-top.md

@@ -0,0 +0,0 @@ # Requires initialize to be the first property of Backbone Views/Models/Collections (initialize-on-top)

docs/rules/model-defaults.md

@@ -0,0 +0,0 @@ # Require all models to have defaults section (model-defaults)

docs/rules/no-changed-set.md

@@ -0,0 +0,0 @@ # Prevent setting changed attribute of the model in views (no-changed-set)

docs/rules/no-collection-models.md

@@ -0,0 +0,0 @@ # Prevent access to models property of collections (no-collection-models)

docs/rules/no-el-assign.md

@@ -0,0 +0,0 @@ # Prevent assigning el or $el inside views (no-el-assign)

docs/rules/no-model-attributes.md

@@ -0,0 +0,0 @@ # Prevent access to attributes collection inside models (no-model-attributes)

docs/rules/no-native-jquery.md

@@ -0,0 +0,0 @@ # Prevent usage of $ in the views (no-native-jquery)

docs/rules/no-silent.md

@@ -0,0 +0,0 @@ # Prevent using silent option in functions that cause events (no-silent)

docs/rules/no-view-collection-models.md

@@ -0,0 +0,0 @@ # Prevent access to collection's models property inside views (no-view-collection-models)

docs/rules/no-view-model-attributes.md

@@ -0,0 +0,0 @@ # Prevent access to model's attributes collection inside views (no-view-model-attributes)

docs/rules/no-view-onoff-binding.md

@@ -0,0 +0,0 @@ # Prevent using on/off bindings inside views (no-view-onoff-binding)

docs/rules/render-return.md

@@ -0,0 +0,0 @@ # Enforces render function to always return this (render-return)

index.js

@@ -0,0 +0,0 @@ "use strict";

lib/backbone-helper.js

@@ -18,5 +18,2 @@ function isBackboneBase(node, settings) {
     return settings.map(function(setting) {
-        if (typeof setting === "object") {
-            return setting;
-        }
         var splitValue = setting.split(".");
@@ -27,10 +24,12 @@ return splitValue.length > 1 ? { prefix: splitValue[0], postfix: splitValue[1] } : { prefix: splitValue[0] };
 
-function normalizeSettings(settings) {
+function normalizeSettings(originalSettings) {
     "use strict";
-    settings = settings || {};
-    settings.Collection = settings.Collection ? settings.Collection.concat("Backbone.Collection") : ["Backbone.Collection"];
+    originalSettings = originalSettings || {};
+    
+    var settings = {};
+    settings.Collection = originalSettings.Collection ? originalSettings.Collection.concat("Backbone.Collection") : ["Backbone.Collection"];
     settings.Collection = parseSettings(settings.Collection);
-    settings.Model = settings.Model ? settings.Model.concat("Backbone.Model") : ["Backbone.Model"];
+    settings.Model = originalSettings.Model ? originalSettings.Model.concat("Backbone.Model") : ["Backbone.Model"];
     settings.Model = parseSettings(settings.Model);
-    settings.View = settings.View ? settings.View.concat("Backbone.View") : ["Backbone.View"];
+    settings.View = originalSettings.View ? originalSettings.View.concat("Backbone.View") : ["Backbone.View"];
     settings.View = parseSettings(settings.View);
@@ -37,0 +36,0 @@ return settings;

lib/rules/collection-model.js

@@ -0,0 +0,0 @@ /**

lib/rules/defaults-on-top.js

@@ -0,0 +0,0 @@ /**

lib/rules/event-scope.js

@@ -0,0 +0,0 @@ /**

lib/rules/events-on-top.js

@@ -0,0 +0,0 @@ /**

lib/rules/initialize-on-top.js

@@ -0,0 +0,0 @@ /**

lib/rules/model-defaults.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-changed-set.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-collection-models.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-constructor.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-el-assign.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-model-attributes.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-native-jquery.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-silent.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-view-collection-models.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-view-model-attributes.js

@@ -0,0 +0,0 @@ /**

lib/rules/no-view-onoff-binding.js

@@ -0,0 +0,0 @@ /**

lib/rules/render-return.js

@@ -0,0 +0,0 @@ /**

package.json

 {
   "name": "eslint-plugin-backbone",
-  "version": "1.0.4",
+  "version": "1.0.5",
   "description": "Eslint rules for Backbone.",
@@ -5,0 +5,0 @@ "main": "index.js",

tests/lib/rules/defaults-on-top.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/event-scope.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/initialize-on-top.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/model-defaults.js

@@ -29,3 +29,4 @@ /**
         "var a=6 * 7;",
-        "Backbone.Model.extend({ defaults: {}, initialize: function() { alert(); } });"
+        "Backbone.Model.extend({ defaults: {}, initialize: function() { alert(); } });",
+        { code: "Model.extend({ initialize: function() { }, defaults: {} });", settings: { backbone: { Model: ["Model"] } }}
     ],
@@ -32,0 +33,0 @@

tests/lib/rules/no-changed-set.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-collection-models.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-constructor.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-el-assign.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-model-attributes.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-native-jquery.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-silent.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-view-collection-models.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-view-model-attributes.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/no-view-onoff-binding.js

@@ -0,0 +0,0 @@ /**

tests/lib/rules/render-return.js

@@ -0,0 +0,0 @@ /**

No alert changes

Worsened metrics

Total package byte prevSize

92168

-2.19%

Lines of code

1491

-0.07%

No dependency changes