eslint-plugin-ember

Advanced tools

Install Socket

Detect and block malicious and high-risk dependencies

eslint-plugin-ember - npm Package Compare versions

Comparing version 6.0.0 to 6.0.1

CHANGELOG.md

		# Changelog

		## v6.0.1 (2018-11-16)

		#### :rocket: Enhancement
		* [#331](https://github.com/ember-cli/eslint-plugin-ember/pull/331) Updating no-side-effects to also report on setProperties. ([@gmurphey](https://github.com/gmurphey))

		#### :bug: Bug Fix
		* [#340](https://github.com/ember-cli/eslint-plugin-ember/pull/340) no-restricted-resolver: Fix crashes ([@Turbo87](https://github.com/Turbo87))

		#### :house: Internal
		* [#335](https://github.com/ember-cli/eslint-plugin-ember/pull/335) Remove outdated `.nvmrc` file ([@Turbo87](https://github.com/Turbo87))
		* [#334](https://github.com/ember-cli/eslint-plugin-ember/pull/334) package.json: Limit published files to the `lib` folder ([@Turbo87](https://github.com/Turbo87))
		* [#336](https://github.com/ember-cli/eslint-plugin-ember/pull/336) CI: Use `--runInBand` option of Jest to speed up tests ([@Turbo87](https://github.com/Turbo87))

		#### Committers: 2
		- Garrett Murphey ([@gmurphey](https://github.com/gmurphey))
		- Tobias Bieniek ([@Turbo87](https://github.com/Turbo87))


		## v6.0.0 (2018-11-14)
		@@ -4,0 +22,0 @@

lib/rules/no-restricted-resolver-tests.js

		@@ -95,5 +95,3 @@ 'use strict';
		].forEach((fn) => {
		visitors[`Identifier[name="${fn}"]`] = function (node) {
		const lastArgument = getLastArgument(node);

		visitors[`CallExpression > Identifier[name="${fn}"]`] = function (node) {
		if (hasOnlyStringArgument(node)) {
		@@ -104,3 +102,6 @@ context.report(node, getSingleStringArgumentMessage(fn));

		if (hasUnitTrue(lastArgument)) {
		const lastArgument = getLastArgument(node);
		const lastArgumentIsObject = utils.isObjectExpression(lastArgument);

		if (lastArgumentIsObject && hasUnitTrue(lastArgument)) {
		context.report(lastArgument, getNoUnitTrueMessage(fn));
		@@ -110,3 +111,3 @@ return;

		if (hasNeeds(lastArgument)) {
		if (lastArgumentIsObject && hasNeeds(lastArgument)) {
		context.report(lastArgument, getNoNeedsMessage(fn));
		@@ -116,6 +117,3 @@ return;

		if (
		utils.isObjectExpression(lastArgument) &&
		!hasIntegrationTrue(lastArgument)
		) {
		if (lastArgumentIsObject && !hasIntegrationTrue(lastArgument)) {
		context.report(
		@@ -122,0 +120,0 @@ lastArgument,

lib/rules/no-side-effects.js

		@@ -10,2 +10,6 @@ 'use strict';

		function isUnallowedMethod(name) {
		return ['set', 'setProperties'].indexOf(name) > -1;
		}

		module.exports = {
		@@ -42,3 +46,3 @@ meta: {
		utils.isIdentifier(callee) &&
		callee.name === 'set'
		isUnallowedMethod(callee.name)
		) \|\| (
		@@ -48,3 +52,3 @@ utils.isMemberExpression(callee) &&
		utils.isIdentifier(callee.property) &&
		callee.property.name === 'set'
		isUnallowedMethod(callee.property.name)
		);
		@@ -51,0 +55,0 @@

package.json

		{
		"name": "eslint-plugin-ember",
		"version": "6.0.0",
		"version": "6.0.1",
		"description": "Eslint plugin for Ember.js apps",
		"main": "lib/index.js",
		"files": [
		"lib"
		],
		"directories": {
		@@ -54,3 +57,3 @@ "rules": "rules",
		"eslint-plugin-import": "^2.14.0",
		"jest": "^22.4.3",
		"jest": "^23.6.0",
		"lerna-changelog": "^0.8.2"
		@@ -57,0 +60,0 @@ },

.editorconfig

.eslintignore

.eslintrc.js

.nvmrc

.travis.yml

docs/rules/alias-model-in-controller.md

docs/rules/avoid-leaking-state-in-components.md

docs/rules/avoid-leaking-state-in-ember-objects.md

docs/rules/closure-actions.md

docs/rules/jquery-ember-run.md

docs/rules/local-modules.md

docs/rules/named-functions-in-promises.md

docs/rules/new-module-imports.md

docs/rules/no-attrs-in-components.md

docs/rules/no-attrs-snapshot.md

docs/rules/no-capital-letters-in-routes.md

docs/rules/no-duplicate-dependent-keys.md

docs/rules/no-ember-testing-in-module-scope.md

docs/rules/no-empty-attrs.md

docs/rules/no-function-prototype-extensions.md

docs/rules/no-global-jquery.md

docs/rules/no-jquery.md

docs/rules/no-new-mixins.md

docs/rules/no-observers.md

docs/rules/no-old-shims.md

docs/rules/no-on-calls-in-components.md

docs/rules/no-restricted-resolver-tests.md

docs/rules/no-side-effects.md

docs/rules/no-test-import-export.md

docs/rules/order-in-components.md

docs/rules/order-in-controllers.md

docs/rules/order-in-models.md

docs/rules/order-in-routes.md

docs/rules/require-super-in-init.md

docs/rules/routes-segments-snake-case.md

docs/rules/use-brace-expansion.md

docs/rules/use-ember-get-and-set.md

RELEASE.md

scripts/update-rules.js

tests/__snapshots__/recommended.js.snap

tests/lib/rules/alias-model-in-controller.js

tests/lib/rules/avoid-leaking-state-in-components.js

tests/lib/rules/avoid-leaking-state-in-ember-objects.js

tests/lib/rules/avoid-using-needs-in-controllers.js

tests/lib/rules/closure-actions.js

tests/lib/rules/jquery-ember-run.js

tests/lib/rules/local-modules.js

tests/lib/rules/named-functions-in-promises.js

tests/lib/rules/new-module-imports.js

tests/lib/rules/no-attrs-in-components.js

tests/lib/rules/no-attrs-snapshot.js

tests/lib/rules/no-capital-letters-in-routes.js

tests/lib/rules/no-duplicate-dependent-keys.js

tests/lib/rules/no-ember-testing-in-module-scope.js

tests/lib/rules/no-empty-attrs.js

tests/lib/rules/no-function-prototype-extensions.js

tests/lib/rules/no-global-jquery.js

tests/lib/rules/no-jquery.js

tests/lib/rules/no-new-mixins.js

tests/lib/rules/no-observers.js

tests/lib/rules/no-old-shims.js

tests/lib/rules/no-on-calls-in-components.js

tests/lib/rules/no-restricted-resolver-tests.js

tests/lib/rules/no-side-effects.js

tests/lib/rules/no-test-import-export.js

tests/lib/rules/order-in-components.js

tests/lib/rules/order-in-controllers.js

tests/lib/rules/order-in-models.js

tests/lib/rules/order-in-routes.js

tests/lib/rules/require-super-in-init.js

tests/lib/rules/routes-segments-snake-case.js

tests/lib/rules/use-brace-expansion.js

tests/lib/rules/use-ember-get-and-set.js

tests/lib/utils/ember-test.js

tests/lib/utils/property-order.js

tests/lib/utils/utils-test.js

tests/plugin-exports.js

tests/recommended.js

yarn.lock

New alerts