eslint-plugin-indexof - npm Package Compare versions

Comparing version 0.0.0 to 0.1.0

lib/index.js

@@ -10,8 +10,2 @@ /**
 //------------------------------------------------------------------------------
-// Requirements
-//------------------------------------------------------------------------------
-
-var requireIndex = require("requireindex");
-
-//------------------------------------------------------------------------------
 // Plugin Definition
@@ -22,5 +16,7 @@ //------------------------------------------------------------------------------
 // import all rules in lib/rules
-module.exports.rules = requireIndex("./rules");
+module.exports.rules = {
+    "no-indexof": require("./rules/no-indexof.js")
+}
 
 
 

lib/rules/no-indexof.js

@@ -18,5 +18,9 @@ /**
 
+    function isMethodCall(node) {
+        return !!node.callee.property;
+    }
+
     return {
         CallExpression: function (node) {
-            if(node.callee.property.name === 'indexOf'){
+            if(isMethodCall(node) && node.callee.property.name === 'indexOf'){
                 if(exceptOn.indexOf(node.callee.object.name) < 0) {
@@ -23,0 +27,0 @@ context.report(node, "Unexpected indexOf");

package.json

 {
   "name": "eslint-plugin-indexof",
-  "version": "0.0.0",
+  "version": "0.1.0",
   "description": "Disallow using the method indexOf",
@@ -10,3 +10,3 @@ "keywords": [
   ],
-  "author": "Jordan Eldredge <[e-mail]>",
+  "author": "Jordan Eldredge",
   "main": "lib/index.js",
@@ -13,0 +13,0 @@ "scripts": {

tests/lib/rules/no-indexof.js

@@ -26,3 +26,5 @@ /**
         "myArray.myMethod(x);",
-        { code: "_.indexOf(myArray, x);", options: [{'exceptOn': ['_']}] }
+        { code: "_.indexOf(myArray, x);", options: [{'exceptOn': ['_']}] },
+        "indexOf(x);",
+        "anotherFunction(x);"
     ],
@@ -29,0 +31,0 @@ invalid: [ {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Lines of code

94

increased by3.3%

Worsened metrics

Total package byte prevSize

5170

decreased by-1.26%

No dependency changes