eslint-plugin-jsx-a11y - npm Package Compare versions

Comparing version 0.5.3 to 0.5.4

lib/util/getAttributeValue.js

@@ -18,35 +18,39 @@ 'use strict';
     return value.name === "" ? undefined : value.name;
-  } else if (value.type === 'JSXExpressionContainer') {
-    var expression = value.expression;
+  } else if (value.type === 'JSXElement') {
+    return undefined; // For now, just so things don't break.
+  }
 
+  var expression = value.expression;
 
-    switch (expression.type) {
-      case 'Literal':
-        return expression.value === "" ? undefined : expression.value;
-      case 'TemplateLiteral':
-        return (0, _buildTemplateLiteral2.default)(expression);
-      case 'Identifier':
-        return expression.name == 'undefined' ? undefined : expression.name;
-      case 'ArrowFunctionExpression':
-      case 'FunctionExpression':
-        return function () {
-          return void 0;
-        };
-      case 'LogicalExpression':
-        var operator = expression.operator;
-        var left = expression.left;
-        var right = expression.right;
+  var type = expression ? expression.type : value.type;
+  var obj = expression || value;
 
-        var leftVal = getValue(left);
-        var rightVal = getValue(right);
+  switch (type) {
+    case 'Literal':
+      return obj.value === "" ? undefined : obj.value;
+    case 'TemplateLiteral':
+      return (0, _buildTemplateLiteral2.default)(obj);
+    case 'Identifier':
+      return obj.name == 'undefined' ? undefined : obj.name;
+    case 'ArrowFunctionExpression':
+    case 'FunctionExpression':
+      return function () {
+        return void 0;
+      };
+    case 'LogicalExpression':
+      var operator = obj.operator;
+      var left = obj.left;
+      var right = obj.right;
 
-        return operator == '&&' ? leftVal && rightVal : leftVal || rightVal;
-      case 'MemberExpression':
-        return getValue(expression.object) + '.' + expression.property;
-      default:
-        return undefined;
-    }
+      var leftVal = getValue(left);
+      var rightVal = getValue(right);
+
+      return operator == '&&' ? leftVal && rightVal : leftVal || rightVal;
+    case 'MemberExpression':
+      return getValue(obj.object) + '.' + getValue(obj.property);
+    case 'CallExpression':
+      return getValue(obj.callee);
+    default:
+      return undefined;
   }
-
-  return undefined;
 };
@@ -53,0 +57,0 @@

package.json

 {
   "name": "eslint-plugin-jsx-a11y",
-  "version": "0.5.3",
+  "version": "0.5.4",
   "description": "A static analysis linter of jsx and their accessibility with screen readers.",
@@ -5,0 +5,0 @@ "keywords": [

src/util/getAttributeValue.js

@@ -10,29 +10,34 @@ 'use strict';
     return value.name === "" ? undefined : value.name;
-  } else if (value.type === 'JSXExpressionContainer') {
-    const { expression } = value;
+  } else if (value.type === 'JSXElement') {
+    return undefined; // For now, just so things don't break.
+  }
 
-    switch (expression.type) {
-      case 'Literal':
-        return expression.value === "" ? undefined : expression.value;
-      case 'TemplateLiteral':
-        return buildTemplateLiteral(expression);
-      case 'Identifier':
-        return expression.name == 'undefined' ? undefined : expression.name;
-      case 'ArrowFunctionExpression':
-      case 'FunctionExpression':
-        return () => void 0;
-      case 'LogicalExpression':
-        const { operator, left, right } = expression;
-        const leftVal = getValue(left);
-        const rightVal = getValue(right);
+  const { expression } = value;
+  const type = expression ? expression.type : value.type;
+  const obj = expression || value;
 
-        return operator == '&&' ? leftVal && rightVal : leftVal || rightVal;
-      case 'MemberExpression':
-        return `${getValue(expression.object)}.${expression.property}`;
-      default:
-        return undefined;
-    }
+  switch (type) {
+    case 'Literal':
+      return obj.value === "" ? undefined : obj.value;
+    case 'TemplateLiteral':
+      return buildTemplateLiteral(obj);
+    case 'Identifier':
+      return obj.name == 'undefined' ? undefined : obj.name;
+    case 'ArrowFunctionExpression':
+    case 'FunctionExpression':
+      return () => void 0;
+    case 'LogicalExpression':
+      const { operator, left, right } = obj;
+      const leftVal = getValue(left);
+      const rightVal = getValue(right);
+
+      return operator == '&&' ? leftVal && rightVal : leftVal || rightVal;
+    case 'MemberExpression':
+      return `${getValue(obj.object)}.${getValue(obj.property)}`;
+    case 'CallExpression':
+      return getValue(obj.callee);
+    default:
+      return undefined;
   }
 
-  return undefined;
 };
@@ -39,0 +44,0 @@

tests/src/rules/img-uses-alt.js

@@ -60,2 +60,6 @@ /**
     { code: '<img alt={photo.caption} />;', parserOptions },
+    { code: '<img alt={bar()} />;', parserOptions },
+    { code: '<img alt={foo.bar || ""} />', parserOptions },
+    { code: '<img alt={bar() || ""} />', parserOptions },
+    { code: '<img alt={foo.bar() || ""} />', parserOptions },
     { code: '<img alt=" " />', parserOptions }, // For decorative images.
@@ -62,0 +66,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

103291

increased by0.37%

Lines of code

2050

increased by0.59%

No dependency changes