eslint-plugin-promise - npm Package Compare versions

Comparing version 4.1.1 to 4.2.1

CHANGELOG.md

@@ -0,1 +1,5 @@
+## 4.2.1
+
+- Added more use cases to `no-return-wrap`
+
 ## 4.0.1
@@ -2,0 +6,0 @@

package.json

 {
   "name": "eslint-plugin-promise",
-  "version": "4.1.1",
+  "version": "4.2.1",
   "description": "Enforce best practices for JavaScript promises",
@@ -5,0 +5,0 @@ "keywords": [

rules/no-return-wrap.js

@@ -13,6 +13,25 @@ /**
 function isInPromise(context) {
-  const expression = context
+  let functionNode = context
     .getAncestors()
-    .filter(node => node.type === 'ExpressionStatement')[0]
-  return expression && expression.expression && isPromise(expression.expression)
+    .filter(node => {
+      return (
+        node.type === 'ArrowFunctionExpression' ||
+        node.type === 'FunctionExpression'
+      )
+    })
+    .reverse()[0]
+  while (
+    functionNode &&
+    functionNode.parent &&
+    functionNode.parent.type === 'MemberExpression' &&
+    functionNode.parent.object === functionNode &&
+    functionNode.parent.property.type === 'Identifier' &&
+    functionNode.parent.property.name === 'bind' &&
+    functionNode.parent.parent &&
+    functionNode.parent.parent.type === 'CallExpression' &&
+    functionNode.parent.parent.callee === functionNode.parent
+  ) {
+    functionNode = functionNode.parent.parent
+  }
+  return functionNode && functionNode.parent && isPromise(functionNode.parent)
 }
@@ -19,0 +38,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

38346

increased by1.7%

Lines of code

911

increased by2.13%

No dependency changes