eslint-plugin-testing-library - npm Package Compare versions

Comparing version 2.2.3 to 3.0.0

lib/index.js

@@ -11,5 +11,8 @@ 'use strict';
   'no-dom-import': require('./rules/no-dom-import'),
-  'no-get-by-for-checking-element-not-present': require('./rules/no-get-by-for-checking-element-not-present'),
   'no-manual-cleanup': require('./rules/no-manual-cleanup'),
+  'no-wait-for-empty-callback': require('./rules/no-wait-for-empty-callback'),
   'prefer-explicit-assert': require('./rules/prefer-explicit-assert'),
+  'prefer-presence-queries': require('./rules/prefer-presence-queries'),
+  'prefer-screen-queries': require('./rules/prefer-screen-queries'),
+  'prefer-wait-for': require('./rules/prefer-wait-for'),
 };
@@ -16,0 +19,0 @@

lib/utils.js

@@ -47,11 +47,12 @@ 'use strict';
 const ALL_QUERIES_COMBINATIONS = [
-  SYNC_QUERIES_COMBINATIONS,
-  ASYNC_QUERIES_COMBINATIONS,
+  ...SYNC_QUERIES_COMBINATIONS,
+  ...ASYNC_QUERIES_COMBINATIONS,
 ];
 
 const ASYNC_UTILS = [
+  'waitFor',
+  'waitForElementToBeRemoved',
   'wait',
   'waitForElement',
   'waitForDomChange',
-  'waitForElementToBeRemoved',
 ];
@@ -58,0 +59,0 @@

package.json

 {
   "name": "eslint-plugin-testing-library",
-  "version": "2.2.3",
+  "version": "3.0.0",
   "description": "ESLint rules for Testing Library",
@@ -5,0 +5,0 @@ "keywords": [

README.md

@@ -26,3 +26,5 @@ <div align="center">
 <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
+
 [![All Contributors](https://img.shields.io/badge/all_contributors-13-orange.svg?style=flat-square)](#contributors-)
+
 <!-- ALL-CONTRIBUTORS-BADGE:END -->
@@ -136,14 +138,17 @@
 
-| Rule                                                                                                | Description                                                                 | Configurations                                                            | Fixable            |
-| --------------------------------------------------------------------------------------------------- | --------------------------------------------------------------------------- | ------------------------------------------------------------------------- | ------------------ |
-| [await-async-query](docs/rules/await-async-query.md)                                                | Enforce async queries to have proper `await`                                | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
-| [await-async-utils](docs/rules/await-async-utils.md)                                                | Enforce async utils to be awaited properly                                  | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
-| [await-fire-event](docs/rules/await-fire-event.md)                                                  | Enforce async fire event methods to be awaited                              | ![vue-badge][]                                                            |                    |
-| [consistent-data-testid](docs/rules/consistent-data-testid.md)                                      | Ensure `data-testid` values match a provided regex.                         |                                                                           |                    |
-| [no-await-sync-query](docs/rules/no-await-sync-query.md)                                            | Disallow unnecessary `await` for sync queries                               | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
-| [no-debug](docs/rules/no-debug.md)                                                                  | Disallow the use of `debug`                                                 | ![angular-badge][] ![react-badge][] ![vue-badge][]                        |                    |
-| [no-dom-import](docs/rules/no-dom-import.md)                                                        | Disallow importing from DOM Testing Library                                 | ![angular-badge][] ![react-badge][] ![vue-badge][]                        | ![fixable-badge][] |
-| [no-get-by-for-checking-element-not-present](docs/rules/no-get-by-for-checking-element-not-present.md) | Disallow the use of `getBy*` queries when checking elements are not present |                                                                           |                    |
-| [no-manual-cleanup](docs/rules/no-manual-cleanup.md)                                                | Disallow the use of `cleanup`                                               |                                                                           |                    |
-| [prefer-explicit-assert](docs/rules/prefer-explicit-assert.md)                                      | Suggest using explicit assertions rather than just `getBy*` queries         |                                                                           |                    |
+| Rule                                                                   | Description                                                            | Configurations                                                            | Fixable            |
+| ---------------------------------------------------------------------- | ---------------------------------------------------------------------- | ------------------------------------------------------------------------- | ------------------ |
+| [await-async-query](docs/rules/await-async-query.md)                   | Enforce async queries to have proper `await`                           | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
+| [await-async-utils](docs/rules/await-async-utils.md)                   | Enforce async utils to be awaited properly                             | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
+| [await-fire-event](docs/rules/await-fire-event.md)                     | Enforce async fire event methods to be awaited                         | ![vue-badge][]                                                            |                    |
+| [consistent-data-testid](docs/rules/consistent-data-testid.md)         | Ensure `data-testid` values match a provided regex.                    |                                                                           |                    |
+| [no-await-sync-query](docs/rules/no-await-sync-query.md)               | Disallow unnecessary `await` for sync queries                          | ![recommended-badge][] ![angular-badge][] ![react-badge][] ![vue-badge][] |                    |
+| [no-debug](docs/rules/no-debug.md)                                     | Disallow the use of `debug`                                            | ![angular-badge][] ![react-badge][] ![vue-badge][]                        |                    |
+| [no-dom-import](docs/rules/no-dom-import.md)                           | Disallow importing from DOM Testing Library                            | ![angular-badge][] ![react-badge][] ![vue-badge][]                        | ![fixable-badge][] |
+| [no-manual-cleanup](docs/rules/no-manual-cleanup.md)                   | Disallow the use of `cleanup`                                          |                                                                           |                    |
+| [no-wait-for-empty-callback](docs/rules/no-wait-for-empty-callback.md) | Disallow empty callbacks for `waitFor` and `waitForElementToBeRemoved` |                                                                           |                    |
+| [prefer-explicit-assert](docs/rules/prefer-explicit-assert.md)         | Suggest using explicit assertions rather than just `getBy*` queries    |                                                                           |                    |
+| [prefer-presence-queries](docs/rules/prefer-presence-queries.md)       | Enforce specific queries when checking element is present or not       |                                                                           |                    |
+| [prefer-screen-queries](docs/rules/prefer-screen-queries.md)           | Suggest using screen while using queries                               |                                                                           |                    |
+| [prefer-wait-for](docs/rules/prefer-wait-for.md)                       | Use `waitFor` instead of deprecated wait methods                       |                                                                           | ![fixable-badge][] |
 
@@ -199,4 +204,5 @@ [build-badge]: https://img.shields.io/travis/testing-library/eslint-plugin-testing-library?style=flat-square
 <!-- prettier-ignore-end -->
+
 <!-- ALL-CONTRIBUTORS-LIST:END -->
 
 This project follows the [all-contributors](https://github.com/all-contributors/all-contributors) specification. Contributions of any kind welcome!

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53464

increased by15.59%

Number of package files

18

increased by20%

Lines of code

1140

increased by21.54%

Number of lines in readme file

206

increased by3%

No dependency changes