eslint-release - npm Package Compare versions

Comparing version 1.0.0 to 1.1.0

CHANGELOG.md

@@ -0,1 +1,6 @@
+v1.1.0 - October 17, 2018
+
+* 34d6f55 Update: avoid unnecessary checks for environment variables (#29) (Teddy Katz)
+* 5c5c361 Fix: avoid overwriting the .npmrc file in a repository (#30) (Teddy Katz)
+
 v1.0.0 - October 17, 2018
@@ -2,0 +7,0 @@

lib/release-ops.js

@@ -65,4 +65,9 @@ /**
     }
+}
 
-    // check NPM_TOKEN
+/**
+ * Verify that the appropriate credentials are present before publishing a release
+ * @returns {void}
+ */
+function validateEnvironment() {
     if (!process.env.NPM_TOKEN) {
@@ -324,5 +329,2 @@ console.error("Missing NPM_TOKEN environment variable");
 
-    // Release needs a .npmrc file to work properly - token is read from environment
-    console.log("Writing .npmrc file");
-    fs.writeFileSync(".npmrc", "//registry.npmjs.org/:_authToken=${NPM_TOKEN}");
     fs.writeFileSync(".eslint-release-info.json", JSON.stringify(releaseInfo, null, 4));
@@ -365,4 +367,16 @@ }
     validateSetup();
+    validateEnvironment();
     var releaseInfo = JSON.parse(fs.readFileSync(".eslint-release-info.json", "utf8"));
 
+    var oldNpmrcContents;
+    if (fs.existsSync(".npmrc")) {
+        oldNpmrcContents = fs.readFileSync(".npmrc", "utf8");
+    } else {
+        oldNpmrcContents = null;
+    }
+
+    // Release needs a .npmrc file to work properly - token is read from environment
+    console.log("Writing .npmrc file");
+    fs.writeFileSync(".npmrc", "//registry.npmjs.org/:_authToken=${NPM_TOKEN}");
+
     // if there's a prerelease ID, publish under "next" tag
@@ -382,2 +396,8 @@ console.log("Publishing to npm");
 
+    if (oldNpmrcContents === null) {
+        fs.unlinkSync(".npmrc");
+    } else {
+        fs.writeFileSync(".npmrc", oldNpmrcContents);
+    }
+
     console.log("Publishing to git");
@@ -384,0 +404,0 @@ ShellOps.exec("git push origin master --tags");

package.json

 {
   "name": "eslint-release",
-  "version": "1.0.0",
+  "version": "1.1.0",
   "description": "ESLint Release Tools",
@@ -5,0 +5,0 @@ "main": "./lib/release-ops",

No alert changes

Improved metrics

Total package byte prevSize

31767

2.15%

Lines of code

490

3.59%

No dependency changes