exec-buffer - npm Package Compare versions

Comparing version 1.1.2 to 2.0.0

index.js

@@ -11,13 +11,10 @@ 'use strict';
  *
- * @param {Object} opts
  * @api public
  */
 
-function ExecBuffer(opts) {
+function ExecBuffer() {
 	if (!(this instanceof ExecBuffer)) {
-		return new ExecBuffer(opts);
+		return new ExecBuffer();
 	}
 
-	this.opts = opts || {};
-	this.opts.stderr = this.opts.stderr !== false;
 	this.src(tempfile());
@@ -98,7 +95,2 @@ this.dest(tempfile());
 
-			if (self.opts.stderr && stderr) {
-				cb(stderr);
-				return;
-			}
-
 			fs.readFile(dest, function (err, data) {
@@ -110,3 +102,3 @@ if (err) {
 
-				rm(src, function (err) {
+				self.clean(function (err) {
 					if (err) {
@@ -117,10 +109,3 @@ cb(err);
 
-					rm(dest, function (err) {
-						if (err) {
-							cb(err);
-							return;
-						}
-
-						cb(null, data);
-					});
+					cb(null, data, stderr);
 				});
@@ -133,2 +118,30 @@ });
 /**
+ * Cleanup temporary files
+ *
+ * @param {Function} cb
+ * @api private
+ */
+
+ExecBuffer.prototype.clean = function (cb) {
+	var src = this.src();
+	var dest = this.dest();
+
+	rm(src, function (err) {
+		if (err) {
+			cb(err);
+			return;
+		}
+
+		rm(dest, function (err) {
+			if (err) {
+				cb(err);
+				return;
+			}
+
+			cb();
+		});
+	});
+};
+
+/**
  * Module exports
@@ -135,0 +148,0 @@ */

package.json

 {
   "name": "exec-buffer",
-  "version": "1.1.2",
+  "version": "2.0.0",
   "description": "Run a buffer through a child process",
@@ -31,4 +31,4 @@ "license": "MIT",
     "ava": "^0.0.4",
-    "gifsicle": "^1.0.2"
+    "gifsicle": "^2.0.0"
   }
 }

README.md

@@ -1,2 +0,2 @@
-# exec-buffer [![Build Status](https://travis-ci.org/kevva/exec-buffer.svg?branch=master)](https://travis-ci.org/kevva/exec-buffer)
+# exec-buffer [![Build Status](http://img.shields.io/travis/kevva/exec-buffer.svg?style=flat)](https://travis-ci.org/kevva/exec-buffer)
 
@@ -20,5 +20,4 @@ > Run a Buffer through a child process
 
-execBuffer
-	.use(gifsicle, ['-o', execBuffer.dest(), execBuffer.src()])
-	.run(fs.readFileSync('test.gif'), function (err, data) {
+execBuffer.use(gifsicle, ['-o', execBuffer.dest(), execBuffer.src()]);
+execBuffer.run(fs.readFileSync('test.gif'), function (err, data) {
 		if (err) {
@@ -36,8 +35,6 @@ throw err;
 
-### new ExecBuffer(opts)
+### new ExecBuffer()
 
-Creates a new `ExecBuffer` instance. Available options are:
+Creates a new `ExecBuffer` instance.
 
-* `stderr`: Whether to add `stderr` output to `err` in the callback. Defaults to `true`.
-
 ### .use(bin, args)
@@ -44,0 +41,0 @@

No alert changes

Improved metrics

Lines of code

119

9.17%

Worsened metrics

Total package byte prevSize

3900

-0.79%

Number of lines in readme file

81

-3.57%

No dependency changes