factorial-pixel - npm Package Compare versions

Comparing version 0.4.0 to 0.5.0

__tests__/pixelUrl.spec.js

@@ -13,6 +13,6 @@ import pixelUrl from '../src/pixelUrl'
         url: 'https://factorialhr.com/blog?mc=123',
-        referrer: 'https://google.com'
+        referrer: 'https://google.com?query=cómo hacer nóminas'
       })
       expect(pixelUrl(dom.window.document))
-        .toEqual('https://factorialhr.com/internal/pixel?mc=123&referer=https://google.com/&language=en&landing_page=https://factorialhr.com/blog')
+        .toEqual('https://factorialhr.com/internal/pixel?mc=123&referer=https://google.com/?query=c%25C3%25B3mo%2520hacer%2520n%25C3%25B3minas&language=en&landing_page=https://factorialhr.com/blog')
     })
@@ -19,0 +19,0 @@ })

__tests__/requestParameters.spec.js

@@ -6,4 +6,4 @@ import requestParameters from '../src/requestParameters'
 const dom = new JSDOM(html, {
-  url: 'https://factorialhr.com',
-  referrer: 'https://google.com'
+  url: 'https://factorialhr.com/team/césar',
+  referrer: 'https://google.com?query=cómo hacer nóminas'
 })
@@ -14,3 +14,3 @@
     expect(requestParameters(dom.window.document)).toEqual({
-      landingPage: 'https://factorialhr.com/',
+      landingPage: 'https://factorialhr.com/team/c%25C3%25A9sar',
       language: 'en'
@@ -17,0 +17,0 @@ })

build/app.js

@@ -113,3 +113,3 @@ var factorialPixel =
   var mc = document.location.href.match(/mc=(.*)/);
-  var attributes = ['mc=' + (mc ? mc[1] : ''), 'referer=' + document.referrer, 'language=' + language, 'landing_page=' + landingPage].join('&'
+  var attributes = ['mc=' + (mc ? mc[1] : ''), 'referer=' + encodeURI(document.referrer), 'language=' + language, 'landing_page=' + landingPage].join('&'
 
@@ -133,3 +133,3 @@ // We need to set the cookie to the app domain, so we see it everywhere.
 function requestParameters(document) {
-  var landing = document.location.href.split('?')[0];
+  var landing = encodeURI(document.location.href.split('?')[0]);
   var locale = document.querySelector('html').lang.split('-')[0];
@@ -136,0 +136,0 @@

coverage/coverage-final.json

 {"/Users/pauramonrevilla/Sites/factorial-pixel/src/index.js": {"path":"/Users/pauramonrevilla/Sites/factorial-pixel/src/index.js","statementMap":{"0":{"start":{"line":1,"column":29},"end":{"line":1,"column":50}},"1":{"start":{"line":1,"column":68},"end":{"line":1,"column":101}},"2":{"start":{"line":1,"column":140},"end":{"line":1,"column":194}},"3":{"start":{"line":3,"column":10},"end":{"line":3,"column":39}},"4":{"start":{"line":4,"column":0},"end":{"line":4,"column":44}},"5":{"start":{"line":5,"column":0},"end":{"line":5,"column":14}},"6":{"start":{"line":6,"column":0},"end":{"line":6,"column":15}},"7":{"start":{"line":7,"column":0},"end":{"line":7,"column":28}},"8":{"start":{"line":8,"column":0},"end":{"line":8,"column":31}}},"fnMap":{"0":{"name":"_interopRequireDefault","decl":{"start":{"line":1,"column":111},"end":{"line":1,"column":133}},"loc":{"start":{"line":1,"column":139},"end":{"line":1,"column":195}},"line":1}},"branchMap":{"0":{"loc":{"start":{"line":1,"column":147},"end":{"line":1,"column":193}},"type":"cond-expr","locations":[{"start":{"line":1,"column":171},"end":{"line":1,"column":174}},{"start":{"line":1,"column":177},"end":{"line":1,"column":193}}],"line":1},"1":{"loc":{"start":{"line":1,"column":147},"end":{"line":1,"column":168}},"type":"binary-expr","locations":[{"start":{"line":1,"column":147},"end":{"line":1,"column":150}},{"start":{"line":1,"column":154},"end":{"line":1,"column":168}}],"line":1}},"s":{"0":0,"1":0,"2":0,"3":0,"4":0,"5":0,"6":0,"7":0,"8":0},"f":{"0":0},"b":{"0":[0,0],"1":[0,0]}}
 ,"/Users/pauramonrevilla/Sites/factorial-pixel/src/pixelUrl.js": {"path":"/Users/pauramonrevilla/Sites/factorial-pixel/src/pixelUrl.js","statementMap":{"0":{"start":{"line":4,"column":36},"end":{"line":4,"column":63}},"1":{"start":{"line":5,"column":13},"end":{"line":5,"column":52}},"2":{"start":{"line":6,"column":21},"end":{"line":11,"column":13}},"3":{"start":{"line":14,"column":20},"end":{"line":14,"column":87}},"4":{"start":{"line":15,"column":2},"end":{"line":15,"column":52}}},"fnMap":{"0":{"name":"(anonymous_0)","decl":{"start":{"line":3,"column":15},"end":{"line":3,"column":16}},"loc":{"start":{"line":3,"column":29},"end":{"line":16,"column":1}},"line":3}},"branchMap":{"0":{"loc":{"start":{"line":7,"column":10},"end":{"line":7,"column":25}},"type":"cond-expr","locations":[{"start":{"line":7,"column":15},"end":{"line":7,"column":20}},{"start":{"line":7,"column":23},"end":{"line":7,"column":25}}],"line":7}},"s":{"0":2,"1":2,"2":2,"3":2,"4":2},"f":{"0":2},"b":{"0":[1,1]},"_coverageSchema":"332fd63041d2c1bcb487cc26dd0d5f7d97098a6c","hash":"d30c5ad53501107339913770b46800ce690ccde9"}
-,"/Users/pauramonrevilla/Sites/factorial-pixel/src/requestParameters.js": {"path":"/Users/pauramonrevilla/Sites/factorial-pixel/src/requestParameters.js","statementMap":{"0":{"start":{"line":2,"column":18},"end":{"line":2,"column":54}},"1":{"start":{"line":3,"column":17},"end":{"line":3,"column":66}},"2":{"start":{"line":5,"column":2},"end":{"line":8,"column":3}}},"fnMap":{"0":{"name":"requestParameters","decl":{"start":{"line":1,"column":24},"end":{"line":1,"column":41}},"loc":{"start":{"line":1,"column":53},"end":{"line":9,"column":1}},"line":1}},"branchMap":{},"s":{"0":3,"1":3,"2":3},"f":{"0":3},"b":{},"_coverageSchema":"332fd63041d2c1bcb487cc26dd0d5f7d97098a6c","hash":"de5372e174041251d52be76bd23fcc1c64eb8569"}
+,"/Users/pauramonrevilla/Sites/factorial-pixel/src/requestParameters.js": {"path":"/Users/pauramonrevilla/Sites/factorial-pixel/src/requestParameters.js","statementMap":{"0":{"start":{"line":2,"column":18},"end":{"line":2,"column":65}},"1":{"start":{"line":3,"column":17},"end":{"line":3,"column":66}},"2":{"start":{"line":5,"column":2},"end":{"line":8,"column":3}}},"fnMap":{"0":{"name":"requestParameters","decl":{"start":{"line":1,"column":24},"end":{"line":1,"column":41}},"loc":{"start":{"line":1,"column":53},"end":{"line":9,"column":1}},"line":1}},"branchMap":{},"s":{"0":3,"1":3,"2":3},"f":{"0":3},"b":{},"_coverageSchema":"332fd63041d2c1bcb487cc26dd0d5f7d97098a6c","hash":"fc4c981859b0267c8aecf80a6a3d358c733c56de"}
 }

package.json

 {
   "name": "factorial-pixel",
-  "version": "0.4.0",
+  "version": "0.5.0",
   "description": "Factorial marketing pixel",
@@ -5,0 +5,0 @@ "repository": {

No alert changes

Improved metrics

Total package byte prevSize

236109

increased by0.07%

No dependency changes