fetch-retry - npm Package Compare versions

Comparing version 0.0.4 to 0.0.5

index.js

 'use strict';
 var fetch = require('isomorphic-fetch');
-var Promise = require("bluebird");
+var Promise = require('bluebird');
 
@@ -10,4 +10,4 @@ module.exports = function(url, options) {
   if (options && options.retries) {
-    retries = options.retries
-  };
+    retries = options.retries;
+  }
 
@@ -29,5 +29,5 @@ return new Promise(function(resolve, reject) {
         });
-    }
+    };
     wrappedFetch(retries);
   });
 };

package.json

 {
   "name": "fetch-retry",
-  "version": "0.0.4",
+  "version": "0.0.5",
   "description": "Fetch API with retry functionality",
@@ -5,0 +5,0 @@ "repository": "https://github.com/jonbern/fetch-retry.git",

tests.js

@@ -5,18 +5,18 @@ 'use strict';
 var expect = require('expectations');
-var Promise = require("bluebird");
+var Promise = require('bluebird');
 
 describe('fetch-retry', function() {
 
-  let fetchRetry;
-  let fetch;
+  var fetchRetry;
+  var fetch;
 
-  let deferred1;
-  let deferred2;
-  let deferred3;
-  let deferred4;
+  var deferred1;
+  var deferred2;
+  var deferred3;
+  var deferred4;
 
-  let thenCallback;
-  let catchCallback;
+  var thenCallback;
+  var catchCallback;
 
-  let _setTimeout;
+  var _setTimeout;
 
@@ -26,3 +26,3 @@ beforeEach(function() {
 
-    setTimeout = function(callback, delay) {
+    setTimeout = function(callback) {
       callback();
@@ -34,3 +34,3 @@ };
   afterEach(function() {
-    setTimeout = _setTimeout
+    setTimeout = _setTimeout;
   });
@@ -50,3 +50,3 @@
 
-    let stubs = {
+    var stubs = {
       'isomorphic-fetch': fetch
@@ -59,8 +59,8 @@ };
 
-  describe("#url", function() {
+  describe('#url', function() {
 
-    let expectedUrl = 'http://some-url.com';
+    var expectedUrl = 'http://some-url.com';
 
     beforeEach(function() {
-      fetchRetry(expectedUrl)
+      fetchRetry(expectedUrl);
     });
@@ -74,5 +74,5 @@
 
-  describe("#options", function() {
+  describe('#options', function() {
 
-    let expectedOptions = {
+    var expectedOptions = {
       retries: 3,
@@ -177,42 +177,40 @@ whatever: 'something'
 
+          beforeEach(function() {
+            deferred3.reject();
+          });
+
+          describe('when fourth call is a success', function() {
+
             beforeEach(function() {
-              deferred3.reject();
+              deferred4.resolve();
             });
 
-            describe('when fourth call is a success', function() {
+            describe('when resolved', function() {
 
-              beforeEach(function() {
-                deferred4.resolve();
+              it('invokes the then callback', function() {
+                expect(thenCallback.called).toBe(true);
               });
 
-              describe('when resolved', function() {
+              it('calls fetch four times', function() {
+                expect(fetch.callCount).toBe(4);
+              });
 
-                it('invokes the then callback', function() {
-                  expect(thenCallback.called).toBe(true);
-                });
+            });
 
-                it('calls fetch four times', function() {
-                  expect(fetch.callCount).toBe(4);
-                });
+          });
 
-              });
+          describe('when fourth call is a failure', function() {
 
+            beforeEach(function() {
+              deferred4.reject();
             });
 
-            describe('when fourth call is a failure', function() {
+            describe('when rejected', function() {
 
-              beforeEach(function() {
-                deferred4.reject();
+              it('invokes the catch callback', function() {
+                expect(catchCallback.called).toBe(true);
               });
 
-              describe('when rejected', function() {
-
-                it('invokes the catch callback', function() {
-                  expect(catchCallback.called).toBe(true);
-                });
-
-                it('does not call fetch again', function() {
-                  expect(fetch.callCount).toBe(4);
-                });
-
+              it('does not call fetch again', function() {
+                expect(fetch.callCount).toBe(4);
               });
@@ -222,2 +220,4 @@
 
+          });
+
         });
@@ -315,12 +315,12 @@
 function defer() {
-    var resolve, reject;
-    var promise = new Promise(function() {
-        resolve = arguments[0];
-        reject = arguments[1];
-    });
-    return {
-        resolve: resolve,
-        reject: reject,
-        promise: promise
-    };
+  var resolve, reject;
+  var promise = new Promise(function() {
+    resolve = arguments[0];
+    reject = arguments[1];
+  });
+  return {
+    resolve: resolve,
+    reject: reject,
+    promise: promise
+  };
 }

No alert changes

Improved metrics

Total package byte prevSize

10314

increased by1.17%

Number of package files

7

increased by16.67%

No dependency changes