firebaseoauth2 - npm Package Compare versions

Comparing version 0.4.0 to 0.4.1

index.js

@@ -82,8 +82,11 @@ const express = require("express");
 
-  let response_type = req.query.response_type;
-  let client_id = req.query.client_id;
-  let redirect_uri = req.query.redirect_uri;
-  let scope = req.query.scope;
-  let state = req.query.state;
-
+  const response_type = req.query.response_type;　// 必須
+  const client_id = req.query.client_id;          // 必須
+  const redirect_uri = req.query.redirect_uri;    // 条件付き必須
+  const scope = req.query.scope;
+  let state = ''
+  if(req.query.state){
+    state = req.query.state
+  }
+  
   res.render("userAuthorize", {
@@ -108,4 +111,34 @@ title: "Hey",
   let response_type = req.body.response_type   // 必須
+  if(!response_type || response_type != 'code'){
+    // レスポンスタイプ は code に限定する
+    // unsupported_response_type
+    res.json({
+        status : 'error',
+        url : redirect_uri + '?error=unsupported_response_type&state=' + state
+      })
+    return
+  }
+
   let client_id = req.body.client_id           // 必須
-  let redirect_uri = req.body.redirect_uri     // 必須
+  if(!client_id){
+    // クライアント識別子が不正
+    // invalid_client
+    res.json({
+        status : 'error',
+        url : redirect_uri + '?error=invalid_client&state=' + state
+      })
+    return
+  }
+
+  let redirect_uri = req.body.redirect_uri     // 条件付き必須
+  if(!redirect_uri){
+    // クライアントと認可サーバ間で事前にリダイレクト先の URI が決められていない場合は必須
+    // redirect_uri_mismatch
+    res.json({
+        status : 'error',
+        url : redirect_uri + '?error=redirect_uri_mismatch=' + state
+      })
+    return
+  }
+
   let scope = req.body.scope;
@@ -235,2 +268,3 @@ let state = req.body.state;
         // 削除に成功した / 存在しなかった
+        /* To-Do : ビルドインの redirect_uri は固定だろう */
         FirebaseDb.ref('/oAuth/users/' + uid + '/' + client_id).set({
@@ -496,3 +530,3 @@ scope : scope,
   console.log('getClientByRefreshToken', refresh_token)
-  const ref = FirebaseDb.ref('/oAuth/RefreshTokens/' + refresh_token)
+  const ref = FirebaseDb.ref('/oAuth/tokens/RefreshTokens/' + refresh_token)
   return getClientByRef(ref)
@@ -499,0 +533,0 @@ }

package.json

 {
   "name": "firebaseoauth2",
-  "version": "0.4.0",
+  "version": "0.4.1",
   "description": "",
@@ -5,0 +5,0 @@ "main": "indexjs.js",

No alert changes

Improved metrics

Total package byte prevSize

16644

6.73%

Lines of code

517

6.38%

No dependency changes