firescript-linter - npm Package Compare versions

Comparing version 0.6.4 to 0.6.5

examples/lint.js

@@ -6,2 +6,2 @@ const testAST = require('./banana.json')
 const result = linter.lint(testAST)
-console.log(result)
+console.log(JSON.stringify(result, null, '  '))

package.json

 {
   "name": "firescript-linter",
-  "version": "0.6.4",
+  "version": "0.6.5",
   "description": "Linter for Firescript",
   "main": "app.js",
   "scripts": {
-    "test": "firetest run",
+    "test": "npm run test:unit && npm run test:integration",
     "test:unit": "firetest run tests/unit/**/*.test.*",
+    "test:integration": "firetest run tests/integration/**/*.test.*",
     "lint": "eslint src/**/*.js"
@@ -19,10 +20,10 @@ },
   "devDependencies": {
-    "@noname-media/eslint-config-standard": "^1.1.2",
+    "@noname-media/eslint-config-standard": "^1.1.3",
     "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-standard": "^4.0.1",
-    "firescript": "^0.14.8",
-    "firescript-parser": "^0.3.4",
-    "firescript-syntax-test": "0.0.2",
-    "firescript-test": "^0.10.5",
+    "eslint-plugin-standard": "^5.0.0",
+    "firescript": "^0.15.3",
+    "firescript-parser": "^0.5.1",
+    "firescript-syntax-test": "^0.1.0",
+    "firescript-test": "^0.10.9",
     "git-hooks": "^1.1.10",
@@ -29,0 +30,0 @@ "inspect.js": "^1.12.4"

src/LinterNode.js

@@ -18,2 +18,3 @@ const colorfy = require('colorfy')
   lintNode (ast, ...args) {
+    this.debug('Lint', ast.type, ast.line, ast.column)
     const Node = require(`./nodes/${ast.type}.js`)[ast.type]
@@ -109,2 +110,3 @@ const node = new Node(this.session, this, ast.type, ...args)
   lintException (exception) {
+    this.debug('Lint exception:', exception)
     this.session.exceptions.push(exception)
@@ -111,0 +113,0 @@ }

src/nodes/CallExpression.js

@@ -51,2 +51,7 @@ const { LinterNode } = require('../LinterNode')
           }
+        } else if (argument.type === 'CallExpression') {
+          // Argument is a variable0
+          if (!this.isScopeVar(argument.callee.name)) {
+            this.lintException(new VariableNotDeclared(argument, argument.callee.name))
+          }
         } else {
@@ -53,0 +58,0 @@ this.debug('TODO: implement param typing for', argument.type)

src/nodes/TemplateLiteral.js

@@ -5,3 +5,3 @@ const LinterNode = require('../LinterNode').LinterNode
   lint (ast) {
-    // this.lintNode(ast.argument)
+    this.lintNode(ast.expressions)
     this.debug('TODO: implement callee linting', this.type)
@@ -8,0 +8,0 @@ }

src/nodes/VariableDeclaration.js

@@ -13,7 +13,9 @@ const { LinterNode } = require('../LinterNode')
         }
+
+        this.lintNode(declaration)
+      } else if (declaration.id.type === 'ArrayPattern') {
+        this.lintNode(declaration)
       } else {
         this.debug(`Handle ${declaration.id.type} in VariableDeclarations`)
       }
-
-      this.lintNode(declaration)
     })
@@ -20,0 +22,0 @@ }

src/nodes/VariableDeclarator.js

@@ -7,3 +7,3 @@ const { LinterNode } = require('../LinterNode')
   lint (ast) {
-    if (ast.init.type === 'Identifier') {
+    if (ast.init && ast.init.type === 'Identifier') {
       // Argument is a variable
@@ -13,8 +13,16 @@ if (!this.isScopeVar(ast.init.name)) {
       }
-    }
 
-    // check variable typing
-    const scopeVar = this.getScopeVar(ast.id.name)
-    if (!this.validateNodeTyping(ast.init, scopeVar.type)) {
-      this.lintException(new VariableTypingError(ast.init, scopeVar))
+      // check variable typing
+      const scopeVar = this.getScopeVar(ast.id.name)
+      if (!this.validateNodeTyping(ast.init, scopeVar.type)) {
+        this.lintException(new VariableTypingError(ast.init, scopeVar))
+      }
+    } else if (ast.init && ast.init.type === 'Literal') {
+      // check value typing
+      const scopeVar = this.getScopeVar(ast.id.name)
+      if (!this.validateNodeTyping(ast.init, scopeVar.type)) {
+        this.lintException(new VariableTypingError(ast.init, scopeVar))
+      }
+    } else {
+      this.debug(`Handle ${ast.init.type} in VariableDeclarator`)
     }
@@ -21,0 +29,0 @@

tests/unit/LinterNodeTest.test.js

 const LinterNode = require('../../src/LinterNode').LinterNode
+const inspect = require('inspect.js')
 
@@ -3,0 +4,0 @@ class LinterNodeTest {

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

No README

Quality

Package does not have a README. This may indicate a failed publish or a low quality package.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

59532

increased by3.67%

Number of package files

146

increased by2.1%

Lines of code

1768

increased by1.67%

Number of medium quality alerts

1

decreased by-50%

Number of lines in readme file

43

increased byInfinity%

No dependency changes