fx-runner - npm Package Compare versions

Comparing version 1.3.0 to 1.4.0

lib/utils.js

@@ -56,3 +56,5 @@ /* This Source Code Form is subject to the terms of the Mozilla Public
       // On OSX, if given the app path, resolve to the actual binary
-      binaryPath = isAppPath ? path.join(binaryPath, "Contents/MacOS/firefox-bin") :
+      // We use `firefox` since `firefox-bin` is gone thanks to
+      // https://bugzilla.mozilla.org/show_bug.cgi?id=1871447
+      binaryPath = isAppPath ? path.join(binaryPath, "Contents/MacOS/firefox") :
                    binaryPath;
@@ -117,8 +119,8 @@
 normalizeBinary.paths = {
-  "firefox on osx": "/Applications/Firefox.app/Contents/MacOS/firefox-bin",
+  "firefox on osx": "/Applications/Firefox.app/Contents/MacOS/firefox",
   // the name of the beta application bundle is the same as the stable one
-  "beta on osx": "/Applications/Firefox.app/Contents/MacOS/firefox-bin",
-  "firefoxdeveloperedition on osx": "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox-bin",
-  "aurora on osx": "/Applications/FirefoxAurora.app/Contents/MacOS/firefox-bin",
-  "nightly on osx": "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin",
+  "beta on osx": "/Applications/Firefox.app/Contents/MacOS/firefox",
+  "firefoxdeveloperedition on osx": "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox",
+  "aurora on osx": "/Applications/FirefoxAurora.app/Contents/MacOS/firefox",
+  "nightly on osx": "/Applications/Firefox Nightly.app/Contents/MacOS/firefox",
 };
@@ -125,0 +127,0 @@

package.json

 {
   "name": "fx-runner",
-  "version": "1.3.0",
+  "version": "1.4.0",
   "description": "A node cli to control Firefox",
@@ -5,0 +5,0 @@ "main": "index.js",

test/run/test.utils.js

@@ -150,4 +150,4 @@ /* This Source Code Form is subject to the terms of the Mozilla Public
     var promises = [
-      [[null, "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"],
-      [[null, "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"]
+      [[null, "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox"],
+      [[null, "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox"]
     ].map(function(fixture) {
@@ -198,3 +198,3 @@ var promise = binary.apply(binary, fixture[args]);
       expect(actual).to.be.equal(
-        path.join("/Application/FirefoxNightly.app/Contents/MacOS/firefox-bin"));
+        path.join("/Application/FirefoxNightly.app/Contents/MacOS/firefox"));
     }).then(done.bind(null, null), done);
@@ -292,19 +292,19 @@ });
     var promises = [
-      [["firefox", "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"],
-      [["firefox", "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"],
+      [["firefox", "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox"],
+      [["firefox", "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox"],
 
-      [["beta", "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"],
-      [["beta", "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox-bin"],
+      [["beta", "darwin", "x86"], "/Applications/Firefox.app/Contents/MacOS/firefox"],
+      [["beta", "darwin", "x86_64"], "/Applications/Firefox.app/Contents/MacOS/firefox"],
 
-      [["firefoxdeveloperedition", "darwin", "x86"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox-bin"],
-      [["firefoxdeveloperedition", "darwin", "x86_64"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox-bin"],
+      [["firefoxdeveloperedition", "darwin", "x86"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox"],
+      [["firefoxdeveloperedition", "darwin", "x86_64"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox"],
 
-      [["deved", "darwin", "x86"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox-bin"],
-      [["deved", "darwin", "x86_64"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox-bin"],
+      [["deved", "darwin", "x86"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox"],
+      [["deved", "darwin", "x86_64"], "/Applications/Firefox Developer Edition.app/Contents/MacOS/firefox"],
 
-      [["aurora", "darwin", "x86"], "/Applications/FirefoxAurora.app/Contents/MacOS/firefox-bin"],
-      [["aurora", "darwin", "x86_64"], "/Applications/FirefoxAurora.app/Contents/MacOS/firefox-bin"],
+      [["aurora", "darwin", "x86"], "/Applications/FirefoxAurora.app/Contents/MacOS/firefox"],
+      [["aurora", "darwin", "x86_64"], "/Applications/FirefoxAurora.app/Contents/MacOS/firefox"],
 
-      [["nightly", "darwin", "x86"], "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin"],
-      [["nightly", "darwin", "x86_64"], "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin"]
+      [["nightly", "darwin", "x86"], "/Applications/Firefox Nightly.app/Contents/MacOS/firefox"],
+      [["nightly", "darwin", "x86_64"], "/Applications/Firefox Nightly.app/Contents/MacOS/firefox"]
     ].map(function (fixture) {
@@ -321,3 +321,3 @@ var promise = binary.apply(binary, fixture[args]);
 
-    var defaultNightly = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin";
+    var defaultNightly = "/Applications/Firefox Nightly.app/Contents/MacOS/firefox";
 
@@ -345,3 +345,3 @@ function spawnSyncStub(stdout) {
         spawnSync: spawnSyncStub([
-          "/src/mozilla-central/Nightly.app/Contents/MacOS/firefox-bin",
+          "/src/mozilla-central/Nightly.app/Contents/MacOS/firefox",
           defaultNightly,
@@ -354,3 +354,3 @@ ].join("\n")),
     it("falls back to the first app result", function() {
-      var randomApp = "/src/mozilla-central/Nightly.app/Contents/MacOS/firefox-bin";
+      var randomApp = "/src/mozilla-central/Nightly.app/Contents/MacOS/firefox";
       var result = utils.findMacAppByChannel("nightly", {
@@ -357,0 +357,0 @@ spawnSync: spawnSyncStub(randomApp + "\n"),

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

53764

increased by0.24%

Worsened metrics

Lines of code

729

decreased by-0.41%

No dependency changes