gofer - npm Package Compare versions

Comparing version 3.5.6 to 3.5.7

CHANGELOG.md

@@ -0,1 +1,7 @@
+### 3.5.7
+
+* clear completionTimer on response completion - **[@dbushong](https://github.com/dbushong)** [#84](https://github.com/groupon/gofer/pull/84)
+  - [`368d061`](https://github.com/groupon/gofer/commit/368d061c7d6cdd90d795113940c70b081db88ecc) **fix:** clear completionTimer on response completion
+
+
 ### 3.5.6
@@ -2,0 +8,0 @@

lib/request.js

@@ -162,2 +162,7 @@ /*
 
+  function clearCompletionTimer() {
+    clearIOTimeout(completionTimer);
+    completionTimer = null;
+  }
+
   function failAndAbort(error) {
@@ -169,4 +174,3 @@ debug('<- %s %s', error.code || error.statusCode, fullUrl);
     responseTimer = null;
-    clearIOTimeout(completionTimer);
-    completionTimer = null;
+    clearCompletionTimer();
     clearImmediateSafe(socketTimer);
@@ -224,2 +228,3 @@ socketTimer = null;
     resObj.on('error', failAndAbort);
+    resObj.on('end', clearCompletionTimer);
 
@@ -293,3 +298,6 @@ if (!isAcceptableStatus(res.statusCode)) {
     if (options.completionTimeout > 0) {
-      setIOTimeout(onCompletionTimedOut, options.completionTimeout);
+      completionTimer = setIOTimeout(
+        onCompletionTimedOut,
+        options.completionTimeout
+      );
     }
@@ -296,0 +304,0 @@

package.json

 {
   "name": "gofer",
-  "version": "3.5.6",
+  "version": "3.5.7",
   "description": "A general purpose service client library",
@@ -5,0 +5,0 @@ "license": "BSD-3-Clause",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

63942

increased by0.73%

Lines of code

1291

increased by0.55%

No dependency changes