hapi-good-mongostore - npm Package Compare versions

Comparing version 0.3.5 to 0.4.0

lib/index.js

@@ -6,2 +6,3 @@ 'use strict'
 const get = require('lodash.get')
+const safeJson = require('./safe-json')
 
@@ -76,6 +77,6 @@ /**
     if (this.conn.db) {
-      return this.conn.collection.insertMany(records, this.insertOptions || {})
+      return this.conn.collection.insertMany(safeJson(records), this.insertOptions || {})
     } else {
       return this._connect()
-        .then(() => this.conn.collection.insertMany(records, this.insertOptions || {}))
+        .then(() => this.conn.collection.insertMany(safeJson(records), this.insertOptions || {}))
     }
@@ -82,0 +83,0 @@ }

package.json

 {
   "name": "hapi-good-mongostore",
-  "version": "0.3.5",
+  "version": "0.4.0",
   "repository": {
@@ -36,2 +36,3 @@ "type": "git",
   "dependencies": {
+    "circular-json": "^0.3.1",
     "lodash.get": "^4.4.2",
@@ -38,0 +39,0 @@ "mongodb": "^2.2.26"

test/index.js

@@ -0,1 +1,3 @@
+'use strict'
+
 const should = require('should')
@@ -82,2 +84,26 @@ const Stream = require('stream')
   })
+
+  describe('handle circular json', () => {
+    it('Should safely parse circular json', (done) => {
+      const circularObj = { foo: 'bar' }
+      circularObj.self = circularObj
+      const record = {
+        tags: ['error'],
+        data: circularObj
+      }
+
+      const options = { batchSize: 1 }
+      const reporter = new MongoStoreStream(url, options)
+      const stream = readStream()
+      stream.pipe(reporter)
+
+      reporter._insert = function (records) {
+        should(records.length).be.equal(options.batchSize)
+        should(records[0]).be.equal(record)
+        done()
+      }
+
+      stream.push(record)
+    })
+  })
 })

No alert changes

Improved metrics

Total package byte prevSize

62183

1.46%

Number of package files

14

7.69%

Lines of code

172

17.81%

Worsened metrics

Dependency count

3

50%

Dependency changes

• + Added

  circular-json@^0.3.1

• + Added

  circular-json@0.3.3
  (transitive)