hpack.js - npm Package Compare versions

Comparing version 2.0.0 to 2.1.0

lib/hpack/decompressor.js

@@ -35,3 +35,3 @@ var hpack = require('../hpack');
 
-Decompressor.prototype.execute = function execute() {
+Decompressor.prototype.execute = function execute(cb) {
   while (!this._decoder.isEmpty()) {
@@ -41,5 +41,17 @@ try {
     } catch (err) {
-      return this.emit('error', err);
+      if (cb)
+        return done(err);
+      else
+        return this.emit('error', err);
     }
   }
+
+  if (cb)
+    done(null);
+
+  function done(err) {
+    process.nextTick(function() {
+      cb(err);
+    });
+  }
 };
@@ -46,0 +58,0 @@

package.json

 {
   "name": "hpack.js",
-  "version": "2.0.0",
+  "version": "2.1.0",
   "description": "HPACK implementation",
@@ -5,0 +5,0 @@ "main": "lib/hpack.js",

README.md

@@ -22,2 +22,3 @@ # HPACK.js
 decomp.write(raw);
+decomp.execute();
 console.log(decomp.read());
@@ -24,0 +25,0 @@ // { name: 'host', value: 'localhost', neverIndex: false }

test/decompressor-test.js

@@ -18,8 +18,7 @@ var assert = require('assert');
     it('should fail on 0-index', function(cb) {
-      decomp.on('error', function(err) {
+      decomp.write(new Buffer([ 0b10000000 ]));
+      decomp.execute(function(err) {
         assert(/zero index/i.test(err.message), err.message);
         cb();
       });
-      decomp.write(new Buffer([ 0b10000000 ]));
-      decomp.execute();
     });
@@ -44,8 +43,7 @@
     it('should fail on OOB-index', function(cb) {
-      decomp.on('error', function(err) {
+      decomp.write(new Buffer([ 0b11000000 ]));
+      decomp.execute(function(err) {
         assert(/field oob/i.test(err.message), err.message);
         cb();
       });
-      decomp.write(new Buffer([ 0b11000000 ]));
-      decomp.execute();
     });
@@ -89,8 +87,7 @@ });
 
-      decomp.on('error', function(err) {
+      decomp.write(new Buffer([ 0b10000000 | 62 ]));
+      decomp.execute(function(err) {
         assert(/field oob/i.test(err.message), err.message);
         cb();
       });
-      decomp.write(new Buffer([ 0b10000000 | 62 ]));
-      decomp.execute();
     });
@@ -97,0 +94,0 @@

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

85483

increased by0.12%

Lines of code

2574

increased by0.27%

Number of lines in readme file

53

increased by1.92%

No dependency changes