http-proxy-middleware - npm Package Compare versions

Comparing version 0.8.1 to 0.8.2

lib/handlers.js

@@ -7,4 +7,6 @@ module.exports = {
     var host = (req.headers && req.headers.host);
-    res.writeHead(500);
+    if (!res.headersSent) {
+        res.writeHead(500);
+    }
     res.end('Error occured while trying to proxy to: '+ host + req.url);
 };

package.json

 {
   "name": "http-proxy-middleware",
-  "version": "0.8.1",
+  "version": "0.8.2",
   "description": "The one-liner node.js proxy middleware for connect, express and browser-sync",
@@ -5,0 +5,0 @@ "main": "index.js",

test/handlers.spec.js

@@ -34,9 +34,14 @@ var expect = require('chai').expect;
             return v;
-        }
+        },
+        headersSent : false
     };
 
-    // simulate proxy error
-    handlers.proxyError(mockError, mockReq, mockRes, proxyOptions);
+    afterEach(function(){
+        httpErrorCode = undefined;
+        errorMessage = undefined;
+    });
 
+
     it('should set the http status code to: 500', function () {
+        handlers.proxyError(mockError, mockReq, mockRes, proxyOptions);
         expect(httpErrorCode).to.equal(500);
@@ -46,5 +51,18 @@ });
     it('should end the response and return error message', function () {
+        handlers.proxyError(mockError, mockReq, mockRes, proxyOptions);
         expect(errorMessage).to.equal('Error occured while trying to proxy to: localhost:3000/api');
     });
 
+    it('should not set the http status code to: 500 if headers have already been sent', function () {
+        mockRes.headersSent = true;
+        handlers.proxyError(mockError, mockReq, mockRes, proxyOptions);
+        expect(httpErrorCode).to.equal(undefined);
+    });
+
+    it('should end the response and return error message', function () {
+        mockRes.headersSent = true;
+        handlers.proxyError(mockError, mockReq, mockRes, proxyOptions);
+        expect(errorMessage).to.equal('Error occured while trying to proxy to: localhost:3000/api');
+    });
+
 });

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

85653

increased by3.5%

Number of package files

25

increased by4.17%

Lines of code

1500

increased by1.15%

No dependency changes