http2 - npm Package Compare versions

Comparing version 3.3.3 to 3.3.4

HISTORY.md

 Version history
 ===============
 
+### 3.3.4 (2016-04-22) ###
+* More PR bugfixes (https://github.com/molnarg/node-http2/issues?q=milestone%3Av3.3.4)
+
 ### 3.3.3 (2016-04-21) ###
@@ -5,0 +8,0 @@

lib/http.js

@@ -367,7 +367,7 @@ // Public API
   if (this.headersSent) {
-    throw new Error('Can\'t set headers after they are sent.');
+    return this.emit('error', new Error('Can\'t set headers after they are sent.'));
   } else {
     name = name.toLowerCase();
     if (deprecatedHeaders.indexOf(name) !== -1) {
-      throw new Error('Cannot set deprecated header: ' + name);
+      return this.emit('error', new Error('Cannot set deprecated header: ' + name));
     }
@@ -380,3 +380,3 @@ this._headers[name] = value;
   if (this.headersSent) {
-    throw new Error('Can\'t remove headers after they are sent.');
+    return this.emit('error', new Error('Can\'t remove headers after they are sent.'));
   } else {
@@ -828,3 +828,8 @@ delete this._headers[name.toLowerCase()];
   }
-  return (options.agent || exports.globalAgent).request(options, callback);
+  if (options.agent && typeof(options.agent.request) === 'function') {
+    var agentOptions = util._extend({}, options);
+    delete agentOptions.agent;
+    return options.agent.request(agentOptions, callback);
+  }
+  return exports.globalAgent.request(options, callback);
 }
@@ -840,3 +845,8 @@
   }
-  return (options.agent || exports.globalAgent).request(options, callback);
+  if (options.agent && typeof(options.agent.request) === 'function') {
+    var agentOptions = util._extend({}, options);
+    delete agentOptions.agent;
+    return options.agent.request(agentOptions, callback);
+  }
+  return exports.globalAgent.request(options, callback);
 }
@@ -852,3 +862,8 @@
   }
-  return (options.agent || exports.globalAgent).get(options, callback);
+  if (options.agent && typeof(options.agent.get) === 'function') {
+    var agentOptions = util._extend({}, options);
+    delete agentOptions.agent;
+    return options.agent.get(agentOptions, callback);
+  }
+  return exports.globalAgent.get(options, callback);
 }
@@ -864,3 +879,8 @@
   }
-  return (options.agent || exports.globalAgent).get(options, callback);
+  if (options.agent && typeof(options.agent.get) === 'function') {
+    var agentOptions = util._extend({}, options);
+    delete agentOptions.agent;
+    return options.agent.get(agentOptions, callback);
+  }
+  return exports.globalAgent.get(options, callback);
 }
@@ -909,3 +929,3 @@
     this._log.error('Trying to negotiate client request with Upgrade from HTTP/1.1');
-    throw new Error('HTTP1.1 -> HTTP2 upgrade is not yet supported.');
+    this.emit('error', new Error('HTTP1.1 -> HTTP2 upgrade is not yet supported.'));
   }
@@ -946,2 +966,7 @@
 
+    endpoint.on('error', function(error){
+      self._log.error('Connection error: ' + error.toString());
+      request.emit('error', error);
+    });
+
     this.endpoints[key] = endpoint;
@@ -969,2 +994,3 @@ endpoint.pipe(endpoint.socket).pipe(endpoint);
       self._log.error('Socket error: ' + error.toString());
+      self.removeAllListeners(key);
       request.emit('error', error);
@@ -971,0 +997,0 @@ });

lib/protocol/stream.js

@@ -628,3 +628,3 @@ var assert = require('assert');
       this._log.error(info, 'Sending illegal frame.');
-      throw new Error('Sending illegal frame (' + frame.type + ') in ' + this.state + ' state.');
+      return this.emit('error', new Error('Sending illegal frame (' + frame.type + ') in ' + this.state + ' state.'));
     }
@@ -631,0 +631,0 @@

package.json

 {
   "name": "http2",
-  "version": "3.3.3",
+  "version": "3.3.4",
   "description": "An HTTP/2 client and server implementation",
@@ -5,0 +5,0 @@ "main": "lib/index.js",

New alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Fixed alerts

License Policy Violation

License

This package is not allowed per your license policy. Review the package's license to ensure compliance.

Found 1 instance in 1 package

Improved metrics

Total package byte prevSize

718572

increased by187.27%

Number of package files

31

increased by14.81%

Lines of code

5128

increased by0.63%

No dependency changes